pgsql: Skip empty transaction stream in test_decoding.

2020-09-10 Thread Amit Kapila
Skip empty transaction stream in test_decoding. We were decoding empty transactions via streaming APIs added in commit 45fdc9738b even when the user used the option 'skip-empty-xacts'. The APIs makes no effort to skip empty xacts under the assumption that we will never try to stream such transacti

pgsql: Doc: some more v13 release note tweaking.

2020-09-10 Thread Tom Lane
Doc: some more v13 release note tweaking. Justin Pryzby Discussion: https://postgr.es/m/20200910222705.gj18...@telsasoft.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9892564121d425291c4fd06ff083147dd70b9156 Modified Files -- doc/src/sgml/

pgsql: Print WAL logical message contents in pg_waldump

2020-09-10 Thread Alvaro Herrera
Print WAL logical message contents in pg_waldump This helps debuggability when looking at WAL streams containing logical messages. Author: Ashutosh Bapat Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/caexhw5swx49rkmxbg5h1xc1t+nrv9paykqmgw82hpt6vwdv...@mail.gmail.com Branch -

pgsql: Doc: update v13 release notes through today, do a copy-editing p

2020-09-10 Thread Tom Lane
Doc: update v13 release notes through today, do a copy-editing pass. Also set the release date ... hopefully we won't have to change that. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3965de54e718600a4703233936e56a3202caf73f Modified Files --

pgsql: Doc: fill in "major enhancements" list in v13 release notes.

2020-09-10 Thread Tom Lane
Doc: fill in "major enhancements" list in v13 release notes. Jonathan S. Katz, minor tweaks by me Discussion: https://postgr.es/m/448a382b-ae07-3126-5a08-aacda9aa2...@postgresql.org Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3d92252d7d8bf7080ba61f1bda3

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: Use _exit(2) for SIGQUIT during ProcessStartupPacket, too.

2020-09-10 Thread Tom Lane
Use _exit(2) for SIGQUIT during ProcessStartupPacket, too. Bring the signal handling for startup-packet collection into line with the policy established in commits bedadc732 and 8e19a8264, namely don't risk running atexit callbacks when handling SIGQUIT. Ideally, we'd not do so for SIGTERM or tim

pgsql: New contrib module, pg_surgery, with heap surgery functions.

2020-09-10 Thread Robert Haas
New contrib module, pg_surgery, with heap surgery functions. Sometimes it happens that the visibility information for a tuple becomes corrupted, either due to bugs in the database software or external factors. Provide a function heap_force_kill() that can be used to truncate such dead tuples to de

pgsql: Remove unused parameter

2020-09-10 Thread Peter Eisentraut
Remove unused parameter Apparently, this was never used when introduced (3dad73e71f08abd86564d5090a58ca71740e07e0). Discussion: https://www.postgresql.org/message-id/flat/511bb100-f829-ba21-2f10-9f952ec06ead%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/c

pgsql: Add libpq's openssl dependencies to pkg-config file

2020-09-10 Thread Peter Eisentraut
Add libpq's openssl dependencies to pkg-config file Add libssl and libcrypto to libpq.pc's Requires.private. This allows static linking to work if those libssl or libcrypto themselves have dependencies in their *.private fields, such as -lz in some cases. Reported-by: Sandro Mani Discussion: h

pgsql: doc: Remove buggy ICU collation from documentation

2020-09-10 Thread Peter Eisentraut
doc: Remove buggy ICU collation from documentation We have had multiple reports that point to the '@colReorder=latn-digit' collation customization being buggy. We have reported this to ICU and are waiting for a fix. In the meantime, remove references to this from the documentation and replace it

pgsql: doc: Remove buggy ICU collation from documentation

2020-09-10 Thread Peter Eisentraut
doc: Remove buggy ICU collation from documentation We have had multiple reports that point to the '@colReorder=latn-digit' collation customization being buggy. We have reported this to ICU and are waiting for a fix. In the meantime, remove references to this from the documentation and replace it

pgsql: doc: Remove buggy ICU collation from documentation

2020-09-10 Thread Peter Eisentraut
doc: Remove buggy ICU collation from documentation We have had multiple reports that point to the '@colReorder=latn-digit' collation customization being buggy. We have reported this to ICU and are waiting for a fix. In the meantime, remove references to this from the documentation and replace it

pgsql: doc: Remove buggy ICU collation from documentation

2020-09-10 Thread Peter Eisentraut
doc: Remove buggy ICU collation from documentation We have had multiple reports that point to the '@colReorder=latn-digit' collation customization being buggy. We have reported this to ICU and are waiting for a fix. In the meantime, remove references to this from the documentation and replace it

pgsql: doc: Remove buggy ICU collation from documentation

2020-09-10 Thread Peter Eisentraut
doc: Remove buggy ICU collation from documentation We have had multiple reports that point to the '@colReorder=latn-digit' collation customization being buggy. We have reported this to ICU and are waiting for a fix. In the meantime, remove references to this from the documentation and replace it

pgsql: Add more tests for EXTRACT of date type

2020-09-10 Thread Peter Eisentraut
Add more tests for EXTRACT of date type EXTRACT of date type is implemented as a wrapper around EXTRACT of timestamp, so the code is already tested there. But the externally visible behavior of EXTRACT on date is not recorded anywhere. Since there is some discussion about reimplementing or refac

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a9d6f7466d393fef209598a72a6c32b092371bd9 Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e30f1aa35832d20e257821958bec75ddcc4e10b7 Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/059872cea147617f688d314664df99d73a9c407e Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4f737ca15b92abd4081cf400da2d4498154ae106 Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/994a58407c89724917b05a1564dcf1f2f7f3ea9a Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 insertion

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5962498221b61c79db25bd2c21647913c9cb4fdb Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

pgsql: Fix title in reference section

2020-09-10 Thread Magnus Hagander
Fix title in reference section Reported-by: Robert Kahlert Author: Daniel Gustafsson Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/727f6fb8f71f7ed64e6883164765bbf6cb7684ec Modified Files -- doc/src/sgml/biblio.sgml | 4 ++-- 1 file changed, 2 in

Re: pgsql: Implement streaming mode in ReorderBuffer.

2020-09-10 Thread Amit Kapila
On Thu, Sep 10, 2020 at 9:18 AM Amit Kapila wrote: > > On Thu, Sep 10, 2020 at 4:17 AM Tom Lane wrote: > > > > Amit Kapila writes: > > > Implement streaming mode in ReorderBuffer. > > > > Looks like this test is somewhat unstable still: > > > > > > Thanks for pointing out. I'll analyze and share

pgsql: Clean up some code and comments in partbounds.c.

2020-09-10 Thread Etsuro Fujita
Clean up some code and comments in partbounds.c. Do some minor cleanup for commit c8434d64c: 1) remove a useless assignment (in normal builds) and 2) improve comments a little. Back-patch to v13 where the aforementioned commit went in. Author: Etsuro Fujita Reviewed-by: Alvaro Herrera Discussion

pgsql: Clean up some code and comments in partbounds.c.

2020-09-10 Thread Etsuro Fujita
Clean up some code and comments in partbounds.c. Do some minor cleanup for commit c8434d64c: 1) remove a useless assignment (in normal builds) and 2) improve comments a little. Back-patch to v13 where the aforementioned commit went in. Author: Etsuro Fujita Reviewed-by: Alvaro Herrera Discussion

pgsql: Doc: clean up contributor names.

2020-09-10 Thread Etsuro Fujita
Doc: clean up contributor names. Standardize Japanese names as given-name-first. Author: Etsuro Fujita Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/capmgk14s5frhwzsks14r2lemjkkjr5peqrgikz0os0a+o8b...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgr