pgsql: Fix assertion in collation version lookup.

2020-11-07 Thread Thomas Munro
Fix assertion in collation version lookup. Commit 257836a7 included an assertion that a version lookup routine is not trying to look up "C" or "POSIX", but that case is reachable with the user-facing SQL function pg_collation_actual_version(). Remove the assertion. Branch -- master Details

pgsql: Fix test for error message change

2020-11-07 Thread Peter Eisentraut
Fix test for error message change fix for 6be725e701611660b36642de9ff1d665a1eb24f5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8cff66d309b90e03f1e76494375960f35eff6424 Modified Files -- src/test/ssl/t/002_scram.pl | 2 +- 1 file changed, 1 insertion(

pgsql: Fix test for error message change

2020-11-07 Thread Peter Eisentraut
Fix test for error message change fix for f3ad4fddfaf71e8f6f037cd627f398ba43625ca1 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ca6f685b834518187b15926d196c5dbb086efe7 Modified Files -- src/test/ssl/t/002_scram.pl | 2 +- 1 file changed, 1 ins

Re: pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Tom Lane
Peter Eisentraut writes: > Fix redundant error messages in client tools Looks like you did not update the ssl tests. This *must* get fixed before Monday's wrap. regards, tom lane

pgsql: Improve nbtree README's LP_DEAD section.

2020-11-07 Thread Peter Geoghegan
Improve nbtree README's LP_DEAD section. The description of how LP_DEAD bit setting by index scans works following commit 2ed5b87f was rather unclear. Clean that up a bit. Also refer to LP_DEAD bit setting within _bt_check_unique() at the start of the same section. This mechanism may actually b

pgsql: Message style improvements

2020-11-07 Thread Alvaro Herrera
Message style improvements * Avoid pointlessly highlighting that an index vacuum was executed by a parallel worker; user doesn't care. * Don't give the impression that a non-concurrent reindex of an invalid index on a TOAST table would work, because it wouldn't. * Add a "translator:" comment

pgsql: Message style improvements

2020-11-07 Thread Alvaro Herrera
Message style improvements * Avoid pointlessly highlighting that an index vacuum was executed by a parallel worker; user doesn't care. * Don't give the impression that a non-concurrent reindex of an invalid index on a TOAST table would work, because it wouldn't. * Add a "translator:" comment

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL_12_STABLE Details --- https://git.postgresql.

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL_13_STABLE Details --- https://git.postgresql.

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL_11_STABLE Details --- https://git.postgresql.

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.

pgsql: Fix redundant error messages in client tools

2020-11-07 Thread Peter Eisentraut
Fix redundant error messages in client tools A few client tools duplicate error messages already provided by libpq. Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com Branch -- REL_10_STABLE Details --- https://git.postgresql.

pgsql: Avoid re-using output variables in new ecpg test case.

2020-11-07 Thread Tom Lane
Avoid re-using output variables in new ecpg test case. The buildfarm thinks this leads to memory stomps, though annoyingly I can't duplicate that here. The existing code in strings.pgc is doing something that doesn't seem to be sanctioned at all really by the documentation, but I'm disinclined to

pgsql: Avoid re-using output variables in new ecpg test case.

2020-11-07 Thread Tom Lane
Avoid re-using output variables in new ecpg test case. The buildfarm thinks this leads to memory stomps, though annoyingly I can't duplicate that here. The existing code in strings.pgc is doing something that doesn't seem to be sanctioned at all really by the documentation, but I'm disinclined to

pgsql: Doc: small release note updates.

2020-11-07 Thread Tom Lane
Doc: small release note updates. Add items committed in the last 24 hours. Also correct my failure to credit Nikita Glukhov for 52ad1e659, which did all the heavy lifting for 3db322eaa. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7fb326e04b5c367f03b2ebb8

pgsql: Fix ecpg's mishandling of B'...' and X'...' literals.

2020-11-07 Thread Tom Lane
Fix ecpg's mishandling of B'...' and X'...' literals. These were broken in multiple ways: * The xbstart and xhstart lexer actions neglected to set "state_before_str_start" before transitioning to the xb/xh states, thus possibly resulting in "internal error: unreachable state" later. * The test f

pgsql: Fix ecpg's mishandling of B'...' and X'...' literals.

2020-11-07 Thread Tom Lane
Fix ecpg's mishandling of B'...' and X'...' literals. These were broken in multiple ways: * The xbstart and xhstart lexer actions neglected to set "state_before_str_start" before transitioning to the xb/xh states, thus possibly resulting in "internal error: unreachable state" later. * The test f

pgsql: Move catalog index declarations

2020-11-07 Thread Peter Eisentraut
Move catalog index declarations Move the system catalog index declarations from catalog/indexing.h to the respective parent tables' catalog/pg_*.h files. The original reason for having it split was that the old genbki system produced the output in the order of the catalog files it read, so all th

pgsql: Move catalog toast table declarations

2020-11-07 Thread Peter Eisentraut
Move catalog toast table declarations Move the system catalog toast table declarations from catalog/toasting.h to the respective parent tables' catalog/pg_*.h files. The original reason for having it split was that the old genbki system produced the output in the order of the catalog files it rea