Jeff Davis writes:
> Fix bug #16784 in Disk-based Hash Aggregation.
Buildfarm thinks this new test case is not completely stable.
It appears that only 32-bit machines are failing, and it's
not totally consistent even for them. Dunno what to make of it.
regards, tom lane
On Sun, Dec 27, 2020 at 10:11:17AM +0900, Michael Paquier wrote:
> Hmm. That sounds like a fair concern to me. Based on the information
> given by the docs, three keys are actually created/used at initdb
> time:
> - One for the relation files, that does not have to be shared across
> the nodes in
Fix bug #16784 in Disk-based Hash Aggregation.
Before processing tuples, agg_refill_hash_table() was setting all
pergroup pointers to NULL to signal to advance_aggregates() that it
should not attempt to advance groups that had spilled.
The problem was that it also set the pergroups for sorted gro
Fix bug #16784 in Disk-based Hash Aggregation.
Before processing tuples, agg_refill_hash_table() was setting all
pergroup pointers to NULL to signal to advance_aggregates() that it
should not attempt to advance groups that had spilled.
The problem was that it also set the pergroups for sorted gro
On Sat, Dec 26, 2020 at 06:03:00AM -0400, Fabien COELHO wrote:
> The feeling I expressed early in the thread is that the design should be
> extendable, so that it does not fit only one particular use-case but fail at
> any other that were not the author's, and a large reimplementation would be
> ne
On Sat, Dec 26, 2020 at 12:18:18PM -0500, Bruce Momjian wrote:
> I can easily revert and come back, though the buildfarm is green now.
> As far as testing, I can test that the cluster key unlocks the data
> keys, but there is no current interface to the data keys. Ideally we
> would test the full
On Sat, Dec 26, 2020 at 11:45:41AM -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
> >> The CF bot at http://cfbot.cputube.org/ includes tests on Windows, so
> >> those problems would have been detected beforehand. Did you look a
Bruce Momjian writes:
> On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
>> The CF bot at http://cfbot.cputube.org/ includes tests on Windows, so
>> those problems would have been detected beforehand. Did you look at
>> these? If this cannot be fixed, could it be possible to reve
so 26. 12. 2020 v 16:33 odesílatel Bruce Momjian napsal:
> aOn Sat, Dec 26, 2020 at 10:27:24AM -0500, Bruce Momjian wrote:
> > Thank you for your report. When I did the Windows port and pg_upgrade,
> > we didn't have all of the test infrastructure we have now, so I wasn't
> > even aware of all o
so 26. 12. 2020 v 16:27 odesílatel Bruce Momjian napsal:
> On Sat, Dec 26, 2020 at 04:23:59PM +0100, Pavel Stehule wrote:
> > Details
> > ---
> > https://git.postgresql.org/pg/commitdiff/
> > e174a6f1937248886e124cdb68408e727aeea278
> >
> > Modified Files
> > -
aOn Sat, Dec 26, 2020 at 10:27:24AM -0500, Bruce Momjian wrote:
> Thank you for your report. When I did the Windows port and pg_upgrade,
> we didn't have all of the test infrastructure we have now, so I wasn't
> even aware of all of this. The buildfarm is almost all green now so I
> think we are
On Sat, Dec 26, 2020 at 04:23:59PM +0100, Pavel Stehule wrote:
> Details
> ---
> https://git.postgresql.org/pg/commitdiff/
> e174a6f1937248886e124cdb68408e727aeea278
>
> Modified Files
> --
> src/bin/pg_alterckey/Makefile | 6 --
> 1 file changed,
so 26. 12. 2020 v 15:03 odesílatel Bruce Momjian napsal:
> pg_alterckey: remove TAP check rules from Makefile
>
> Reported-by: Pavel Stehule, Michael Paquier
>
> Discussion:
> https://postgr.es/m/cafj8prbrno4co5bqcx4blx1zz45z_t-oppxa+u7slp7gatb...@mail.gmail.com
>
> Backpatch-through: master
>
>
On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
> The CF bot at http://cfbot.cputube.org/ includes tests on Windows, so
> those problems would have been detected beforehand. Did you look at
> these? If this cannot be fixed, could it be possible to revert
> please? It looks rathe
initdb: document that -K requires an argument
Reported-by: "Shinoda, Noriyoshi"
Discussion:
https://postgr.es/m/tu4pr8401mb1152e92b4d44c81e496d6032ee...@tu4pr8401mb1152.namprd84.prod.outlook.com
Author: "Shinoda, Noriyoshi"
Backpatch-through: msater
Branch
--
master
Details
---
http
On Sat, Dec 26, 2020 at 09:09:05PM +1100, Robins Tharakan wrote:
> This script seems to have broken my instance.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=massasauga&dt=
> 2020-12-26%2006%3A20%3A19
Should be fixed now. Sorry.
--
Bruce Momjian https://momjian.us
Ente
auth commands: list specific commands to install in Makefile
Previously I used Makefile functions.
Backpatch-through: master
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/ba6725df364cd30e068ccd962fa426d9b7b44066
Modified Files
--
src/backend/Makefil
On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
> On Sat, Dec 26, 2020 at 08:29:10AM +0100, Pavel Stehule wrote:
> > I did recheck with same result
>
> The Makefile of pg_alterckey is busted, and adding --enable-tap-tests
> to the options of ./configure is enough to see a failure.
pg_alterckey: remove TAP check rules from Makefile
Reported-by: Pavel Stehule, Michael Paquier
Discussion:
https://postgr.es/m/cafj8prbrno4co5bqcx4blx1zz45z_t-oppxa+u7slp7gatb...@mail.gmail.com
Backpatch-through: master
Branch
--
master
Details
---
https://git.postgresql.org/pg/commi
This script seems to have broken my instance.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=massasauga&dt=2020-12-26%2006%3A20%3A19
-
robins
On Sat, 26 Dec 2020 at 17:19, Bruce Momjian wrote:
> Add scripts for retrieving the cluster file encryption key
>
> Scripts are passphrase, dir
Hello Bruce
Tom>> Possibly these commits need more review than you think.
Michaël> Shared feeling here, I think that this is still too early.
Michaël> FWIW, I am surprised that this patch series includes exactly zero line of code
Michaël> for tests, while the total amount of code committed is
On Sat, Dec 26, 2020 at 06:16:37PM +0900, Michael Paquier wrote:
> I would like to point out that all non-Unix buildfarm members are
> broken like fairywen because of the addition of those scripts:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2020-12-26%2009%3A04%3A27
> /u
On Sat, Dec 26, 2020 at 08:29:10AM +0100, Pavel Stehule wrote:
> I did recheck with same result
The Makefile of pg_alterckey is busted, and adding --enable-tap-tests
to the options of ./configure is enough to see a failure. In short,
src/bin/pg_alterckey/Makefile includes the following lines, but
23 matches
Mail list logo
