pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Fix bug in WAL replay of COMMIT_TS_SETTS record.

2021-03-24 Thread Fujii Masao
Fix bug in WAL replay of COMMIT_TS_SETTS record. Previously the WAL replay of COMMIT_TS_SETTS record called TransactionTreeSetCommitTsData() with the argument write_xlog=true, which generated and wrote new COMMIT_TS_SETTS record. This should not be acceptable because it's during recovery. This co

pgsql: Improve connection denied error message during recovery.

2021-03-24 Thread Fujii Masao
Improve connection denied error message during recovery. Previously when an archive recovery or a standby was starting and reached the consistent recovery state but hot_standby was configured to off, the error message when a client connectted was "the database system is starting up", which was nee

RE: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

2021-03-24 Thread tsunakawa.ta...@fujitsu.com
From: Robert Haas > The amount of code isn't the issue. I'd rather expend a little more > code and solve the problem in a better way. Reading your reply to Andres-san, I feel sympathy about your attitude. Maybe we should outline the (rough) design first, discuss/guess its complexity, and ask f

pgsql: Allow for installation-aware instances of PostgresNode

2021-03-24 Thread Andrew Dunstan
Allow for installation-aware instances of PostgresNode Currently instances of PostgresNode find their Postgres executables in the PATH of the caller. This modification allows for instances that know the installation path they are supposed to use, and the module adjusts the environment of methods t

pgsql: Need to step forward in the loop to get to an end.

2021-03-24 Thread Michael Meskes
Need to step forward in the loop to get to an end. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/65c2ec6f30d9c0878a9ef83e0ec9a53e6b82d9d8 Modified Files -- src/interfaces/ecpg/preproc/ecpg.c | 1 + 1 file changed, 1 insertion(+)

pgsql: Add DECLARE STATEMENT command to ECPG

2021-03-24 Thread Michael Meskes
Add DECLARE STATEMENT command to ECPG This command declares a SQL identifier for a SQL statement to be used in other embedded SQL statements. The identifier is linked to a connection. Author: Hayato Kuroda Reviewed-by: Shawn Wang Discussion: https://www.postgresql.org/message-id/flat/ty2pr01mb

pgsql: doc: Fix typo

2021-03-24 Thread Peter Eisentraut
doc: Fix typo Reported-by: Erik Rijkers Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5173e428928ce890be3e3d809b2d23d5f3c7da2f Modified Files -- doc/src/sgml/func.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix stray double semicolons

2021-03-24 Thread Peter Eisentraut
Fix stray double semicolons Reported-by: John Naylor Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/37c99d304dcbf12ab581ff031f394af93b750895 Modified Files -- src/backend/access/brin/brin_minmax.c | 2 +- src/backend/utils/adt/timestamp.c | 4 ++--

pgsql: Change checkpoint_completion_target default to 0.9

2021-03-24 Thread Stephen Frost
Change checkpoint_completion_target default to 0.9 Common recommendations are that the checkpoint should be spread out as much as possible, provided we avoid having it take too long. This change updates the default to 0.9 (from 0.5) to match that recommendation. There was some debate about possi

pgsql: Tidy up more loose ends related to configurable TOAST compressio

2021-03-24 Thread Robert Haas
Tidy up more loose ends related to configurable TOAST compression. Change the default_toast_compression GUC to be an enum rather than a string. Earlier, uncommitted versions of the patch supported using CREATE ACCESS METHOD to add new compression methods to a running system, but that idea was drop

pgsql: Add date_bin function

2021-03-24 Thread Peter Eisentraut
Add date_bin function Similar to date_trunc, but allows binning by an arbitrary interval rather than just full units. Author: John Naylor Reviewed-by: David Fetter Reviewed-by: Isaac Morland Reviewed-by: Tom Lane Reviewed-by: Artur Zakirov Discussion: https://www.postgresql.org/message-id/f

Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

2021-03-24 Thread Robert Haas
On Wed, Mar 24, 2021 at 12:48 AM Andres Freund wrote: > That seems like an argument for a pg_class attribute about parallel > safety of the current relation *and* its children. It'd definitely mean > recursing higher in the partition tree during DDL if the action on a > child partition causes the

Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

2021-03-24 Thread Robert Haas
On Wed, Mar 24, 2021 at 12:30 AM Tom Lane wrote: > How about a declarative approach instead? That is, if a user would > like parallelized inserts into a partitioned table, she must declare > the table parallel-safe with some suitable annotation. Then, checking > the property during DML is next d

Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

2021-03-24 Thread Robert Haas
On Tue, Mar 23, 2021 at 11:13 PM tsunakawa.ta...@fujitsu.com wrote: > One problem with caching the result is that the first access in each session > has to experience the slow processing. Some severe customers of our > proprietary database, which is not based on Postgres, have requested to > e

pgsql: Improve an error message

2021-03-24 Thread Peter Eisentraut
Improve an error message Make it the same as another nearby message. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1509c6fc29c07d13c9a590fbd6f37c7576f58ba6 Modified Files -- src/backend/replication/logical/tablesync.c | 2 +- 1 file changed, 1 insertio