Re: pgsql: Add unistr function

On 31.03.21 05:31, Tom Lane wrote: Peter Eisentraut writes: Add unistr function This has had negative consequences for PDF docs builds: [WARN] FOUserAgent - Glyph "?" (0x441, afii10083) not available in font "Courier". [WARN] FOUserAgent - Glyph "?" (0x43b, afii10077) not available in font

pgsql: doc: Remove Cyrillic from unistr example

doc: Remove Cyrillic from unistr example Not supported by PDF build right now, so let's do without it. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/287d2a97c1de07486e4525c8ad06258f04bd6268 Modified Files -- doc/src/sgml/func.sgml | 4 1 file chan

pgsql: Remove extra semicolon in postgres_fdw tests.

Remove extra semicolon in postgres_fdw tests. Author: Suraj Kharage Reviewed-by: Bharath Rupireddy, Vignesh C Discussion: https://postgr.es/m/CAF1DzPWRfxUeH-wShz7P_pK5Tx6M_nEK+TkS8gn5ngvg07Q5=g...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/13cb5

Re: pgsql: Add unistr function

Peter Eisentraut writes: > Add unistr function This has had negative consequences for PDF docs builds: [WARN] FOUserAgent - Glyph "?" (0x441, afii10083) not available in font "Courier". [WARN] FOUserAgent - Glyph "?" (0x43b, afii10077) not available in font "Courier". [WARN] FOUserAgent - Glyp

pgsql: Doc: Use consistent terminology for tablesync slots.

Doc: Use consistent terminology for tablesync slots. At some places in the docs, we refer to them as tablesync slots and at other places as table synchronization slots. For consistency, we refer to them as table synchronization slots at all places. Author: Peter Smith Reviewed-by: Amit Kapila Dis

pgsql: Accept slightly-filled pages for tuples larger than fillfactor.

Accept slightly-filled pages for tuples larger than fillfactor. We always inserted a larger-than-fillfactor tuple into a newly-extended page, even when existing pages were empty or contained nothing but an unused line pointer. This was unnecessary relation extension. Start tolerating page usage

pgsql: Fix comment in parsenodes.h

Fix comment in parsenodes.h CreateStmt->inhRelations is a list of RangeVars, but a comment was incorrect about that. Author: Julien Rouhaud Discussion: https://postgr.es/m/20210330123015.yzekhz5sweqbgxdr@nol Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7ef64e7e7

pgsql: Add support for --extension in pg_dump

Add support for --extension in pg_dump When specified, only extensions matching the given pattern are included in dumps. Similarly to --table and --schema, when --strict-names is used, a perfect match is required. Also, like the two other options, this new option offers no guarantee that depend

pgsql: Remove small inefficiency in ExecARDeleteTriggers/ExecARUpdateTr

Remove small inefficiency in ExecARDeleteTriggers/ExecARUpdateTriggers. Whilst poking at nodeModifyTable.c, I chanced to notice that while its calls to ExecBR*Triggers and ExecIR*Triggers are protected by tests to see if there are any relevant triggers to fire, its calls to ExecAR*Triggers are not

pgsql: adjust dblink regression expected output for commit 5da9868ed9

adjust dblink regression expected output for commit 5da9868ed9 Seems the -1/singular output is used in the dblink regression tests. Reported-by: Álvaro Herrera Discussion: https://postgr.es/m/20210330231506.GA10666@alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/

Re: pgsql: In messages, use singular nouns for -1, like we do for +1.

On Tue, Mar 30, 2021 at 07:20:32PM -0400, Bruce Momjian wrote: > On Tue, Mar 30, 2021 at 08:15:06PM -0300, Álvaro Herrera wrote: > > On 2021-Mar-30, Bruce Momjian wrote: > > > > > In messages, use singular nouns for -1, like we do for +1. > > > > > > This outputs "-1 year", not "-1 years". > > >

pgsql: libpq_pipeline: add PQtrace() support and tests

libpq_pipeline: add PQtrace() support and tests The libpq_pipeline program recently introduced by commit acb7e4eb6b1c is well equipped to test the PQtrace() functionality, so let's make it do that. Author: Álvaro Herrera Discussion: https://postgr.es/m/20210327192812.GA25115@alvherre.pgsql Bran

Re: pgsql: In messages, use singular nouns for -1, like we do for +1.

On Tue, Mar 30, 2021 at 08:15:06PM -0300, Álvaro Herrera wrote: > On 2021-Mar-30, Bruce Momjian wrote: > > > In messages, use singular nouns for -1, like we do for +1. > > > > This outputs "-1 year", not "-1 years". > > This broke the dblink test ... OK, checking. I am testing check-world now.

pgsql: Improve PQtrace() output format

Improve PQtrace() output format Transform the PQtrace output format from its ancient (and mostly useless) byte-level output format to a logical-message-level output, making it much more usable. This implementation allows the printing code to be written (as it indeed was) by looking at the protoco

Re: pgsql: In messages, use singular nouns for -1, like we do for +1.

On 2021-Mar-30, Bruce Momjian wrote: > In messages, use singular nouns for -1, like we do for +1. > > This outputs "-1 year", not "-1 years". This broke the dblink test ... -- Álvaro Herrera Valdivia, Chile

pgsql: In messages, use singular nouns for -1, like we do for +1.

In messages, use singular nouns for -1, like we do for +1. This outputs "-1 year", not "-1 years". Reported-by: neverov@gmail.com Bug: 16939 Discussion: https://postgr.es/m/16939-cceeb03fb7273...@postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/

pgsql: Add tests for date_part of epoch near upper bound of timestamp r

Add tests for date_part of epoch near upper bound of timestamp range This exercises a special case in the implementations of date_part('epoch', timestamp[tz]) that was previously not tested. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6131ffc43ff3d2f566e93f017e5

pgsql: Use a WaitLatch for vacuum/autovacuum sleeping

Use a WaitLatch for vacuum/autovacuum sleeping Instead of using pg_usleep() in vacuum_delay_point(), use a WaitLatch. This has the advantage that we will realize if the postmaster has been killed since the last time we decided to sleep while vacuuming. Reviewed-by: Thomas Munro Discussion: https

pgsql: Further tweaking of pg_dump's handling of default_toast_compress

Further tweaking of pg_dump's handling of default_toast_compression. As committed in bbe0a81db, pg_dump from a pre-v14 server effectively acts as though you'd said --no-toast-compression. I think the right thing is for it to act as though default_toast_compression is set to "pglz", instead, so th

pgsql: Allow estimate_num_groups() to pass back further details about t

Allow estimate_num_groups() to pass back further details about the estimation Here we add a new output parameter to estimate_num_groups() to allow it to inform the caller of additional, possibly useful information about the estimation. The new output parameter is a struct that currently contains

pgsql: Fix compiler warning in unistr function

Fix compiler warning in unistr function Some compilers are not aware that elog/ereport ERROR does not return. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/efd9d92bb39c74c2aded64fc08e2d601ce20c39d Modified Files -- src/backend/utils/adt/varlena.c | 1

Re: pgsql: Implement pipeline mode in libpq

Hi Alvaro, On Tue, 16 Mar 2021 at 10:20, Alvaro Herrera wrote: > > Implement pipeline mode in libpq > src/test/modules/libpq_pipeline/libpq_pipeline.c | 1303 I'm wondering if you meant to leave the "#define DEBUG" line at line 34 in the above file? It seems pretty strang