pgsql: amcheck: Use correct format placeholder for TOAST chunk numbers

2021-04-14 Thread Peter Eisentraut
amcheck: Use correct format placeholder for TOAST chunk numbers Several of these were already fixed in passing in 9acaf1a62197205b06a85afbfcaa7ffaac939ef3, but one was remaining inconsistent. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/59da8d9eb7255c3cb1c9f3b79d

Re: pgsql: Use SIGURG rather than SIGUSR1 for latches.

2021-04-14 Thread Tom Lane
Thomas Munro writes: > Use SIGURG rather than SIGUSR1 for latches. I notice that postmaster.c still does #ifdef SIGURG pqsignal_pm(SIGURG, SIG_IGN); /* ignored */ #endif It appears to me that this should now read pqsignal_pm(SIGURG, dummy_handler);/* unused, reserve for ch

pgsql: Tweak behavior of pg_dump --extension with configuration tables

2021-04-14 Thread Michael Paquier
Tweak behavior of pg_dump --extension with configuration tables 6568cef, that introduced the option, had an inconsistent behavior when it comes to configuration tables set up by pg_extension_config_dump, as the data of all configuration tables would included in a dump even for extensions not liste

pgsql: Fix obsolete comments referencing JoinPathExtraData.extra_latera

2021-04-14 Thread Tom Lane
Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels. That field went away in commit edca44b15, but it seems that commit 45be99f8c re-introduced some comments mentioning it. Noted by James Coleman, though this isn't exactly his proposed new wording. Also thanks to Justin Pryzby

pgsql: amcheck: Reword some messages and fix an alignment problem.

2021-04-14 Thread Robert Haas
amcheck: Reword some messages and fix an alignment problem. We don't need to mention the attribute number in these messages, because there's a dedicated column for that, but we should mention the toast value ID, because that's really useful for any follow-up troubleshooting the user wants to do. T

pgsql: Improve quoting in some error messages

2021-04-14 Thread Peter Eisentraut
Improve quoting in some error messages Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/07e5e66742333ab100a557e6e3f710e92fa1fd92 Modified Files -- contrib/amcheck/verify_nbtree.c| 6 +++--- src/backend/access/brin/brin.c | 4 ++-- src/backend/access