Re: pgsql: Use SIGURG rather than SIGUSR1 for latches.

2021-04-15 Thread Thomas Munro
On Thu, Apr 15, 2021 at 10:50 PM Thomas Munro wrote: > On Thu, Apr 15, 2021 at 2:26 PM Tom Lane wrote: > > It's possible that that argument doesn't apply to the way SIGURG is used > > in this patch, but I don't see a good reason to ignore the convention of > > setting up the handler this way. > >

pgsql: Add information of total data processed to replication slot stat

2021-04-15 Thread Amit Kapila
Add information of total data processed to replication slot stats. This adds the statistics about total transactions count and total transaction data logically sent to the decoding output plugin from ReorderBuffer. Users can query the pg_stat_replication_slots view to check these stats. Suggested

pgsql: Doc: Document known problem with Windows collation versions.

2021-04-15 Thread Thomas Munro
Doc: Document known problem with Windows collation versions. Warn users that locales with traditional Windows NLS names like "English_United States.1252" won't provide version information, and that something like initdb --lc-collate=en-US would be needed to fix that problem for the initial templat

pgsql: Provide query source text when parsing a SQL-standard function b

2021-04-15 Thread Tom Lane
Provide query source text when parsing a SQL-standard function body. Without this, we lose error cursor positions, as shown in the modified regression test result. Discussion: https://postgr.es/m/2197698.1617984...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg

pgsql: Undo decision to allow pg_proc.prosrc to be NULL.

2021-04-15 Thread Tom Lane
Undo decision to allow pg_proc.prosrc to be NULL. Commit e717a9a18 changed the longstanding rule that prosrc is NOT NULL because when a SQL-language function is written in SQL-standard style, we don't currently have anything useful to put there. This seems a poor decision though, as it could easi

pgsql: Revert "Cope with NULL query string in ExecInitParallelPlan()."

2021-04-15 Thread Tom Lane
Revert "Cope with NULL query string in ExecInitParallelPlan()." This reverts commit b3ee4c503872f3d0a5d6a7cbde48815f555af15b. We don't need it in the wake of the preceding commit, which added an upstream check that the querystring isn't null. Discussion: https://postgr.es/m/2197698.1617984...@sss

pgsql: Stabilize recently-added information_schema test queries.

2021-04-15 Thread Tom Lane
Stabilize recently-added information_schema test queries. These queries could show unexpected entries if the core system, or concurrently-running test scripts, created any functions that would appear in the information_schema views. Restrict them to showing functions belonging to this test's sche

pgsql: Revert "psql: Show all query results by default"

2021-04-15 Thread Peter Eisentraut
Revert "psql: Show all query results by default" This reverts commit 3a5130672296ed4e682403a77a9a3ad3d21cef75. Per discussion, this patch had too many issues to resolve at this point of the development cycle. We'll try again in the future. Discussion: https://www.postgresql.org/message-id/flat

pgsql: doc: Add missing COMPRESSION into CREATE TABLE synopsis.

2021-04-15 Thread Fujii Masao
doc: Add missing COMPRESSION into CREATE TABLE synopsis. Commit bbe0a81db6 introduced "INCLUDING COMPRESSION" option in CREATE TABLE command, but forgot to mention it in the CREATE TABLE syntax synopsis. Author: Fujii Masao Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/54d30e66-db

Re: pgsql: Use SIGURG rather than SIGUSR1 for latches.

2021-04-15 Thread Thomas Munro
On Thu, Apr 15, 2021 at 2:26 PM Tom Lane wrote: > It's possible that that argument doesn't apply to the way SIGURG is used > in this patch, but I don't see a good reason to ignore the convention of > setting up the handler this way. Yeah, will fix. I don't think there is a bug here given the way

pgsql: doc: Simplify example of HISTFILE for psql

2021-04-15 Thread Michael Paquier
doc: Simplify example of HISTFILE for psql e4c7619 has added a space to the example used for HISTFILE in the docs of psql before the variable DBNAME, as a workaround because variables were not parsed the same way back then. This behavior has changed in 9.2, causing the example in the psql docs to

pgsql: pg_upgrade: Small fix for better translatability of help output

2021-04-15 Thread Peter Eisentraut
pg_upgrade: Small fix for better translatability of help output Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbae8774eb5c2f5552323ee18ca5286f9c8e5d06 Modified Files -- src/bin/pg_upgrade/option.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-