pgsql: doc: Fix obsolete description about pg_basebackup.

2021-04-22 Thread Fujii Masao
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. N

pgsql: doc: Fix obsolete description about pg_basebackup.

2021-04-22 Thread Fujii Masao
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. N

pgsql: doc: Fix obsolete description about pg_basebackup.

2021-04-22 Thread Fujii Masao
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. N

pgsql: doc: Fix obsolete description about pg_basebackup.

2021-04-22 Thread Fujii Masao
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. N

pgsql: doc: Fix obsolete description about pg_basebackup.

2021-04-22 Thread Fujii Masao
doc: Fix obsolete description about pg_basebackup. Previously it was documented that if using "-X none" option there was no guarantee that all required WAL files were archived at the end of pg_basebackup when taking a backup from the standby. But this limitation was removed by commit 52f8a59dd9. N

pgsql: Fix incorrect format placeholder

2021-04-22 Thread Peter Eisentraut
Fix incorrect format placeholder Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7776a23a4bdeb7215e4f8ddea5989cb143becc12 Modified Files -- src/backend/utils/misc/guc-file.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix some comments in fmgr.c

2021-04-22 Thread Michael Paquier
Fix some comments in fmgr.c Oversight in 2a0faed. Author: Hou Zhijie Discussion: https://postgr.es/m/os0pr01mb5716405e2464d85e6db6dc0794...@os0pr01mb5716.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/45c0c5f70eb5e22d31be8bb9a8b4d9c66a3e

pgsql: Remove use of [U]INT64_FORMAT in some translatable strings

2021-04-22 Thread Michael Paquier
Remove use of [U]INT64_FORMAT in some translatable strings %lld with (long long), or %llu with (unsigned long long) are more adapted. This is similar to 3286065. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20210421.20.1462448394029407895.horikyota@gmail.com Branch --

pgsql: Minor code cleanup in asynchronous execution support.

2021-04-22 Thread Etsuro Fujita
Minor code cleanup in asynchronous execution support. This is cleanup for commit 27e1f1456: * ExecAppendAsyncEventWait(), which was modified a bit further by commit a8af856d3, duplicated the same nevents calculation. Simplify the code a little bit to avoid the duplication. Update comments t

pgsql: Don't crash on reference to an un-available system column.

2021-04-22 Thread Tom Lane
Don't crash on reference to an un-available system column. Adopt a more consistent policy about what slot-type-specific getsysattr functions should do when system attributes are not available. To wit, they should all throw the same user-oriented error, rather than variously crashing or emitting d

pgsql: Don't crash on reference to an un-available system column.

2021-04-22 Thread Tom Lane
Don't crash on reference to an un-available system column. Adopt a more consistent policy about what slot-type-specific getsysattr functions should do when system attributes are not available. To wit, they should all throw the same user-oriented error, rather than variously crashing or emitting d

pgsql: Don't crash on reference to an un-available system column.

2021-04-22 Thread Tom Lane
Don't crash on reference to an un-available system column. Adopt a more consistent policy about what slot-type-specific getsysattr functions should do when system attributes are not available. To wit, they should all throw the same user-oriented error, rather than variously crashing or emitting d

pgsql: Fix some trailing whitespace in documentation files

2021-04-22 Thread Peter Eisentraut
Fix some trailing whitespace in documentation files Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/197d33ccbe888fc84ae4e49bb241e88ea3c81f15 Modified Files -- doc/src/sgml/fdwhandler.sgml | 4 ++-- doc/src/sgml/installation.sgml| 2 +- doc

pgsql: Fix uninitialized memory bug

2021-04-22 Thread Alvaro Herrera
Fix uninitialized memory bug Have interested callers of find_inheritance_children set the detached_exist value to false prior to calling it, so that that routine only has to set it true in the rare cases where it is necessary. Don't touch it otherwise. Per buildfarm member thorntail (which repor

pgsql: doc: mention can be inside of , but not

2021-04-22 Thread Bruce Momjian
doc: mention can be inside of , but not This was discussed in commit 9081bddbd. Reported-by: Peter Eisentraut Discussion: https://postgr.es/m/flat/87o8pco34z@wibble.ilmari.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/84f15ccd4c25c4ffc4de6ed82f7658a3a

pgsql: Make PostgresVersion code a bit more robust and simple.

2021-04-22 Thread Andrew Dunstan
Make PostgresVersion code a bit more robust and simple. per gripe from Alvaro Herrera. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/502dc6df8f6eeba06812ce09488efc7e684f5ec9 Modified Files -- src/test/perl/PostgresVersion.pm | 19 --- 1

pgsql: Fix relcache inconsistency hazard in partition detach

2021-04-22 Thread Alvaro Herrera
Fix relcache inconsistency hazard in partition detach During queries coming from ri_triggers.c, we need to omit partitions that are marked pending detach -- otherwise, the RI query is tricked into allowing a row into the referencing table whose corresponding row is in the detached partition. Whic

pgsql: Doc: document the tie-breaking behavior of the round() function.

2021-04-22 Thread Tom Lane
Doc: document the tie-breaking behavior of the round() function. Back-patch to v13; the table layout in older branches is unfriendly to adding such details. Laurenz Albe Discussion: https://postgr.es/m/161881920775.685.12293798764864559...@wrigleys.postgresql.org Branch -- REL_13_STABLE D

pgsql: Doc: document the tie-breaking behavior of the round() function.

2021-04-22 Thread Tom Lane
Doc: document the tie-breaking behavior of the round() function. Back-patch to v13; the table layout in older branches is unfriendly to adding such details. Laurenz Albe Discussion: https://postgr.es/m/161881920775.685.12293798764864559...@wrigleys.postgresql.org Branch -- master Details

pgsql: Fix bugs in RETURNING in cross-partition UPDATE cases.

2021-04-22 Thread Tom Lane
Fix bugs in RETURNING in cross-partition UPDATE cases. If the source and destination partitions don't have identical rowtypes (for example, one has dropped columns the other lacks), then the planSlot contents will be different because of that. If the query has a RETURNING list that tries to return

pgsql: Fix bugs in RETURNING in cross-partition UPDATE cases.

2021-04-22 Thread Tom Lane
Fix bugs in RETURNING in cross-partition UPDATE cases. If the source and destination partitions don't have identical rowtypes (for example, one has dropped columns the other lacks), then the planSlot contents will be different because of that. If the query has a RETURNING list that tries to return

pgsql: Fix bugs in RETURNING in cross-partition UPDATE cases.

2021-04-22 Thread Tom Lane
Fix bugs in RETURNING in cross-partition UPDATE cases. If the source and destination partitions don't have identical rowtypes (for example, one has dropped columns the other lacks), then the planSlot contents will be different because of that. If the query has a RETURNING list that tries to return

pgsql: Make PostgresNode version aware

2021-04-22 Thread Andrew Dunstan
Make PostgresNode version aware A new PostgresVersion object type is created and this is used in PostgresNode using the output of `pg_config --version` and the result stored in the PostgresNode object. This object can be compared to other PostgresVersion objects, or to a number or string. Postgr