pgsql: Fix come comments in execMain.c

2021-04-23 Thread Michael Paquier
Fix come comments in execMain.c 1375422 has refactored this area of the executor code, and some comments went out-of-sync. Author: Yukun Wang Reviewed-by: Amul Sul Discussion: https://postgr.es/m/os0pr01mb60033394fcaef79b98f078f5b4...@os0pr01mb6003.jpnprd01.prod.outlook.com Branch -- master

pgsql: Doc: Remove extraneous whitespaces with some tags

2021-04-23 Thread Michael Paquier
Doc: Remove extraneous whitespaces with some tags Author: Justin Pryzby Discussion: https://postgr.es/m/20210423184338.gl7...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0d0049c58b4970183a102fc1f7dc1e9bef2a7149 Modified Files -- doc/sr

pgsql: Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c

2021-04-23 Thread Michael Paquier
Add some forgotten LSN_FORMAT_ARGS() in xlogreader.c 6f6f284 has introduced a specific macro to make printf()-ing of LSNs easier. This takes care of what looks like the remaining code paths that did not get the call. Author: Michael Paquier Reviewed-by: Kyotaro Horiguchi, Tom Lane Discussion: ht

pgsql: amcheck: MAXALIGN() nbtree special area offset.

2021-04-23 Thread Peter Geoghegan
amcheck: MAXALIGN() nbtree special area offset. This isn't strictly necessary, but in theory it might matter if in the future the width of the nbtree special area changes -- its total size might not be an even number of MAXALIGN() quantums, even with padding. PageInit() MAXALIGN()s all special ar

pgsql: Factor out system call names from error messages

2021-04-23 Thread Peter Eisentraut
Factor out system call names from error messages Instead, put them in via a format placeholder. This reduces the number of distinct translatable messages and also reduces the chances of typos during translation. We already did this for the system call arguments in a number of cases, so this is j

pgsql: Use correct format placeholder for WSAGetLastError()

2021-04-23 Thread Peter Eisentraut
Use correct format placeholder for WSAGetLastError() Some code thought this was unsigned, but it's signed int. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9486844f301e265a3ad11b612decaba2462c3c15 Modified Files -- src/backend/libpq/pqcomm.c|

pgsql: Mark multirange_constructor0() and multirange_constructor2() str

2021-04-23 Thread Alexander Korotkov
Mark multirange_constructor0() and multirange_constructor2() strict These functions shouldn't receive null arguments: multirange_constructor0() doesn't have any arguments while multirange_constructor2() has a single array argument, which is never null. But mark them strict anyway for the sake of

pgsql: Reorder COMPRESSION option in gram.y and parsenodes.h into alpha

2021-04-23 Thread Fujii Masao
Reorder COMPRESSION option in gram.y and parsenodes.h into alphabetical order. Commit bbe0a81db6 introduced "INCLUDING COMPRESSION" option in CREATE TABLE command, but previously TableLikeOption in gram.y and parsenodes.h didn't classify this new option in alphabetical order with the rest. Author

pgsql: Mention that toplevel is part of pg_stat_statements key.

2021-04-23 Thread Magnus Hagander
Mention that toplevel is part of pg_stat_statements key. While at it, also document that toplevel is always true if pg_stat_statements.track is set to top. Author: Julien Rouhaud Reported-By: Fujii Masao Discussion: https://postgr.es/m/a878d5ea-64a7-485e-5d2f-177618ebc...@oss.nttdata.com Branch

pgsql: pg_amcheck: Use logging functions

2021-04-23 Thread Peter Eisentraut
pg_amcheck: Use logging functions This was already mostly done, but some error messages were printed the long way. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/add5fad78aac8da96aeeb730155d35b16ff9b55a Modified Files -- src/bin/pg_amcheck/pg_amcheck.c

pgsql: doc: Fix typos

2021-04-23 Thread Peter Eisentraut
doc: Fix typos Author: Justin Pryzby Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9bd563aa9f0694994a6640946a7ee3dc0431d507 Modified Files -- doc/src/sgml/func.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)