pgsql: GUC description improvements for clarity

2021-05-04 Thread Peter Eisentraut
GUC description improvements for clarity Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/38f36aad8c55c8f91e3fb8720fae1847c8fa0552 Modified Files -- src/backend/utils/misc/guc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

pgsql: Disable cache clobber to avoid breaking postgres_fdw termination

2021-05-04 Thread Tom Lane
Disable cache clobber to avoid breaking postgres_fdw termination test. Commit 93f414614 improved a pre-existing test case so that it would show whether or not termination of the "remote" worker process happened. This soon exposed that, when debug_invalidate_system_caches_always (nee CLOBBER_CACHE_

pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT The OID of the constraint is used instead of the OID of the trigger -- an easy mistake to make. Apparently the object-alter hooks are not very well tested :-( Backpatch to 12, where this typo was introduced by 578b229718e8 Discussion:

pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT The OID of the constraint is used instead of the OID of the trigger -- an easy mistake to make. Apparently the object-alter hooks are not very well tested :-( Backpatch to 12, where this typo was introduced by 578b229718e8 Discussion:

pgsql: Fix OID passed to object-alter hook during ALTER CONSTRAINT

2021-05-04 Thread Alvaro Herrera
Fix OID passed to object-alter hook during ALTER CONSTRAINT The OID of the constraint is used instead of the OID of the trigger -- an easy mistake to make. Apparently the object-alter hooks are not very well tested :-( Backpatch to 12, where this typo was introduced by 578b229718e8 Discussion:

pgsql: doc: Fix typos

2021-05-04 Thread Peter Eisentraut
doc: Fix typos Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c98a6d7887ea6588b4e9797903182312a2b46f67 Modified Files -- doc/src/sgml/ecpg.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions The previous fix for dumping of inherited generated columns (0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to partitions, since, unlike normal inherited tables, they are always dumped separately and reattached. Reported-by: Sant

pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions The previous fix for dumping of inherited generated columns (0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to partitions, since, unlike normal inherited tables, they are always dumped separately and reattached. Reported-by: Sant

pgsql: pg_dump: Fix dump of generated columns in partitions

2021-05-04 Thread Peter Eisentraut
pg_dump: Fix dump of generated columns in partitions The previous fix for dumping of inherited generated columns (0bf83648a52df96f7c8677edbbdf141bfa0cf32b) must not be applied to partitions, since, unlike normal inherited tables, they are always dumped separately and reattached. Reported-by: Sant

pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns When running ALTER TABLE t2 INHERIT t1, we must check that columns in t2 that correspond to a generated column in t1 are also generated and have the same generation expression. Otherwise, this would allow creating setups that a normal CREATE TABLE

pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns When running ALTER TABLE t2 INHERIT t1, we must check that columns in t2 that correspond to a generated column in t1 are also generated and have the same generation expression. Otherwise, this would allow creating setups that a normal CREATE TABLE

pgsql: Fix ALTER TABLE / INHERIT with generated columns

2021-05-04 Thread Peter Eisentraut
Fix ALTER TABLE / INHERIT with generated columns When running ALTER TABLE t2 INHERIT t1, we must check that columns in t2 that correspond to a generated column in t1 are also generated and have the same generation expression. Otherwise, this would allow creating setups that a normal CREATE TABLE

pgsql: Remove mention of the version number from pg_trgm docs

2021-05-04 Thread Alexander Korotkov
Remove mention of the version number from pg_trgm docs We don't usually mention the version number in similar situations. So, neither mention it here. Reported-by: Bruce Momjian Discussion: https://postgr.es/m/20210503234914.GO6180%40momjian.us Branch -- master Details --- https://git.