pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Doc: Fix misleading statement about VACUUM memory limits

2021-08-08 Thread David Rowley
Doc: Fix misleading statement about VACUUM memory limits In ec34040af I added a mention that there was no point in setting maintenance_work_limit to anything higher than 1GB for vacuum, but that was incorrect as ginInsertCleanup() also looks at what maintenance_work_mem is set to during VACUUM and

pgsql: Use ExplainPropertyInteger for queryid in EXPLAIN

2021-08-08 Thread David Rowley
Use ExplainPropertyInteger for queryid in EXPLAIN This saves a few lines of code. Also add a comment to mention why we use ExplainPropertyInteger instead of ExplainPropertyUInteger given that queryid is a uint64 type. Author: David Rowley Reviewed-by: Julien Rouhaud Discussion: https://postgr.e

pgsql: Use ExplainPropertyInteger for queryid in EXPLAIN

2021-08-08 Thread David Rowley
Use ExplainPropertyInteger for queryid in EXPLAIN This saves a few lines of code. Also add a comment to mention why we use ExplainPropertyInteger instead of ExplainPropertyUInteger given that queryid is a uint64 type. Author: David Rowley Reviewed-by: Julien Rouhaud Discussion: https://postgr.e

pgsql: Fix typo in 022_twophase_cascade.pl.

2021-08-08 Thread Amit Kapila
Fix typo in 022_twophase_cascade.pl. Author: Peter Smith Discussion: https://postgr.es/m/CAHut+Pta=zo8G1DWVVg-LU6b_JvHHCueC=akvpkjorwlzj9...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c9229d3d2b05b90fba32bd4afb5eb251b53b73be Modified Files

pgsql: Add POPCNT support for MSVC x86_64 builds

2021-08-08 Thread David Rowley
Add POPCNT support for MSVC x86_64 builds 02a6a54ec added code to make use of the POPCNT instruction when available for many of our common platforms. Here we do the same for MSVC for x86_64 machines. MSVC's intrinsic functions for popcnt seem to differ from GCCs in that they always appear to emi

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c3c1fe09e7c

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9268fc34526

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/be500101705

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ff18b8d1b16

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8a75b1308b133502a

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cfb70a120bb

pgsql: doc: mention pg_upgrade extension script

2021-08-08 Thread Bruce Momjian
doc: mention pg_upgrade extension script Since commit e462856a7a, pg_upgrade automatically creates a script to update extensions, so mention that instead of ALTER EXTENSION. Backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/49c54447a5b

pgsql: Remove some unnecessary casts in format arguments

2021-08-08 Thread Peter Eisentraut
Remove some unnecessary casts in format arguments We can use %zd or %zu directly, no need to cast to int. Conversely, some code was casting away from int when it could be using %d directly. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ae03a7c7391dfc59f14226b7cfd

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL_10_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL_14_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL9_6_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL_13_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL_12_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- REL_11_STABLE Details --- ht

pgsql: Doc: remove bogus items.

2021-08-08 Thread Tom Lane
Doc: remove bogus items. Copy-and-pasteo in 665c5855e, evidently. The 9.6 docs toolchain whined about duplicate index entries, though our modern toolchain doesn't. In any case, these GUCs surely are not about the default settings of these values. Branch -- master Details --- https://g

pgsql: Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23.

2021-08-08 Thread Tom Lane
Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29952920e6e7c68d289cd77f78972d42cef3abaf Modified Files -- doc/src/sgml/release-10.sgml | 1253 ++ 1 file ch

pgsql: Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23.

2021-08-08 Thread Tom Lane
Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d5904d65080d3fd2c35b6aa74fa6c5762e32f87b Modified Files -- doc/src/sgml/release-9.6.sgml | 1167 + 1 file ch

pgsql: Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23.

2021-08-08 Thread Tom Lane
Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6432cf92658307688be4e241eb16fc9c41a8c0cf Modified Files -- doc/src/sgml/release-13.sgml | 53 ++-- 1 file ch

pgsql: Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23.

2021-08-08 Thread Tom Lane
Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a6becac964d277eb1b968a351fa7b3e25e8fc3f8 Modified Files -- doc/src/sgml/release-11.sgml | 1506 ++ 1 file ch

pgsql: Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23.

2021-08-08 Thread Tom Lane
Release notes for 13.4, 12.8, 11.13, 10.18, 9.6.23. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5b325b967d150d2be579d4541963b2e9c361f59 Modified Files -- doc/src/sgml/release-12.sgml | 1598 ++ 1 file ch

pgsql: Change NestPath node to contain JoinPath node

2021-08-08 Thread Peter Eisentraut
Change NestPath node to contain JoinPath node This makes the structure of all JoinPath-derived nodes the same, independent of whether they have additional fields. Discussion: https://www.postgresql.org/message-id/flat/c1097590-a6a4-486a-64b1-e1f9cc053...@enterprisedb.com Branch -- master D

pgsql: Check the size in COPY_POINTER_FIELD

2021-08-08 Thread Peter Eisentraut
Check the size in COPY_POINTER_FIELD instead of making each caller do it. Discussion: https://www.postgresql.org/message-id/flat/c1097590-a6a4-486a-64b1-e1f9cc053...@enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1132aae336c41cf9d316222e525d8d59

pgsql: Change SeqScan node to contain Scan node

2021-08-08 Thread Peter Eisentraut
Change SeqScan node to contain Scan node This makes the structure of all Scan-derived nodes the same, independent of whether they have additional fields. Discussion: https://www.postgresql.org/message-id/flat/c1097590-a6a4-486a-64b1-e1f9cc053...@enterprisedb.com Branch -- master Details --

pgsql: Rethink regexp engine's backref-related compilation state.

2021-08-08 Thread Tom Lane
Rethink regexp engine's backref-related compilation state. I had committer's remorse almost immediately after pushing cb76fbd7e, upon finding that removing capturing subexpressions' subREs from the data structure broke my proposed patch for REG_NOSUB optimization. Revert that data structure change

pgsql: Rethink regexp engine's backref-related compilation state.

2021-08-08 Thread Tom Lane
Rethink regexp engine's backref-related compilation state. I had committer's remorse almost immediately after pushing cb76fbd7e, upon finding that removing capturing subexpressions' subREs from the data structure broke my proposed patch for REG_NOSUB optimization. Revert that data structure change

pgsql: Remove unused function declaration

2021-08-08 Thread David Rowley
Remove unused function declaration It appears that check_track_commit_timestamp was declared but has never been defined in our code base. Likely this is just leftover cruft from a development version of the original patch to add commit timestamps. Let's just remove the useless declaration. The