pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Fix variable shadowing in procarray.c.

2021-09-15 Thread Fujii Masao
Fix variable shadowing in procarray.c. ProcArrayGroupClearXid function has a parameter named "proc", but the same name was used for its local variables. This commit fixes this variable shadowing, to improve code readability. Back-patch to all supported versions, to make future back-patching easy

pgsql: Use int instead of size_t in procarray.c.

2021-09-15 Thread Fujii Masao
Use int instead of size_t in procarray.c. All size_t variables declared in procarray.c are actually int ones. Let's use int instead of size_t for those variables. Which would reduce Wsign-compare compiler warnings. Back-patch to v14 where commit 941697c3c1 added size_t variables in procarray.c, t

pgsql: Use int instead of size_t in procarray.c.

2021-09-15 Thread Fujii Masao
Use int instead of size_t in procarray.c. All size_t variables declared in procarray.c are actually int ones. Let's use int instead of size_t for those variables. Which would reduce Wsign-compare compiler warnings. Back-patch to v14 where commit 941697c3c1 added size_t variables in procarray.c, t

pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-15 Thread Michael Paquier
Support "postgres -C" with runtime-computed GUCs Until now, the -C option of postgres was handled before a small subset of GUCs computed at runtime are initialized, leading to incorrect results as GUC machinery would fall back to default values for such parameters. For example, data_checksums cou

pgsql: process startup: Initialize PgStartTime earlier in single user m

2021-09-15 Thread Andres Freund
process startup: Initialize PgStartTime earlier in single user mode. An upcoming patch splits single user mode handling out of PostgresMain(). The startup time only needs to be determined in single user mode. Currently the initialization happens late, which makes the split a bit harder. As postmas

pgsql: Remove arbitrary 64K-or-so limit on rangetable size.

2021-09-15 Thread Tom Lane
Remove arbitrary 64K-or-so limit on rangetable size. Up to now the size of a query's rangetable has been limited by the constants INNER_VAR et al, which mustn't be equal to any real rangetable index. 65000 doubtless seemed like enough for anybody, and it still is orders of magnitude larger than t

pgsql: Add Cardinality typedef

2021-09-15 Thread Peter Eisentraut
Add Cardinality typedef Similar to Cost and Selectivity, this is just a double, which can be used in path and plan nodes to give some hint about the meaning of a field. Discussion: https://www.postgresql.org/message-id/c091e5cd-45f8-69ee-6a9b-de86912cc...@enterprisedb.com Branch -- master

pgsql: Disallow LISTEN in background workers.

2021-09-15 Thread Tom Lane
Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever c

pgsql: Disallow LISTEN in background workers.

2021-09-15 Thread Tom Lane
Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever c

pgsql: Disallow LISTEN in background workers.

2021-09-15 Thread Tom Lane
Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever c

Re: pgsql: Make node output prefix match node structure name

2021-09-15 Thread Tom Lane
Peter Eisentraut writes: > Make node output prefix match node structure name Just for the record, this should have included a catversion bump, since it surely broke stored rules. regards, tom lane

pgsql: Make node output prefix match node structure name

2021-09-15 Thread Peter Eisentraut
Make node output prefix match node structure name In most cases, the prefix string in a node output is the upper case of the node structure name, e.g., MergeAppend -> MERGEAPPEND. There were a few exceptions that for either no apparent reason or perhaps minor aesthetic reasons deviated from this.

pgsql: Fix hash_array

2021-09-15 Thread Peter Eisentraut
Fix hash_array Commit 054adca641ac1279dc8d9b74fda41948ac35e9a9 neglected to initialize the type_id field of the synthesized type cache entry, so it would make a new one on every call. Also, better use the per-function memory context for this; otherwise it leaks memory. Discussion: https://www.p

pgsql: Fix hash_array

2021-09-15 Thread Peter Eisentraut
Fix hash_array Commit a3d2b1bbe904b0ca8d9fdde20f25295ff3e21f79 neglected to initialize the type_id field of the synthesized type cache entry, so it would make a new one on every call. Also, better use the per-function memory context for this; otherwise it leaks memory. Discussion: https://www.p

pgsql: doc: Clarify refresh options for DROP PUBLICATION

2021-09-15 Thread Daniel Gustafsson
doc: Clarify refresh options for DROP PUBLICATION The available refresh options are specified as refresh_options under REFRESH PUBLICATION, and DROP PUBLICATION itself has an option named refresh. Clarify what we mean by refresh options to avoid confusion. Backpatch through v14 where ALTER SUBSCR

pgsql: doc: Clarify refresh options for DROP PUBLICATION

2021-09-15 Thread Daniel Gustafsson
doc: Clarify refresh options for DROP PUBLICATION The available refresh options are specified as refresh_options under REFRESH PUBLICATION, and DROP PUBLICATION itself has an option named refresh. Clarify what we mean by refresh options to avoid confusion. Backpatch through v14 where ALTER SUBSCR

pgsql: Fix incorrect format placeholders

2021-09-15 Thread Peter Eisentraut
Fix incorrect format placeholders Also remove obsolete comments about why the 64-bit integers need to be printed in a separate buffer. The reason used to be portability, but now the remaining reason is that we need the string lengths for the progress displays. That is evident by looking at the c