Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Michael Paquier
On Mon, Sep 20, 2021 at 10:33:05PM -0700, Andres Freund wrote: > And while not finished entirely, the checksum tests passed: > > [05:28:13.788] t/001_basic.pl ok > [05:28:35.762] t/002_actions.pl .. ok > [05:28:35.767] All tests successful. > [05:28:35.767] Files=2, Tests=74, 22 wallclock sec

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Andres Freund
Hi, On 2021-09-21 14:37:05 +0900, Michael Paquier wrote: > > If interesting I can also come up with the necessary steps to activate > > it in your repo... > > That could be helpful. I have never played with those tools. It's really useful. I'm planning to propose a bit more minimal version to b

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Michael Paquier
On Mon, Sep 20, 2021 at 10:11:53PM -0700, Andres Freund wrote: > On 2021-09-21 13:42:34 +0900, Michael Paquier wrote: > > The first test works here on Win32, but I don't have a CI environment > > with an unprivileged account. > > I assume it's just a typo, but the problem is the opposite, it's a >

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Andres Freund
Hi, On 2021-09-20 22:11:53 -0700, Andres Freund wrote: > On 2021-09-21 13:42:34 +0900, Michael Paquier wrote: > > Could you check if the first case would work in your environment? If > > not, I would not mind just removing the test. I have discovered a > > separate bug thanks to it, but that's n

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Andres Freund
Hi, On 2021-09-21 13:42:34 +0900, Michael Paquier wrote: > On Tue, Sep 21, 2021 at 12:47:24PM +0900, Michael Paquier wrote: > > This would print the parameter, while getting to stderr mostly a > > "could not start server". Would that work for you? > > And.. Here is an actual patch. Cool! > T

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Michael Paquier
On Tue, Sep 21, 2021 at 12:47:24PM +0900, Michael Paquier wrote: > This would print the parameter, while getting to stderr mostly a > "could not start server". Would that work for you? And.. Here is an actual patch. The first test works here on Win32, but I don't have a CI environment with an u

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Andres Freund
Hi, On September 20, 2021 8:47:24 PM PDT, Michael Paquier wrote: >On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote: >> So the problem is that -C data_checksums requires permissions to be dropped, >> but the way it's invoked here that's not guaranteed... And I don't think we >> shou

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Michael Paquier
On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote: > So the problem is that -C data_checksums requires permissions to be dropped, > but the way it's invoked here that's not guaranteed... And I don't think we > should remove that requirement, given that we're actually doing stuff to the

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Andres Freund
Hi, On 2021-09-16 02:05:02 +, Michael Paquier wrote: > Some TAP tests are added to provide some coverage here, using > data_checksums in the tests of pg_checksums. I just rebased my AIO branch ontop of this, and promptly got a CI failure. Which appears to be unrelated to AIO. The CI system th

pgsql: Introduce GUC shared_memory_size_in_huge_pages

2021-09-20 Thread Michael Paquier
Introduce GUC shared_memory_size_in_huge_pages This runtime-computed GUC shows the number of huge pages required for the server's main shared memory area, taking advantage of the work done in 0c39c29 and 0bd305e. This is useful for users to estimate the amount of huge pages required for a server

Re: pgsql: Support "postgres -C" with runtime-computed GUCs

2021-09-20 Thread Michael Paquier
On Sat, Sep 18, 2021 at 08:18:58AM +0900, Michael Paquier wrote: > And perltidy tells me nothing here. Please note that I am planning to get the fixes in TestLib.pm applied and back-patched to prevent surprises if there is any bug fix that introduces a test where this could be hit. As 14 RC1 has

pgsql: Stamp 14rc1.

2021-09-20 Thread Tom Lane
Stamp 14rc1. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8aed7f7a2ec46ad60c84c3c97300210850c3fbc8 Modified Files -- configure| 18 +- configure.ac | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-)

pgsql: Remove overzealous index deletion assertion.

2021-09-20 Thread Peter Geoghegan
Remove overzealous index deletion assertion. A broken HOT chain is not an unexpected condition, even when the offset number points past the end of the page's line pointer array. heap_prune_chain() does not (and never has) treated this condition as unexpected, so derivative code in heap_index_delet

pgsql: Remove overzealous index deletion assertion.

2021-09-20 Thread Peter Geoghegan
Remove overzealous index deletion assertion. A broken HOT chain is not an unexpected condition, even when the offset number points past the end of the page's line pointer array. heap_prune_chain() does not (and never has) treated this condition as unexpected, so derivative code in heap_index_delet

pgsql: Remove overzealous index deletion assertion.

2021-09-20 Thread Peter Geoghegan
Remove overzealous index deletion assertion. A broken HOT chain is not an unexpected condition, even when the offset number points past the end of the page's line pointer array. heap_prune_chain() does not (and never has) treated this condition as unexpected, so derivative code in heap_index_delet

pgsql: Remove overzealous index deletion assertion.

2021-09-20 Thread Peter Geoghegan
Remove overzealous index deletion assertion. A broken HOT chain is not an unexpected condition, even when the offset number points past the end of the page's line pointer array. heap_prune_chain() does not (and never has) treated this condition as unexpected, so derivative code in heap_index_delet

pgsql: pgstat: Prepare to use mechanism for truncated rels also for dro

2021-09-20 Thread Andres Freund
pgstat: Prepare to use mechanism for truncated rels also for droppped rels. The upcoming shared memory stats patch drops stats for dropped objects in a transactional manner, rather than removing them later as part of vacuum. This means that stats for DROP inside a transaction needs to handle abort

pgsql: pgstat: Split out relation stats handling from AtEO[Sub]Xact_PgS

2021-09-20 Thread Andres Freund
pgstat: Split out relation stats handling from AtEO[Sub]Xact_PgStat() etc. An upcoming patch will add additional work to these functions. To avoid the functions getting too complicated / doing too many things at once, split out sub-tasks into their own functions. Author: Andres Freund Discussion

pgsql: Don't elide casting to typmod -1.

2021-09-20 Thread Tom Lane
Don't elide casting to typmod -1. Casting a value that's already of a type with a specific typmod to an unspecified typmod doesn't do anything so far as run-time behavior is concerned. However, it really ought to change the exposed type of the expression to match. Up to now, coerce_type_typmod h

pgsql: Don't elide casting to typmod -1.

2021-09-20 Thread Tom Lane
Don't elide casting to typmod -1. Casting a value that's already of a type with a specific typmod to an unspecified typmod doesn't do anything so far as run-time behavior is concerned. However, it really ought to change the exposed type of the expression to match. Up to now, coerce_type_typmod h

pgsql: Don't elide casting to typmod -1.

2021-09-20 Thread Tom Lane
Don't elide casting to typmod -1. Casting a value that's already of a type with a specific typmod to an unspecified typmod doesn't do anything so far as run-time behavior is concerned. However, it really ought to change the exposed type of the expression to match. Up to now, coerce_type_typmod h

pgsql: Don't elide casting to typmod -1.

2021-09-20 Thread Tom Lane
Don't elide casting to typmod -1. Casting a value that's already of a type with a specific typmod to an unspecified typmod doesn't do anything so far as run-time behavior is concerned. However, it really ought to change the exposed type of the expression to match. Up to now, coerce_type_typmod h

pgsql: Don't elide casting to typmod -1.

2021-09-20 Thread Tom Lane
Don't elide casting to typmod -1. Casting a value that's already of a type with a specific typmod to an unspecified typmod doesn't do anything so far as run-time behavior is concerned. However, it really ought to change the exposed type of the expression to match. Up to now, coerce_type_typmod h

pgsql: Doc: add glossary term for "auxiliary process"

2021-09-20 Thread Alvaro Herrera
Doc: add glossary term for "auxiliary process" Add entries for existing processes not documented, too, and adjust existing definitions for consistency. Per question from Bharath Rupireddy. Author: Justin Pryzby Author: Alvaro Herrera Discussion: https://postgr.es/m/CALj2ACVpYCT0M+k8zqrAa4ZQZV

pgsql: Doc: minor improvements for "Formatting" section.

2021-09-20 Thread Tom Lane
Doc: minor improvements for "Formatting" section. Add more-specific links into the source tree. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5577cd571ad3528471152f68636ac03c80576977 Modified Files -- doc/src/sgml/sources.sgml | 8 +++- 1 file chan

pgsql: Translation updates

2021-09-20 Thread Peter Eisentraut
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 10b675b81a3a04bac460cb049e0b7b6e17fb4795 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3e8525aab86e78593844c9b395be40938582ebaf Modified Files

Re: pgsql: Add list of acknowledgments to release notes

2021-09-20 Thread Peter Eisentraut
On 19.09.21 18:51, Tom Lane wrote: Peter Eisentraut writes: Add list of acknowledgments to release notes This contains all individuals mentioned in the commit messages during PostgreSQL 14 development. These entries: Michał Albrycht Önder Kalacı are causing some doc toolchain iss

pgsql: doc: Replace characters that the PDF build cannot handle

2021-09-20 Thread Peter Eisentraut
doc: Replace characters that the PDF build cannot handle A few characters in the acknowledgments list cannot be handled by the PDF build, so replace with a similar ASCII character. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89a967e9b5262db1cea62a5725dd7b

pgsql: Update list of acknowledgments in release notes

2021-09-20 Thread Peter Eisentraut
Update list of acknowledgments in release notes current through 66061077155d68463ec00604ba7d6f0ae69716e8 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3609b453cd655060562f8750ce0ce4bdddf43a57 Modified Files -- doc/src/sgml/release-14.sgml | 12