pgsql: Doc: Move pg_stat_replication_slots view to "Collected Statistic

2021-09-30 Thread Amit Kapila
Doc: Move pg_stat_replication_slots view to "Collected Statistics Views" section. Commit 9868167500 added pg_stat_replication_slots view to monitor ReorderBuffer stats but mistakenly added it under "Dynamic Statistics Views" section in the docs whereas it belongs to "Collected Statistics Views" s

pgsql: Doc: Move pg_stat_replication_slots view to "Collected Statistic

2021-09-30 Thread Amit Kapila
Doc: Move pg_stat_replication_slots view to "Collected Statistics Views" section. Commit 9868167500 added pg_stat_replication_slots view to monitor ReorderBuffer stats but mistakenly added it under "Dynamic Statistics Views" section in the docs whereas it belongs to "Collected Statistics Views" s

pgsql: Ensure interleaved_parts field is always initialized

2021-09-30 Thread David Rowley
Ensure interleaved_parts field is always initialized This field was recently added in db632fbca, however that commit missed one place where it should have initialized the new field to NULL. The missed location is where the PartitionBoundInfo is created for partition-wise join relations. Technica

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Remove gratuitous environment dependency in 002_types.pl test.

2021-09-30 Thread Tom Lane
Remove gratuitous environment dependency in 002_types.pl test. Computing related timestamps by subtracting "N days" is sensitive to the prevailing timezone, since we interpret that as "same local time on the N'th prior day". Even though the intervals in question are only two to four days, through

pgsql: Treat ETIMEDOUT as indicating a non-recoverable connection failu

2021-09-30 Thread Tom Lane
Treat ETIMEDOUT as indicating a non-recoverable connection failure. Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS' list of "errnos that identify hard failure of a previously-established network connection". While one could imagine that this is sometimes recoverable, the same could be said of othe

Re: pgsql: Fix WAL replay in presence of an incomplete record

2021-09-30 Thread Alvaro Herrera
On 2021-Sep-30, Michael Paquier wrote: > Hi Alvaro, > > On Wed, Sep 29, 2021 at 02:40:29PM +, Alvaro Herrera wrote: > > Fix WAL replay in presence of an incomplete record > > [...] > > src/test/recovery/t/026_overwrite_contrecord.pl | 207 > > > > src/test/recovery/t/

pgsql: Repair two portability oversights of new test

2021-09-30 Thread Alvaro Herrera
Repair two portability oversights of new test First, as pointed out by Tom Lane and Michael Paquier, I failed to realize that Windows' PostgresNode needs an extra pg_hba.conf line (added by PostgresNode->set_replication_conf, called internally by ->init() when 'allows_streaming=>1' is given -- but

pgsql: Repair two portability oversights of new test

2021-09-30 Thread Alvaro Herrera
Repair two portability oversights of new test First, as pointed out by Tom Lane and Michael Paquier, I failed to realize that Windows' PostgresNode needs an extra pg_hba.conf line (added by PostgresNode->set_replication_conf, called internally by ->init() when 'allows_streaming=>1' is given -- but