pgsql: Fix incorrect format placeholders

2021-11-09 Thread Peter Eisentraut
Fix incorrect format placeholders Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/733e0391536dad99a2677ca5e19291854da5730f Modified Files -- contrib/amcheck/verify_heapam.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: Improve error messages for some callers of XLogReadRecord()

2021-11-09 Thread Michael Paquier
Improve error messages for some callers of XLogReadRecord() A couple of code paths related to logical decoding (WAL sender, slot advancing, etc.) use XLogReadRecord(), feeding on error messages generated by walreader.c on a failure. All those messages have no context, making it harder to spot fro

pgsql: Add pg_checkpointer predefined role for CHECKPOINT command.

2021-11-09 Thread Jeff Davis
Add pg_checkpointer predefined role for CHECKPOINT command. Any user with the privileges of pg_checkpointer can issue a CHECKPOINT command. Reviewed-by: Stephen Frost Discussion: https://postgr.es/m/67a1d667e8ec228b5e07f232184c80348c5d93f4.camel%40j-davis.com Branch -- master Details -

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

pgsql: Fix instability in 026_overwrite_contrecord.pl test.

2021-11-09 Thread Tom Lane
Fix instability in 026_overwrite_contrecord.pl test. We've seen intermittent failures in this test on slower buildfarm machines, which I think can be explained by assuming that autovacuum emitted some additional WAL. Disable autovacuum to stabilize it. In passing, use stringwise not numeric comp

Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Michael Paquier
On Tue, Nov 09, 2021 at 09:40:47AM -0500, Tom Lane wrote: > OK by me, but probably should raise the issue in -hackers not just > -committers. Also, please back-patch once the release freeze lifts. Sure. -- Michael signature.asc Description: PGP signature

pgsql: Have the server properly terminate tar archives.

2021-11-09 Thread Robert Haas
Have the server properly terminate tar archives. Earlier versions of PostgreSQL featured a version of pg_basebackup that wanted to edit tar archives but was too dumb to parse them properly. The server made things easier for the client by failing to add the two blocks of zero bytes that ought to en

pgsql: Remove check for accept() argument types

2021-11-09 Thread Peter Eisentraut
Remove check for accept() argument types This check was used to accommodate a staggering variety in particular in the type of the third argument of accept(). This is no longer of concern on currently supported systems. We can just use socklen_t in the code and put in a simple check that substitu

Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Tom Lane
Michael Paquier writes: > Yeah, you have a point here. -Wcompound-token-split-by-macro is new > as of clang-12 from last April, so I am a bit surprised that it is > that present in the buildfarm TBH. > The attached is sufficient to remove those warnings. Debian provides > clang-12, so it is eas

Re: pgsql: Fix incorrect format placeholder.

2021-11-09 Thread Michael Paquier
On Tue, Nov 09, 2021 at 01:06:26AM -0500, Tom Lane wrote: > I figured the Perl guys would do something about it, but it will be a > very long time before that propagates everywhere. Maybe we should > teach configure to add -Wno-compound-token-split-by-macro? By my > count there are now five build