pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Adjust pg_dump's priority ordering for casts.

2021-11-22 Thread Tom Lane
Adjust pg_dump's priority ordering for casts. When a stored expression depends on a user-defined cast, the backend records the dependency as being on the cast's implementation function --- or indeed, if there's no cast function involved but just RelabelType or CoerceViaIO, no dependency is recorde

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/72842a5756857a1ce6e2b2bd7a162cdf1a279fa9 Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/72582531b8031bb1aada7a4dd6914c880677ea38 Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/db3a660c6327a6df81a55c4aa86e6c0837ecd505 Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b542e4596e339b8a6ca94723f35ccc1667dbc306 Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/22d2b6611caa4d191131b5d933369181b5e4a03f Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Pacify perlcritic.

2021-11-22 Thread Tom Lane
Pacify perlcritic. Per buildfarm. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b599b8f399bebc03f8d468133e877793cf3e9cab Modified Files -- config/check_modules.pl | 3 +++ 1 file changed, 3 insertions(+)

pgsql: Fix pg_dump --inserts mode for generated columns with dropped co

2021-11-22 Thread Tom Lane
Fix pg_dump --inserts mode for generated columns with dropped columns. If a table contains a generated column that's preceded by a dropped column, dumpTableData_insert failed to account for the dropped column, and would emit DEFAULT placeholder(s) in the wrong column(s). This resulted in failures

pgsql: Fix pg_dump --inserts mode for generated columns with dropped co

2021-11-22 Thread Tom Lane
Fix pg_dump --inserts mode for generated columns with dropped columns. If a table contains a generated column that's preceded by a dropped column, dumpTableData_insert failed to account for the dropped column, and would emit DEFAULT placeholder(s) in the wrong column(s). This resulted in failures

pgsql: Fix pg_dump --inserts mode for generated columns with dropped co

2021-11-22 Thread Tom Lane
Fix pg_dump --inserts mode for generated columns with dropped columns. If a table contains a generated column that's preceded by a dropped column, dumpTableData_insert failed to account for the dropped column, and would emit DEFAULT placeholder(s) in the wrong column(s). This resulted in failures

pgsql: Fix pg_dump --inserts mode for generated columns with dropped co

2021-11-22 Thread Tom Lane
Fix pg_dump --inserts mode for generated columns with dropped columns. If a table contains a generated column that's preceded by a dropped column, dumpTableData_insert failed to account for the dropped column, and would emit DEFAULT placeholder(s) in the wrong column(s). This resulted in failures

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP

2021-11-22 Thread Tom Lane
Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing

pgsql: Be more specific about OOM in XLogReaderAllocate

2021-11-22 Thread Alvaro Herrera
Be more specific about OOM in XLogReaderAllocate A couple of spots can benefit from an added errdetail(), which matches what we were already doing in other places; and those that cannot withstand errdetail() can get a more descriptive primary message. Author: Bharath Rupireddy Reviewed-by: Danie

Re: pgsql: Require version 0.98 of Test::More for TAP tests

2021-11-22 Thread Tom Lane
... btw, should we drop the now-unused config/ax_prog_perl_modules.m4 ? I'm inclined to do so, on the grounds that we're not likely ever to need it. I doubt we'd agree to require a non-core Perl module as part of either our build tooling or PL/Perl's dependencies. Not to mention that it'd go awa

pgsql: autovacuum: Improve wording in a couple places

2021-11-22 Thread Alvaro Herrera
autovacuum: Improve wording in a couple places A few strings (one WARNING and some memory context names) in the autovacuum code were written in a world where "worker" had no other possible meaning than "autovacuum worker", but that's long time gone. Be more specific about it. Also, change the WAR

pgsql: Add missing words in comment

2021-11-22 Thread Alvaro Herrera
Add missing words in comment Reported by Zhihong Yu. Discussion: https://postgr.es/m/calnj-vr6uzivg_xkb1zkjexeyzdegoyanfxb-++1kbt9yzq...@mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c985a43df379e044e0de43c41daa1ba0847de459 Modified Files

pgsql: Add missing words in comment

2021-11-22 Thread Alvaro Herrera
Add missing words in comment Reported by Zhihong Yu. Discussion: https://postgr.es/m/calnj-vr6uzivg_xkb1zkjexeyzdegoyanfxb-++1kbt9yzq...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/67385544ce672a9a53cfd51b39c1ff9048d65585 Modified Files ---

Re: pgsql: Require version 0.98 of Test::More for TAP tests

2021-11-22 Thread Tom Lane
Andrew Dunstan writes: > On 11/21/21 12:46, Tom Lane wrote: >> ... I tried printing the version reports to >> STDOUT instead of using diag(), but that seems to get redirected to >> /dev/null somewhere. Anybody know how to get prove to not do that? > No, but I think you can get what you want with

Re: pgsql: Require version 0.98 of Test::More for TAP tests

2021-11-22 Thread Andrew Dunstan
On 11/21/21 12:46, Tom Lane wrote: > > However, the only way I could get that to happen was to redirect > prove's stderr to config.log (&AS_MESSAGE_LOG_FD), which is not great > because it means that in the failure case the only place where any useful > info appears is config.log. I tried printin