Re: pgsql: Remove pg_dump's --no-synchronized-snapshots switch.

2021-12-17 Thread Adrien Nayrat
On 12/16/21 00:45, Tom Lane wrote: Remove pg_dump's --no-synchronized-snapshots switch. Server versions for which there was a plausible reason to use this switch are all out of support now. Leaving it around would accomplish little except to let careless DBAs shoot themselves in the foot. Disc

Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

2021-12-17 Thread Tom Lane
Noah Misch writes: > Revoke PUBLIC CREATE from public schema, now owned by pg_database_owner. I've just stumbled across a testing problem created by this commit: if you try to skip the tablespace test, the rest of the run falls over, because this bit doesn't get executed: -- Rest of this suite c

Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

2021-12-17 Thread Noah Misch
On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote: > Noah Misch writes: > > Revoke PUBLIC CREATE from public schema, now owned by pg_database_owner. > > I've just stumbled across a testing problem created by this commit: > if you try to skip the tablespace test, the rest of the run falls >

Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

2021-12-17 Thread Tom Lane
Noah Misch writes: > On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote: >> It's sort of annoying to fire up a psql+backend >> for just one command, but perhaps there's other stuff that could be >> put there too. > Yes. The src/test/regress suite would be in a better place if one could run

Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

2021-12-17 Thread Noah Misch
On Fri, Dec 17, 2021 at 01:41:00PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote: > >> It's sort of annoying to fire up a psql+backend > >> for just one command, but perhaps there's other stuff that could be > >> put there too. > > > Yes.

Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas

2021-12-17 Thread Tom Lane
Noah Misch writes: > On Fri, Dec 17, 2021 at 01:41:00PM -0500, Tom Lane wrote: >> If we're thinking of a generalized setup file, putting it after the >> tablespace test feels pretty weird. What was your motivation for >> doing this at the end of tablespace.source rather than the start? > I did i

pgsql: Fix the public schema's permissions in a separate test script.

2021-12-17 Thread Tom Lane
Fix the public schema's permissions in a separate test script. In the wake of commit b073c3ccd, it's necessary to grant create permissions on the public schema to PUBLIC to get many of the core regression test scripts to pass. That commit did so via the quick-n-dirty expedient of adding the GRANT

pgsql: Add option -N/--no-sync to pg_upgrade

2021-12-17 Thread Michael Paquier
Add option -N/--no-sync to pg_upgrade This is an option consistent with what the other tools of src/bin/ (pg_checksums, pg_dump, pg_rewind and pg_basebackup) provide which is useful for leveraging the I/O effort when testing things. This is not to be used in a production environment. All the reg

pgsql: Fix typo in TAP tests of pg_receivewal

2021-12-17 Thread Michael Paquier
Fix typo in TAP tests of pg_receivewal Introduced in d62bcc8, noticed while hacking in the area. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/22592e10b41a95f841642fa16127521989177bbc Modified Files -- src/bin/pg_basebackup/t/020_pg_receivewal.pl | 2