pgsql: Fix compiler warning introduced in commit 705e20f855.

2022-03-14 Thread Amit Kapila
Fix compiler warning introduced in commit 705e20f855. Reported-by: Nathan Bossart Author: Nathan Bossart Reviewed-by: Osumi Takamichi Discussion : https://postgr.es/m/20220314230424.GA1085716@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/695f459f171330

pgsql: Fix collection of typos in the code and the documentation

2022-03-14 Thread Michael Paquier
Fix collection of typos in the code and the documentation Some words were duplicated while other places were grammatically incorrect, including one variable name in the code. Author: Otto Kekalainen, Justin Pryzby Discussion: https://postgr.es/m/7ddbefc5-09b6-4325-b942-b563d1a24...@amazon.com Br

pgsql: Add more regression tests for pg_ls_dir()

2022-03-14 Thread Michael Paquier
Add more regression tests for pg_ls_dir() This system function was being triggered once in the main regression test suite to check its SRF configuration, and more in other test modules but nothing checked the behavior of the options missing_ok and include_dot_dirs. This commit adds some tests for

pgsql: Fix pg_basebackup with in-place tablespaces.

2022-03-14 Thread Thomas Munro
Fix pg_basebackup with in-place tablespaces. Previously, pg_basebackup from a cluster that contained an 'in-place' tablespace, as introduced by commit 7170f215, would produce a harmless warning on Unix and fail completely on Windows. Reported-by: Kyotaro Horiguchi Reviewed-by: Kyotaro Horiguchi

Re: pgsql: Track LLVM 15 changes.

2022-03-14 Thread Thomas Munro
On Wed, Feb 16, 2022 at 11:44 AM Tom Lane wrote: > Andres Freund writes: > > On 2022-02-16 09:18:53 +1300, Thomas Munro wrote: > >> Yeah I mentioned this problem in the other thread. I got as far as > >> finding this write-up: > >> https://llvm.org/docs/OpaquePointers.html > > > Given that major

Yubikey use for commit keys

2022-03-14 Thread Bruce Momjian
I have placed a new commit private key on my Yubikey key and, after making a backup to a USB memory stick, removed it from my file system. I can now do all git pull/fetch/push operations using the private key on my Yubikey. -- Bruce Momjian https://momjian.us EDB

pgsql: Support "of", "tzh", and "tzm" format codes.

2022-03-14 Thread Robert Haas
Support "of", "tzh", and "tzm" format codes. The upper case versions "OF", "TZH", and "TZM" are already supported, and all other format codes that are supported in upper case are also supported in lower case, so we should support these as well for consistency. Nitin Jadhav, with a tiny cosmetic c