Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 12:42 PM Andres Freund wrote: > Pushed an update including the two revs already discussed here, as well as > ed43677e20369040ca4e50c698010c39d5ac0f47 # 2021-01-19 08:10:13 +0530 > # pgindent worker.c. Thanks. > I think a lot of pgindent runs are just to reindent changes d

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Tom Lane
Andres Freund writes: > On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote: >> Ideally there would be some kind of reminder built into the >> pgindent tooling to make it less likely. > I think a lot of pgindent runs are just to reindent changes during > development, so that'd probably just join

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Andres Freund
Hi, Pushed an update including the two revs already discussed here, as well as ed43677e20369040ca4e50c698010c39d5ac0f47 # 2021-01-19 08:10:13 +0530 # pgindent worker.c. On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote: > Ideally there would be some kind of reminder built into the > pgindent t

pgsql: Add a few recent and not so recent revs to git-blame-ignore-revs

2022-03-19 Thread Andres Freund
Add a few recent and not so recent revs to git-blame-ignore-revs. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3c0c5cc5e65906bad6abe6bb8c2d9f6669870f33 Modified Files -- .git-blame-ignore-revs | 9 + 1 file changed, 9 insertions(+)

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 12:27 PM Andres Freund wrote: > I was actually wondering what our policy around that is for smaller runs like > this. Do we do that in bulk occasionally? Just after? That's not completely clear, but I think that it makes sense to do it right afterwards. We haven't been mai

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Andres Freund
On 2022-03-19 12:08:42 -0700, Peter Geoghegan wrote: > On Sat, Mar 19, 2022 at 11:45 AM Andres Freund wrote: > > pgstat: run pgindent on pgstat.c/h. > > Reminder: please add this commit to the .git-blame-ignore-revs file. I was actually wondering what our policy around that is for smaller runs li

Re: pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2022 at 11:45 AM Andres Freund wrote: > pgstat: run pgindent on pgstat.c/h. Reminder: please add this commit to the .git-blame-ignore-revs file. -- Peter Geoghegan

pgsql: ci: windows: Use CIRRUS_ESCAPING_PROCESSES, revert 770011e3f39.

2022-03-19 Thread Andres Freund
ci: windows: Use CIRRUS_ESCAPING_PROCESSES, revert 770011e3f39. cirrus-ci now defaults to killing processes still running at the end of a script. Unfortunately we start postgres in the background, which seems nontrivial to fix. Previously we worked around that in 770011e3f39 by using an older agen

pgsql: pgstat: split out WAL handling from pgstat_{initialize,report_st

2022-03-19 Thread Andres Freund
pgstat: split out WAL handling from pgstat_{initialize,report_stat}. A later commit will move the handling of the different kinds of stats into separate files. By splitting out WAL handling in this commit that later move will just move code around without other changes. Author: Andres Freund Di

pgsql: pgstat: split relation, database handling out of pgstat_report_s

2022-03-19 Thread Andres Freund
pgstat: split relation, database handling out of pgstat_report_stat(). pgstat_report_stat() handles several types of stats, yet relation stats have so far been handled directly in pgstat_report_stat(). A later commit will move the handling of the different kinds of stats into separate files. By

pgsql: pgstat: run pgindent on pgstat.c/h.

2022-03-19 Thread Andres Freund
pgstat: run pgindent on pgstat.c/h. Upcoming commits will touch a lot of the pgstats code. Reindenting separately makes it easier to keep the code in a well-formatted shape each step. Author: Andres Freund Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zco...@alap3.anarazel.de Branch

Re: pgsql: Split ExecUpdate and ExecDelete into reusable pieces

2022-03-19 Thread Alvaro Herrera
On 2022-Mar-19, Amit Langote wrote: > Actually, I also noticed that the v16 patch you posted in the "Re: a > misbehavior of partition row movement (?)" thread contained this same > fix. I like the wording in that patch, though I guess it's better to > commit the fix separately from the big patch

pgsql: Fix an outdated and grammatically wrong comment

2022-03-19 Thread Alvaro Herrera
Fix an outdated and grammatically wrong comment Authored by Amit Langote and myself independently Discussion: https://postgr.es/m/CA+HiwqGCjcH0gG-=tm7hhp7tedmzrhmhjbpgshthgfmx9mn...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a1fc50672c4b410f6a75

pgsql: Improve handling of SET ACCESS METHOD for ALTER MATERIALIZED VIE

2022-03-19 Thread Michael Paquier
Improve handling of SET ACCESS METHOD for ALTER MATERIALIZED VIEW b048326 has added support for SET ACCESS METHOD in ALTER TABLE, but it has missed a few things for materialized views: - No documentation for this clause on the ALTER MATERIALIZED VIEW page. - psql tab completion missing. - No regre

pgsql: Add regression tests for ALTER MATERIALIZED VIEW with tablespace

2022-03-19 Thread Michael Paquier
Add regression tests for ALTER MATERIALIZED VIEW with tablespaces The clauses SET TABLESPACE and ALL IN TABLESPACE are supported in ALTER MATERIALIZED VIEW for a long time, and they behave mostly like ALTER TABLE by reusing the same code paths, but there were zero tests for them. This commit clos

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- REL_

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- REL_

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- REL_

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- REL_

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- mast

pgsql: doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW

2022-03-19 Thread Michael Paquier
doc: Mention SET TABLESPACE clause for ALTER MATERIALIZED VIEW This command flavor is supported, but there was nothing in the documentation about it. Author: Yugo Nagata Discussion: https://postgr.es/m/2022031617.5dc9740abfa24c25ec9f6...@sraoss.co.jp Backpatch-through: 10 Branch -- REL_