pgsql: Remove "recheck" argument from check_index_is_clusterable()

Remove "recheck" argument from check_index_is_clusterable() The last usage of this argument in this routine can be tracked down to 7e2f9062, aka 11 years ago. Getting rid of this argument can also be an advantage for extensions calling check_index_is_clusterable(), as it removes any need to worry

pgsql: Docs: tidy up various usages of the productname tag

Docs: tidy up various usages of the productname tag This tries to bring a bit more consistency to the use of the tag in the documents. This fixes a couple of mistakes with our own product. We definitely should be consistently calling that PostgreSQL when we're referring to the modern-day versio

pgsql: Rework compression options of pg_receivewal

Rework compression options of pg_receivewal Since ba5 and the introduction of LZ4 in pg_receivewal, the compression of the WAL archived is controlled by two options: - --compression-method with "gzip", "none" or "lz4" as possible value. - --compress=N to specify a compression level. This incl

pgsql: Docs: adjust wording about basebackup_to_shell's required_role G

Docs: adjust wording about basebackup_to_shell's required_role GUC Author: Justin Pryzby Reviewed-by: Robert Haas Discussion: https://postgr.es/m/20220411020336.gb26...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d27323db7c451462387cd284275e1e79c59

pgsql: Docs: adjust pg_upgrade syntax to mark -B as optional

Docs: adjust pg_upgrade syntax to mark -B as optional This was made optional in 959f6d6a1. Author: Justin Pryzby Discussion: https://postgr.es/m/20220411020336.gb26...@telsasoft.com Backpatch-through: 13, where -B was made optional Branch -- REL_13_STABLE Details --- https://git.postgre

pgsql: Docs: adjust pg_upgrade syntax to mark -B as optional

Docs: adjust pg_upgrade syntax to mark -B as optional This was made optional in 959f6d6a1. Author: Justin Pryzby Discussion: https://postgr.es/m/20220411020336.gb26...@telsasoft.com Backpatch-through: 13, where -B was made optional Branch -- REL_14_STABLE Details --- https://git.postgre

pgsql: Docs: adjust pg_upgrade syntax to mark -B as optional

Docs: adjust pg_upgrade syntax to mark -B as optional This was made optional in 959f6d6a1. Author: Justin Pryzby Discussion: https://postgr.es/m/20220411020336.gb26...@telsasoft.com Backpatch-through: 13, where -B was made optional Branch -- master Details --- https://git.postgresql.org

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Doc: tweak textsearch.sgml for SEO purposes.

Doc: tweak textsearch.sgml for SEO purposes. Google seems to like to return textsearch.html for queries about GIN and GiST indexes, even though it's not a primary reference for either. It seems likely that that's because those keywords appear in the page title. Since "GIN and GiST Index Types" i

pgsql: Docs: avoid confusing use of the word "synchronized"

Docs: avoid confusing use of the word "synchronized" It's misleading to call the data directory the "synchronized data directory" when discussing a crash scenario when using pg_rewind's --no-sync option. Here we just remove the word "synchronized" to avoid any possible confusion. Author: Justin

pgsql: Docs: avoid confusing use of the word "synchronized"

Docs: avoid confusing use of the word "synchronized" It's misleading to call the data directory the "synchronized data directory" when discussing a crash scenario when using pg_rewind's --no-sync option. Here we just remove the word "synchronized" to avoid any possible confusion. Author: Justin

pgsql: Docs: avoid confusing use of the word "synchronized"

Docs: avoid confusing use of the word "synchronized" It's misleading to call the data directory the "synchronized data directory" when discussing a crash scenario when using pg_rewind's --no-sync option. Here we just remove the word "synchronized" to avoid any possible confusion. Author: Justin

pgsql: Docs: avoid confusing use of the word "synchronized"

Docs: avoid confusing use of the word "synchronized" It's misleading to call the data directory the "synchronized data directory" when discussing a crash scenario when using pg_rewind's --no-sync option. Here we just remove the word "synchronized" to avoid any possible confusion. Author: Justin

pgsql: Revert the addition of GetMaxBackends() and related stuff.

Revert the addition of GetMaxBackends() and related stuff. This reverts commits 0147fc7, 4567596, aa64f23, and 5ecd018. There is no longer agreement that introducing this function was the right way to address the problem. The consensus now seems to favor trying to make a correct value for MaxBacke

pgsql: Remove not-very-useful early checks of __pg_log_level in logging

Remove not-very-useful early checks of __pg_log_level in logging.h. Enforce __pg_log_level message filtering centrally in logging.c, instead of relying on the calling macros to do it. This is more reliable (e.g. it works correctly for direct calls to pg_log_generic) and it saves a percent or so o

pgsql: Doc: update description of random() function.

Doc: update description of random() function. Commit 3804539e4 neglected to update the documentation's claim that random() uses a "linear congruential algorithm". In hopes of avoiding the same mistake if someone replaces our PRNG again, just say it's a deterministic pseudo-random number generator

Re: pgsql: Make node output prefix match node structure name

Peter Eisentraut writes: > Make node output prefix match node structure name Surely this should have included a catversion bump, because it broke stored rules. regards, tom lane

pgsql: Use WRITE_ENUM_FIELD for enum field

Use WRITE_ENUM_FIELD for enum field Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e7cc4a6e3dcc39f3643f998aa5da6a6f27f28db5 Modified Files -- src/backend/nodes/outfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Make node output prefix match node structure name

Make node output prefix match node structure name as done in e58136069687b9cf29c27281e227ac397d72141d Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51e81794058e78a151368d0b652f3c92602568c0 Modified Files -- src/backend/nodes/outfuncs.c | 2 +- src/bac

pgsql: adjust_partition_colnos mustn't be called if not needed

adjust_partition_colnos mustn't be called if not needed Add an assert to make this very explicit, as well as a code comment. The former should silence Coverity complaining about this. Introduced by 7103ebb7aae8. Reported-by: Ranier Vilela Discussion: https://postgr.es/m/CAEudQAqTTAOzXiYybab+1DQ

pgsql: Fix documentation for pg_stat_recovery_prefetch.

Fix documentation for pg_stat_recovery_prefetch. The table was in the wrong section and using an older type of link, as reported by Sirisha, and also using an older table layout, as I noticed while trying to figure out how and when it might have got out of sync. Defect in commit 5dc0418f. Author

pgsql: Fix grammatical errors and typos in logical replication docs.

Fix grammatical errors and typos in logical replication docs. Author: Justin Pryzby Reviewed By: Masahiko Sawada Discussion: https://postgr.es/m/20220411020336.gb26...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aeebb8bf233e7f48a7a6eb6857e7b7c61ef0

pgsql: Remove WalCompressionMethod in favor of pg_compress_algorithm

Remove WalCompressionMethod in favor of pg_compress_algorithm The same structure, with the same set of elements (for none, lz4, gzip and zstd), exists in compression.h, so let's make use of the centralized version instead of duplicating things. Some of the variables used previously for WalCompres

pgsql: Change mechanism to set up source targetlist in MERGE

Change mechanism to set up source targetlist in MERGE We were setting MERGE source subplan's targetlist by expanding the individual attributes of the source relation completely, early in the parse analysis phase. This failed to work when the condition of an action included a whole-row reference,