pgsql: Backpatch 031_recovery_conflict.pl.

2022-05-02 Thread Andres Freund
Backpatch 031_recovery_conflict.pl. The prior commit showed that the introduction of recovery conflict tests was a good idea. Without these tests it's hard to know that the fix didn't break something... 031_recovery_conflict.pl was introduced in 9f8a050f68d and extended in 21e184403bf. Discussio

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Backpatch 031_recovery_conflict.pl.

2022-05-02 Thread Andres Freund
Backpatch 031_recovery_conflict.pl. The prior commit showed that the introduction of recovery conflict tests was a good idea. Without these tests it's hard to know that the fix didn't break something... 031_recovery_conflict.pl was introduced in 9f8a050f68d and extended in 21e184403bf. Discussio

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Backpatch 031_recovery_conflict.pl.

2022-05-02 Thread Andres Freund
Backpatch 031_recovery_conflict.pl. The prior commit showed that the introduction of recovery conflict tests was a good idea. Without these tests it's hard to know that the fix didn't break something... 031_recovery_conflict.pl was introduced in 9f8a050f68d and extended in 21e184403bf. Discussio

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Fix possibility of self-deadlock in ResolveRecoveryConflictWithB

2022-05-02 Thread Andres Freund
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin(). The tests added in 9f8a050f68d failed nearly reliably on FreeBSD in CI, and occasionally on the buildfarm. That turns out to be caused not by a bug in the test, but by a longstanding bug in recovery conflict handling. The

pgsql: Backpatch 031_recovery_conflict.pl.

2022-05-02 Thread Andres Freund
Backpatch 031_recovery_conflict.pl. The prior commit showed that the introduction of recovery conflict tests was a good idea. Without these tests it's hard to know that the fix didn't break something... 031_recovery_conflict.pl was introduced in 9f8a050f68d and extended in 21e184403bf. Discussio

pgsql: Backpatch 031_recovery_conflict.pl.

2022-05-02 Thread Andres Freund
Backpatch 031_recovery_conflict.pl. The prior commit showed that the introduction of recovery conflict tests was a good idea. Without these tests it's hard to know that the fix didn't break something... 031_recovery_conflict.pl was introduced in 9f8a050f68d and extended in 21e184403bf. Discussio

pgsql: Backpatch addition of wait_for_log(), pump_until().

2022-05-02 Thread Andres Freund
Backpatch addition of wait_for_log(), pump_until(). These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are needed by a about-to-be-backpatched test. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7n...@alap3.anarazel.de Backpatch: 10-14 Branch -- REL_10_STAB

pgsql: Backpatch addition of wait_for_log(), pump_until().

2022-05-02 Thread Andres Freund
Backpatch addition of wait_for_log(), pump_until(). These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are needed by a about-to-be-backpatched test. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7n...@alap3.anarazel.de Backpatch: 10-14 Branch -- REL_11_STAB

pgsql: Backpatch addition of wait_for_log(), pump_until().

2022-05-02 Thread Andres Freund
Backpatch addition of wait_for_log(), pump_until(). These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are needed by a about-to-be-backpatched test. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7n...@alap3.anarazel.de Backpatch: 10-14 Branch -- REL_12_STAB

pgsql: Backpatch addition of wait_for_log(), pump_until().

2022-05-02 Thread Andres Freund
Backpatch addition of wait_for_log(), pump_until(). These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are needed by a about-to-be-backpatched test. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7n...@alap3.anarazel.de Backpatch: 10-14 Branch -- REL_14_STAB

pgsql: Backpatch addition of wait_for_log(), pump_until().

2022-05-02 Thread Andres Freund
Backpatch addition of wait_for_log(), pump_until(). These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are needed by a about-to-be-backpatched test. Discussion: https://postgr.es/m/20220413002626.udl7lll7f3o7n...@alap3.anarazel.de Backpatch: 10-14 Branch -- REL_13_STAB

pgsql: Add tests for recovery deadlock conflicts.

2022-05-02 Thread Andres Freund
Add tests for recovery deadlock conflicts. The recovery conflict tests added in 9f8a050f68d surfaced a bug in the interaction between buffer pin and deadlock recovery conflicts. To make sure that the bugfix won't break deadlock conflict detection, add a test for that scenario. 031_recovery_confli

pgsql: basebackup_to_shell: Add missing MarkGUCPrefixReserved()

2022-05-02 Thread Michael Paquier
basebackup_to_shell: Add missing MarkGUCPrefixReserved() Oversight in c6306db24, as per a requirement from 88103567. All the other modules in the tree, be they in contrib/ or src/test/modules/, already do that. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACUy7q_KwSMda+2SHPSWe

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d85f2bfa09f64e52436e8f05a9e112e160bace65 Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d6ae041c87488af37bc1f8b30697c3df1c24e65f Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1dd49df7834ceccc61fae2801e246e793e08b5ad Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/09b684647a681c1badb7569957591245791f8579 Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/24c58f7a2a5c762f35ffe8aaa00fa08caeb881fe Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix typo in comment.

2022-05-02 Thread Etsuro Fujita
Fix typo in comment. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d89f97e83efed4b2ac0a1803a1b6813c8277de73 Modified Files -- src/backend/storage/ipc/latch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-02 Thread Michael Paquier
On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote: > IIRC we know that tar will be available on Windows. What about gzip? Are the binaries and the libraries split into different packages for this package manager on Windows? We've never assumed that this is possible on ./configure, b