pgsql: Fix typos and grammar in code and test comments

2022-05-10 Thread Michael Paquier
Fix typos and grammar in code and test comments This fixes the grammar of some comments in a couple of tests (SQL and TAP), and in some C files. Author: Justin Pryzby Discussion: https://postgr.es/m/20220511020334.gh19...@telsasoft.com Branch -- master Details --- https://git.postgresql

pgsql: Add logging for excessive ProcSignalBarrier waits.

2022-05-10 Thread Thomas Munro
Add logging for excessive ProcSignalBarrier waits. To enable diagnosis of systems that are not processing ProcSignalBarrier requests promptly, add a LOG message every 5 seconds if we seem to be wedged. Although you could already see this state as a wait event in pg_stat_activity, the log message

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Fix the logical replication timeout during large transactions.

2022-05-10 Thread Amit Kapila
Fix the logical replication timeout during large transactions. The problem is that we don't send keep-alive messages for a long time while processing large transactions during logical replication where we don't send any data of such transactions. This can happen when the table modified in the tran

pgsql: Silence extra logging when using "postgres -C" on runtime-comput

2022-05-10 Thread Michael Paquier
Silence extra logging when using "postgres -C" on runtime-computed GUCs Presently, the server may emit a variety of log messages when inspecting a runtime-computed GUC, mostly in the shape of one LOG message with the default configuration, related to the startup sequence launched as such GUCs requ

pgsql: Add missing source files to nls.mk

2022-05-10 Thread Peter Eisentraut
Add missing source files to nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3aa7a3d2a3d1177d32680b94541dc2db7f3d7b0b Modified Files -- src/bin/psql/nls.mk | 2 +- src/interfaces/libpq/nls.mk | 2 +- 2 files changed, 2 insertions(+), 2 deleti

pgsql: relnotes: more adjustments

2022-05-10 Thread Bruce Momjian
relnotes: more adjustments Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20220511013117.gg19...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/38fbbb5bb293c4cceebb130b42357a2d6ee8d294 Modified Files -- doc/src/sgml/release-

pgsql: relnotes: logical replication permissions checked by subscrib.

2022-05-10 Thread Bruce Momjian
relnotes: logical replication permissions checked by subscrib. Reported-by: Mark Dilger Discussion: https://postgr.es/m/f3d44160-f41a-4f2e-aed5-5c15b6903...@enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/581c4e5b31853045473949822bcd0c90daf850fb

pgsql: relnotes: adjustments

2022-05-10 Thread Bruce Momjian
relnotes: adjustments Remove SSL item backpatched (Jonathan S. Katz), adjust logical replication item (Mark Dilger), adjust --compress wording (Justin Pryzby). Discussion: https://postgr.es/m/20220511012854.gf19...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/p

Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa

2022-05-10 Thread Michael Paquier
On Tue, May 10, 2022 at 09:57:29AM +0900, Michael Paquier wrote: > This needs to be adjusted on all the stable branches, so I'll do that > once this week's version is tagged. Attached is an updated patch for > now. The tags have been pushed, so done now. -- Michael signature.asc Description: PG

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

pgsql: Improve setup of environment values for commands in MSVC's vcreg

2022-05-10 Thread Michael Paquier
Improve setup of environment values for commands in MSVC's vcregress.pl The current setup assumes that commands for lz4, zstd and gzip always exist by default if not enforced by a user's environment. However, vcpkg, as one example, installs libraries but no binaries, so this default setup to assu

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-10 Thread David Rowley
On Tue, 10 May 2022 at 21:45, John Naylor wrote: > > On Tue, May 10, 2022 at 3:46 PM David Rowley wrote: > > What do you think? > > +1 Thanks for having a look. I pushed this after I made a small adjustment to #ifdef out the qsort_tuple_signed sort specialization in 32-bit builds. On testing a

pgsql: Fix some incorrect preprocessor tests in tuplesort specializatio

2022-05-10 Thread David Rowley
Fix some incorrect preprocessor tests in tuplesort specializations 697492434 added 3 new quicksort specialization functions for common datatypes. That commit was not very consistent in how it would determine if we're compiling for 32-bit or 64-bit machines. It would sometimes use USE_FLOAT8_BYVA

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: configure: don't probe for libldap_r if libldap is 2.5 or newer.

2022-05-10 Thread Tom Lane
configure: don't probe for libldap_r if libldap is 2.5 or newer. In OpenLDAP 2.5 and later, libldap itself is always thread-safe and there's never a libldap_r. Our existing coding dealt with that by assuming it wouldn't find libldap_r if libldap is thread-safe. But that rule fails to cope if ther

pgsql: relnotes: adjust sections for various items

2022-05-10 Thread Bruce Momjian
relnotes: adjust sections for various items Also improve postgres_fdw.application_name Reported-by: Justin Pryzby, Tatsuo Ishii Diagnosed-by: 20220510210235.gd19...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b0d4b3c386f5372474575a4eeba2450951d9

pgsql: relnote: add ARM64 spinlock item

2022-05-10 Thread Bruce Momjian
relnote: add ARM64 spinlock item Reported-by: Jonathan Katz Discussion: per private email Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/40131af573514d9915798f5fa6399ddc3d214937 Modified Files -- doc/src/sgml/release-15.sgml | 11 +++ 1 file c

pgsql: relnotes: remove sequence replication and update 'postgres -C'

2022-05-10 Thread Bruce Momjian
relnotes: remove sequence replication and update 'postgres -C' Reported-by: Nathan Bossart, Jonathan Katz Discussion: https://postgr.es/m/20220510194456.GA3716556@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/653443ed83f03820d29604b65dca6a56f3f8ab06

pgsql: relnote: extensive updates

2022-05-10 Thread Bruce Momjian
relnote: extensive updates Reported-by: Erik Rijkers, Justin Pryzby Discussion: https://postgr.es/m/20220510180935.gb19...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9d89bb8a025d0374f7705cea9fead4eae9ae80ed Modified Files -- doc/src

pgsql: Formatting and punctuation improvements in sample configuration

2022-05-10 Thread Peter Eisentraut
Formatting and punctuation improvements in sample configuration files Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9700b250c5b84a083261add9f6e3507c9c72e076 Modified Files -- contrib/basic_archive/basic_archive.conf | 4 ++-- src/backend/utils/misc

pgsql: Remove some tabs in SQL code in C string literals

2022-05-10 Thread Peter Eisentraut
Remove some tabs in SQL code in C string literals This is not handled uniformly throughout the code, but at least nearby code can be consistent. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/93e6892f6717d5777c9decef301728e8bb3f011b Modified Files -- s

pgsql: doc: Update SQL keywords for SQL:2016 technical corrigenda

2022-05-10 Thread Peter Eisentraut
doc: Update SQL keywords for SQL:2016 technical corrigenda Several keywords were missing or misclassified in the original SQL:2016 standard. This has been corrected in later technical corrigenda. This change updates the PostgreSQL documentation accordingly. This also fixes a mistake in 606948b0

pgsql: relnotes: "training" -> "trailing"

2022-05-10 Thread Bruce Momjian
relnotes: "training" -> "trailing" Reported-by: Geoff Winkless Discussion: https://postgr.es/m/CAEzk6fdF_J4jqicLz=FZ6R1u2EjpEtmzD55tFjVbxw-O-kR1=w...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3c534949bbb0c7f312175879d1bf7de4f336c6e1 Modified

pgsql: doc: first draft of PG 15 release notes

2022-05-10 Thread Bruce Momjian
doc: first draft of PG 15 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9499606db00290562096d74f62cf47f953795b58 Modified Files -- doc/src/sgml/release-15.sgml | 2926 +- 1 file changed, 2915 insert

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-10 Thread John Naylor
On Tue, May 10, 2022 at 3:46 PM David Rowley wrote: > I was just looking over this change and wondered a few things: > > 1. Shouldn't ssup_datum_signed_cmp and ssup_datum_int32_cmp be using > DatumGetInt32 and DatumGetInt64? Right. > This is hypothetical, but if for some reason SIZEOF_VOIDP was

Re: pgsql: Specialize tuplesort routines for different kinds of abbreviated

2022-05-10 Thread David Rowley
On Sat, 2 Apr 2022 at 21:30, John Naylor wrote: > src/backend/utils/sort/tuplesort.c | 160 - I was just looking over this change and wondered a few things: 1. Shouldn't ssup_datum_signed_cmp and ssup_datum_int32_cmp be using DatumGetInt32 and DatumGetInt64? 2