pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Be more wary about 32-bit integer overflow in pg_stat_statements

2022-08-02 Thread Tom Lane
Be more wary about 32-bit integer overflow in pg_stat_statements. We've heard a couple of reports of people having trouble with multi-gigabyte-sized query-texts files. It occurred to me that on 32-bit platforms, there could be an issue with integer overflow of calculations associated with the tot

pgsql: Remove unused fields from ExprEvalStep

2022-08-02 Thread David Rowley
Remove unused fields from ExprEvalStep These were added recently by 1349d2790. Reported-by: Zhihong Yu Discussion: https://postgr.es/m/CALNJ-vTi+YDuAWKp4Z_Dv=mrz=aq81qtg0d7wzc8y7rs_+i...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9fc1776dda9f1b

pgsql: Change type "char"'s I/O format for non-ASCII characters.

2022-08-02 Thread Tom Lane
Change type "char"'s I/O format for non-ASCII characters. Previously, a byte with the high bit set was just transmitted as-is by charin() and charout(). This is problematic if the database encoding is multibyte, because the result of charout() won't be validly encoded, which breaks various stuff

pgsql: Change type "char"'s I/O format for non-ASCII characters.

2022-08-02 Thread Tom Lane
Change type "char"'s I/O format for non-ASCII characters. Previously, a byte with the high bit set was just transmitted as-is by charin() and charout(). This is problematic if the database encoding is multibyte, because the result of charout() won't be validly encoded, which breaks various stuff

pgsql: Improve performance of ORDER BY / DISTINCT aggregates

2022-08-02 Thread David Rowley
Improve performance of ORDER BY / DISTINCT aggregates ORDER BY / DISTINCT aggreagtes have, since implemented in Postgres, been executed by always performing a sort in nodeAgg.c to sort the tuples in the current group into the correct order before calling the transition function on the sorted tuple

pgsql: doc: Fix typos in protocol.sgml

2022-08-02 Thread Michael Paquier
doc: Fix typos in protocol.sgml Author: Ekaterina Kiryanova Discussion: https://postgr.es/m/745414e7-efb2-a6ae-5b83-fcbdf35aa...@postgrespro.ru Backpatch-through: 15 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a69959fab2f3633992b5cabec85acecbac6074c8 Modified

pgsql: doc: Fix typos in protocol.sgml

2022-08-02 Thread Michael Paquier
doc: Fix typos in protocol.sgml Author: Ekaterina Kiryanova Discussion: https://postgr.es/m/745414e7-efb2-a6ae-5b83-fcbdf35aa...@postgrespro.ru Backpatch-through: 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5b94d3ccb7ad9be902c37505ed54aabd2aeeccf1 Mo