pgsql: Change shared library installation naming on macOS

2022-08-23 Thread Peter Eisentraut
Change shared library installation naming on macOS It is not customary to install a shared library with a minor version number (libpq.5.16.dylib) on macOS. We just need the file with the major version number (libpq.5.dylib) and the one without version number (libpq.dylib). This also matches the

pgsql: Allow parallel workers to retrieve some data from Port

2022-08-23 Thread Michael Paquier
Allow parallel workers to retrieve some data from Port This commit moves authn_id into a new global structure called ClientConnectionInfo (mapping to a MyClientConnectionInfo for each backend) which is intended to hold all the client information that should be shared between the backend and any of

pgsql: Further reduce warnings with -Wshadow=compatible-local

2022-08-23 Thread David Rowley
Further reduce warnings with -Wshadow=compatible-local In a similar effort to f01592f91, here we're targetting fixing the warnings that -Wshadow=compatible-local produces that we can fix by moving a variable to an inner scope to stop that variable from being shadowed by another variable declared s

pgsql: Message style adjustment

2022-08-23 Thread Peter Eisentraut
Message style adjustment Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dfe2eb7633f53c26cac6d31d1cb5736113d16349 Modified Files -- src/interfaces/libpq/fe-auth-scram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Message style adjustment

2022-08-23 Thread Peter Eisentraut
Message style adjustment Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/869e56a39976a42a393adc2d69df3abce7eff18f Modified Files -- src/interfaces/libpq/fe-auth-scram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Remove further unwanted linker flags from perl_embed_ldflags

2022-08-23 Thread Peter Eisentraut
Remove further unwanted linker flags from perl_embed_ldflags Remove the contents of $Config{ldflags} from ExtUtils::Embed's ldopts, like we already do with $Config{ccdlflags}. Those flags are the choices of those who built the Perl installation, which are not necessarily appropriate for building

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Remove our artificial PG_SOMAXCONN limit on listen queue length.

2022-08-23 Thread Tom Lane
Remove our artificial PG_SOMAXCONN limit on listen queue length. I added this in commit 153f40067, out of paranoia about kernels possibly rejecting very large listen backlog requests. However, POSIX has said for decades that the kernel must silently reduce any value it considers too large, and th

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: prefer sysctl to /proc/sys in docs and comments.

2022-08-23 Thread Tom Lane
Doc: prefer sysctl to /proc/sys in docs and comments. sysctl is more portable than Linux's /proc/sys file tree, and often easier to use too. That's why most of our docs refer to sysctl when talking about how to adjust kernel parameters. Bring the few stragglers into line. Discussion: https://pos

pgsql: Doc: document possible need to raise kernel's somaxconn limit.

2022-08-23 Thread Tom Lane
Doc: document possible need to raise kernel's somaxconn limit. On fast machines, it's possible for applications such as pgbench to issue connection requests so quickly that the postmaster's listen queue overflows in the kernel, resulting in unexpected failures (with not-very-helpful error messages

pgsql: Remove offsetof definition

2022-08-23 Thread Peter Eisentraut
Remove offsetof definition This was only needed to deal with some ancient and no longer supported systems. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/9a5223a2-3e25-d4fb-f092-01ec17428584%40enterprisedb.com Branch -- master Details --- https://git.post

pgsql: Don't bother to set sockaddr_un.sun_len.

2022-08-23 Thread Thomas Munro
Don't bother to set sockaddr_un.sun_len. It's not necessary to fill in sun_len when calling bind() or connect(), on all known systems that have it. Discussion: https://postgr.es/m/2781112.1644819528%40sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c9