Re: pgsql: Move memory management away from writetup() and tuplesort_put*()

2022-08-25 Thread David Rowley
On Wed, 27 Jul 2022 at 17:29, Alexander Korotkov wrote: > src/backend/utils/sort/tuplesort.c | 78 -- I was wondering about the following comment that this commit added: +/* + * Write a stored tuple onto tape.tuple. Unless the slab allocator is + * used,

pgsql: Remove configure probe for sockaddr_in6 and require AF_INET6.

2022-08-25 Thread Thomas Munro
Remove configure probe for sockaddr_in6 and require AF_INET6. SUSv3 defines struct sockaddr_in6, and all targeted Unix systems have it. Windows has it in . Remove the configure probe, the macro and a small amount of dead code. Also remove a mention of IPv6-less builds from the documentation,

pgsql: libpq code should use libpq_gettext(), not _()

2022-08-25 Thread Peter Eisentraut
libpq code should use libpq_gettext(), not _() Fix some wrong use and install a safeguard against future mistakes. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/28ec316787674dd74d00b296724a009b6edc2fb0 Modified Files --

pgsql: libpq code should use libpq_gettext(), not _()

2022-08-25 Thread Peter Eisentraut
libpq code should use libpq_gettext(), not _() Fix some wrong use and install a safeguard against future mistakes. Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c742eb36b1eb516166cdcb307a37dded51fa6089 Modified Files --

pgsql: Fix doc oversight for custom WAL resource managers.

2022-08-25 Thread Jeff Davis
Fix doc oversight for custom WAL resource managers. Reported-by: Bharath Rupireddy Backpatch-through: 15 Discussion: https://postgr.es/m/calj2acu+at7rqnwezs59qsfg3zof4c4gsp7pt+pwilep0zr...@mail.gmail.com Branch -- master Details ---

pgsql: Fix doc oversight for custom WAL resource managers.

2022-08-25 Thread Jeff Davis
Fix doc oversight for custom WAL resource managers. Reported-by: Bharath Rupireddy Backpatch-through: 15 Discussion: https://postgr.es/m/calj2acu+at7rqnwezs59qsfg3zof4c4gsp7pt+pwilep0zr...@mail.gmail.com Branch -- REL_15_STABLE Details ---

pgsql: Small refactor to get rid of -Wshadow=compatible-local warning

2022-08-25 Thread David Rowley
Small refactor to get rid of -Wshadow=compatible-local warning Further reduce -Wshadow=compatible-local warnings by 1 by refactoring the code in gistRelocateBuildBuffersOnSplit() to make use of foreach_current_index() instead of manually incrementing a variable on each loop. Author: David Rowley

pgsql: More -Wshadow=compatible-local warning fixes

2022-08-25 Thread David Rowley
More -Wshadow=compatible-local warning fixes In a similar effort to f01592f91, here we're targetting fixing the warnings where we've deemed the shadowing variable to serve a close enough purpose to the shadowed variable just to reuse the shadowed version and not declare the shadowing variable at

pgsql: Allow grant-level control of role inheritance behavior.

2022-08-25 Thread Robert Haas
Allow grant-level control of role inheritance behavior. The GRANT statement can now specify WITH INHERIT TRUE or WITH INHERIT FALSE to control whether the member inherits the granted role's permissions. For symmetry, you can now likewise write WITH ADMIN TRUE or WITH ADMIN FALSE to turn ADMIN

pgsql: Update another comment still referring to pg_start/stop_backup()

2022-08-25 Thread Peter Eisentraut
Update another comment still referring to pg_start/stop_backup() Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/19c4de8289bedf90ac10d496e3896f8838937a83 Modified Files -- src/test/recovery/t/020_archive_status.pl | 2 +- 1 file changed, 1

pgsql: Update another comment still referring to pg_start/stop_backup()

2022-08-25 Thread Peter Eisentraut
Update another comment still referring to pg_start/stop_backup() Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/421ccaa6272a2935a3d2e578ff6fab7d8848 Modified Files -- src/test/recovery/t/020_archive_status.pl | 2 +- 1 file changed, 1 insertion(+),

pgsql: Move NON_EXEC_STATIC from c.h to postgres.h

2022-08-25 Thread Peter Eisentraut
Move NON_EXEC_STATIC from c.h to postgres.h It is not needed at the scope of c.h, only in backend code. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/a6a6b48e-ca0a-b58d-18de-98e40d94b842%40enterprisedb.com Branch -- master Details ---

Re: pgsql: pg_dump: Dump colliculocale

2022-08-25 Thread Peter Eisentraut
Thanks, I had already fixed it. On 25.08.22 07:03, Marina Polyakova wrote: More precisely, diff_fix_002_pg_dump_v2.patch... On 2022-08-25 07:50, Marina Polyakova wrote: Hello! Sorry for that, diff_fix_002_pg_dump.patch fixes this issue for me... On 2022-08-25 04:46, Tom Lane wrote: I

pgsql: doc: Fix typo in GRANT docs

2022-08-25 Thread Daniel Gustafsson
doc: Fix typo in GRANT docs Commit ce6b672e445 accidentally introduced a trivial typo in the documentation for GRANT. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d16c99aa71047e3cd94dad85f9fa82a7d6f94eed Modified Files -- doc/src/sgml/ref/grant.sgml

pgsql: Fix typo in MVCC test comment

2022-08-25 Thread Daniel Gustafsson
Fix typo in MVCC test comment The optimization is named kill_prior_tuple but was accidentally spelled kill_prio_tuple in the test. Author: Mingli Zhang Discussion: https://postgr.es/m/82d3e66a-d8ae-4bfa-943e-29c5add0743f@Spark Branch -- master Details ---

pgsql: Remove unused symbol __aarch64

2022-08-25 Thread John Naylor
Remove unused symbol __aarch64 This was added as a possible variant of __aarch64__ back when 64-bit ARM was vaporware. It hasn't shown up in the wild since then, so remove. Nathan Bossart Discussion: