Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-12 Thread Noah Misch
On Mon, Sep 12, 2022 at 11:11:23PM -0700, Andres Freund wrote: > On 2022-09-12 20:38:45 -0700, Noah Misch wrote: > > On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > > > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > >

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-12 Thread Andres Freund
Hi, On 2022-09-12 20:38:45 -0700, Noah Misch wrote: > On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > > > > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > > > > Andre

Re: pgsql: aix: No need to use mkldexport when we want to export all symbol

2022-09-12 Thread Noah Misch
On Sun, Sep 11, 2022 at 11:19:25AM -0700, Andres Freund wrote: > On 2022-09-10 01:19:44 -0700, Andres Freund wrote: > > On 2022-09-09 22:57:36 -0700, Andres Freund wrote: > > > On 2022-09-10 01:32:52 -0400, Tom Lane wrote: > > > > Andres Freund writes: > > > > > It seem worth applying the -qvisibi

pgsql: Rename macro related to pg_backup_stop()

2022-09-12 Thread Michael Paquier
Rename macro related to pg_backup_stop() This should have been part of 39969e2 that has renamed pg_stop_backup() to pg_backup_stop(), and this one is the last reference to pg_stop/start_backup() I could find in the tree. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACXjvC28ppeD

pgsql: Move any remaining files generated by pg_upgrade into an interna

2022-09-12 Thread Michael Paquier
Move any remaining files generated by pg_upgrade into an internal subdir This change concerns a couple of .txt files (for internal state checks) that were still written in the path where the binary is executed, and not in the subdirectory located in the target cluster. Like the other .txt files d

pgsql: Move any remaining files generated by pg_upgrade into an interna

2022-09-12 Thread Michael Paquier
Move any remaining files generated by pg_upgrade into an internal subdir This change concerns a couple of .txt files (for internal state checks) that were still written in the path where the binary is executed, and not in the subdirectory located in the target cluster. Like the other .txt files d

pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult

2022-09-12 Thread David Rowley
Don't reference out-of-bounds array elements in brin_minmax_multi.c The primary fix here is to fix has_matching_range() so it does not reference ranges->values[-1] when nranges == 0. Similar problems existed in AssertCheckRanges() too. It does not look like any of these problems could lead to a

pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult

2022-09-12 Thread David Rowley
Don't reference out-of-bounds array elements in brin_minmax_multi.c The primary fix here is to fix has_matching_range() so it does not reference ranges->values[-1] when nranges == 0. Similar problems existed in AssertCheckRanges() too. It does not look like any of these problems could lead to a

pgsql: Don't reference out-of-bounds array elements in brin_minmax_mult

2022-09-12 Thread David Rowley
Don't reference out-of-bounds array elements in brin_minmax_multi.c The primary fix here is to fix has_matching_range() so it does not reference ranges->values[-1] when nranges == 0. Similar problems existed in AssertCheckRanges() too. It does not look like any of these problems could lead to a

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: doc: Fix link to FreeBSD documentation project

2022-09-12 Thread Daniel Gustafsson
doc: Fix link to FreeBSD documentation project The FreeBSD site was changed with a redirect, which in turn seems to lead to a 404. Replace with the working link. Author: James Coleman Discussion: https://postgr.es/m/CAAaqYe_JZRj+KPn=hACtwsg1iLRYs=jyvxg1nw4andeul1g...@mail.gmail.com Branch

pgsql: Use normal install program to install server headers.

2022-09-12 Thread Heikki Linnakangas
Use normal install program to install server headers. Commit a7032690f9 replaced $(INSTALL) with plain "cp" for installing the server header files. It sped up "make install" significantly, because the old logic called $(INSTALL) separately for every header file, whereas plain "cp" could copy all t

pgsql: Revert "Convert *GetDatum() and DatumGet*() macros to inline fun

2022-09-12 Thread Peter Eisentraut
Revert "Convert *GetDatum() and DatumGet*() macros to inline functions" This reverts commit 595836e99bf1ee6d43405b885fb69bb8c6d3ee23. It has problems when USE_FLOAT8_BYVAL is off. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e8d78581bb864369035c736a82ecfb57482a1

pgsql: Convert *GetDatum() and DatumGet*() macros to inline functions

2022-09-12 Thread Peter Eisentraut
Convert *GetDatum() and DatumGet*() macros to inline functions The previous macro implementations just cast the argument to a target type but did not check whether the input type was appropriate. The function implementation can do better type checking of the input type. Reviewed-by: Aleksander A

pgsql: Add list of acknowledgments to release notes

2022-09-12 Thread Peter Eisentraut
Add list of acknowledgments to release notes This contains all individuals mentioned in the commit messages during PostgreSQL 15 development. current through REL_15_BETA4 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cb49042b58f8ca42da1cd7f2baf56bf52d92cd6

pgsql: Fix NaN comparison in circle_same test

2022-09-12 Thread Daniel Gustafsson
Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. p

pgsql: Fix NaN comparison in circle_same test

2022-09-12 Thread Daniel Gustafsson
Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. p

pgsql: Fix NaN comparison in circle_same test

2022-09-12 Thread Daniel Gustafsson
Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. p

pgsql: Fix NaN comparison in circle_same test

2022-09-12 Thread Daniel Gustafsson
Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. p

pgsql: Fix NaN comparison in circle_same test

2022-09-12 Thread Daniel Gustafsson
Fix NaN comparison in circle_same test Commit c4c340088 changed geometric operators to use float4 and float8 functions, and handle NaN's in a better way. The circle sameness test had a typo in the code which resulted in all comparisons with the left circle having a NaN radius considered same. p

Re: pgsql: Fix perltidy breaking perlcritic

2022-09-12 Thread Dagfinn Ilmari Mannsåker
Andrew Dunstan writes: > On Fri, Sep 9, 2022 at 10:44 PM John Naylor > wrote: > >> On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan wrote: >> >> > A better way do do this IMNSHO is to put the eval in a block on its own >> along with the no critic marker on its own line, like this: >> > >> > { >> >

pgsql: pgstattuple: Use double consistently for percentages

2022-09-12 Thread Peter Eisentraut
pgstattuple: Use double consistently for percentages pgstattuple uses data type double for other percentage calculations and exposes those values to the users via the float8 data type. However, scanned_percent in struct output_type is of type uint64, even though it is later returned via Float8GetD

pgsql: Use float8 datatype for percentiles in pg_walinspect stat functi

2022-09-12 Thread Peter Eisentraut
Use float8 datatype for percentiles in pg_walinspect stat functions pg_walinspect uses datatype double (double precision floating point number) for WAL stats percentile calculations and expose them via float4 (single precision floating point number), which an unnecessary loss of precision and conf

pgsql: Use float8 datatype for percentiles in pg_walinspect stat functi

2022-09-12 Thread Peter Eisentraut
Use float8 datatype for percentiles in pg_walinspect stat functions pg_walinspect uses datatype double (double precision floating point number) for WAL stats percentile calculations and expose them via float4 (single precision floating point number), which an unnecessary loss of precision and conf

pgsql: Make the tablesync worker's replication origin drop logic robust

2022-09-12 Thread Amit Kapila
Make the tablesync worker's replication origin drop logic robust. In commit f6c5edb8ab, we started to drop the replication origin slots before tablesync worker exits to avoid consuming more slots than required. We were dropping the replication origin in the same transaction where we were marking t