pgsql: Fix huge_pages on Windows

2022-09-16 Thread Michael Paquier
Fix huge_pages on Windows Since Windows 10 1703, it is additionally necessary to pass a flag called FILE_MAP_LARGE_PAGES to MapViewOfFile() to enable large pages at map time. This flag is ignored on older versions of Windows, where large pages should still be able to work properly without setting

pgsql: Message style improvements

2022-09-16 Thread Peter Eisentraut
Message style improvements Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/23bcc8d877efde5cbbfe50bbbf12a96434e41f36 Modified Files -- src/backend/backup/basebackup.c| 2 +- src/backend/backup/basebackup_target.c | 4 ++-- 2 files changed, 3

pgsql: Message style improvements

2022-09-16 Thread Peter Eisentraut
Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a0b65155d04e3d78e1ee92d5e3c6c340c7c6b286 Modified Files -- src/backend/backup/basebackup.c| 2 +- src/backend/backup/basebackup_target.c | 4 ++-- 2 files changed, 3 inserti

Re: pgsql: pgstat: add/extend tests for resetting various kinds of stats.

2022-09-16 Thread Tom Lane
I wrote: >> * required to to do so. > This isn't grammatically bad, ... um, other than the two "to"s. But the semantic omission is a bigger deal. regards, tom lane

Re: pgsql: pgstat: add/extend tests for resetting various kinds of stats.

2022-09-16 Thread Tom Lane
Andres Freund writes: > On 2022-09-15 15:59:52 -0400, Tom Lane wrote: >> It seems likely to me that the n_sessions increment hasn't made it to shared >> memory because some background process happened to have a lock on the stats >> entry when we tried. Don't we need a pg_stat_force_next_flush() c

Re: pgsql: pgstat: add/extend tests for resetting various kinds of stats.

2022-09-16 Thread Andres Freund
Hi, On 2022-09-15 15:59:52 -0400, Tom Lane wrote: > Andres Freund writes: > > pgstat: add/extend tests for resetting various kinds of stats. > > crake just failed [1] with what appears to be a race condition in > a test case added by this commit: > > diff -U3 /home/andrew/bf/root/HEAD/pgsql/src

pgsql: Fix race condition in stats.sql added in 5264add7847

2022-09-16 Thread Andres Freund
Fix race condition in stats.sql added in 5264add7847 Very occasionally the stats test failed due to the number of sessions not being updated yet. Likely this requires that there is contention on the database's stats entry. Solve this by forcing pending stats to be flushed before fetching the stats

pgsql: Fix race condition in stats.sql added in 5264add7847

2022-09-16 Thread Andres Freund
Fix race condition in stats.sql added in 5264add7847 Very occasionally the stats test failed due to the number of sessions not being updated yet. Likely this requires that there is contention on the database's stats entry. Solve this by forcing pending stats to be flushed before fetching the stats

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: Improve plpgsql's ability to handle arguments declared as RECORD

2022-09-16 Thread Tom Lane
Improve plpgsql's ability to handle arguments declared as RECORD. Treat arguments declared as RECORD as if that were a polymorphic type (which it is, sort of), in that we substitute the actual argument type while forming the function cache lookup key. This allows the specific composite type to be

pgsql: aix: xlc: Use -Wl,-b,expfull for old compiler versions

2022-09-16 Thread Andres Freund
aix: xlc: Use -Wl,-b,expfull for old compiler versions Unfortunately xlc 12.1 and earlier don't support -qvisibility. Therefore be7c15b194a doesn't suffice to make extension libraries work without the explicit mkldexport step removed in fe6a64a58ab. While 12.1 is EOL, there is some desire to leave

pgsql: Clean up minor inconsistencies in pg_attribute_printf() usage.

2022-09-16 Thread Tom Lane
Clean up minor inconsistencies in pg_attribute_printf() usage. For some reason we'd never decorated pg_v*printf() with pg_attribute_printf() annotations. There is a convention for how to label va_list-using printf functions (write zero for the second argument), and we use that liberally elsewhere

pgsql: Message wording improvements

2022-09-16 Thread Peter Eisentraut
Message wording improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2451385cbb40f930838f6cd86c244912590a7d2 Modified Files -- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/commands/subscriptioncmds.c| 6 +++--- src/test/subsc

pgsql: Message wording improvements

2022-09-16 Thread Peter Eisentraut
Message wording improvements Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c946425176f39e4656718a684a53e8dde5cc641a Modified Files -- doc/src/sgml/logical-replication.sgml | 2 +- src/backend/commands/subscriptioncmds.c| 6 +++--- src/tes

pgsql: postgres_fdw: Remove useless DO block in test

2022-09-16 Thread Peter Eisentraut
postgres_fdw: Remove useless DO block in test Discussion: https://www.postgresql.org/message-id/flat/b1f9f399-3a1a-b554-283f-4ae7f3460...@enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/32b507378fac179717f093c78a0e70371fbdf514 Modified Files -

pgsql: Adjust assorted hint messages that list all valid options.

2022-09-16 Thread Peter Eisentraut
Adjust assorted hint messages that list all valid options. Instead of listing all valid options, we now try to provide one that looks similar. Since this may be useful elsewhere, this change introduces a new set of functions that can be reused for similar purposes. Author: Nathan Bossart Discus

pgsql: Fix createdb tests for C locale

2022-09-16 Thread Peter Eisentraut
Fix createdb tests for C locale If the createdb tests run under the C locale, the database cluster will be initialized with encoding SQL_ASCII. With the checks added in c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several ICU-related tests to fail because SQL_ASCII is not supported b

pgsql: Fix createdb tests for C locale

2022-09-16 Thread Peter Eisentraut
Fix createdb tests for C locale If the createdb tests run under the C locale, the database cluster will be initialized with encoding SQL_ASCII. With the checks added in c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several ICU-related tests to fail because SQL_ASCII is not supported b

pgsql: Don't allow creation of database with ICU locale with unsupporte

2022-09-16 Thread Peter Eisentraut
Don't allow creation of database with ICU locale with unsupported encoding Check in CREATE DATABASE and initdb that the selected encoding is supported by ICU. Before, they would pass but users would later get an error from the server when they tried to use the database. Also document that initdb

pgsql: Don't allow creation of database with ICU locale with unsupporte

2022-09-16 Thread Peter Eisentraut
Don't allow creation of database with ICU locale with unsupported encoding Check in CREATE DATABASE and initdb that the selected encoding is supported by ICU. Before, they would pass but users would later get an error from the server when they tried to use the database. Also document that initdb