pgsql: Remove unused argument "isSlice" from transformAssignmentSubscri

2022-09-17 Thread Michael Paquier
Remove unused argument "isSlice" from transformAssignmentSubscripts() Since c7aba7c, the transform method used during parse analysis of a subcripting construct has moved from transformAssignmentSubscripts() to the per-type transform method (arrays or arbitrary types) the step that checks for slici

Re: pgsql: Harmonize reorderbuffer parameter names.

2022-09-17 Thread Peter Geoghegan
On Sat, Sep 17, 2022 at 9:47 PM Tom Lane wrote: > ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still > short some parameter names. I actually noticed that clang-tidy missed this one myself, shortly after commit. I still haven't figured out why, but it seems like it might be

Re: pgsql: Harmonize reorderbuffer parameter names.

2022-09-17 Thread Tom Lane
Peter Geoghegan writes: > Harmonize reorderbuffer parameter names. I'm confused about this, because it didn't fix the (ahem) poster-child case? -extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn); -extern void ReorderBufferCommitChild(Reor

pgsql: Harmonize reorderbuffer parameter names.

2022-09-17 Thread Peter Geoghegan
Harmonize reorderbuffer parameter names. Make reorderbuffer.h function declarations consistently use named parameters. Also make sure that the declarations use names that match corresponding names from function definitions in reorderbuffer.c. This makes the definitions easier to follow, especial

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Make check_usermap() parameter names consistent.

2022-09-17 Thread Peter Geoghegan
Make check_usermap() parameter names consistent. The function has a bool argument named "case_insensitive", but that was spelled "case_sensitive" in the declaration. Make them consistent now to avoid confusion in the future. Author: Peter Geoghegan Reviewed-By: Michael Paquiër Discussion: htt

pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c

2022-09-17 Thread Andres Freund
Include c.h instead of postgres.h in src/port/*p{read,write}*.c Frontend code shouldn't include postgres.h. Some files in src/port/ need to include postgres.h/postgres_fe.h, but these files don't. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Backpatch: 12-,

pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c

2022-09-17 Thread Andres Freund
Include c.h instead of postgres.h in src/port/*p{read,write}*.c Frontend code shouldn't include postgres.h. Some files in src/port/ need to include postgres.h/postgres_fe.h, but these files don't. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Backpatch: 12-,

pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c

2022-09-17 Thread Andres Freund
Include c.h instead of postgres.h in src/port/*p{read,write}*.c Frontend code shouldn't include postgres.h. Some files in src/port/ need to include postgres.h/postgres_fe.h, but these files don't. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Backpatch: 12-,

pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c

2022-09-17 Thread Andres Freund
Include c.h instead of postgres.h in src/port/*p{read,write}*.c Frontend code shouldn't include postgres.h. Some files in src/port/ need to include postgres.h/postgres_fe.h, but these files don't. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Backpatch: 12-,

pgsql: Include c.h instead of postgres.h in src/port/*p{read,write}*.c

2022-09-17 Thread Andres Freund
Include c.h instead of postgres.h in src/port/*p{read,write}*.c Frontend code shouldn't include postgres.h. Some files in src/port/ need to include postgres.h/postgres_fe.h, but these files don't. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Backpatch: 12-,

pgsql: Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in

2022-09-17 Thread Andres Freund
Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in We got rid of the need for them in 4f5f485d10c and 846e91e0223. Discussion: https://postgr.es/m/20220915022626.5xx3ccgkzpkqw...@awork3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8d513a6b7

pgsql: pgstat: Create memory contexts below TopMemoryContext

2022-09-17 Thread Andres Freund
pgstat: Create memory contexts below TopMemoryContext So far they were created below CacheMemoryContext. However, that's not guaranteed to exist in all situations, leading to memory contexts created as top-level contexts. There isn't actually a good reason anymore to create them below CacheMemoryC

pgsql: pgstat: Create memory contexts below TopMemoryContext

2022-09-17 Thread Andres Freund
pgstat: Create memory contexts below TopMemoryContext So far they were created below CacheMemoryContext. However, that's not guaranteed to exist in all situations, leading to memory contexts created as top-level contexts. There isn't actually a good reason anymore to create them below CacheMemoryC

Re: pgsql: Fix createdb tests for C locale

2022-09-17 Thread Tom Lane
Christoph Berg writes: > This seems to have broken 15 on apt.pg.o/Debian: Fails on RHEL8 too, if LANG=C. OK if LANG=C.utf8. (The lack of buildfarm complaints is distressing. Apparently our coverage of ICU is very thin.) regards, tom lane

Re: pgsql: Fix createdb tests for C locale

2022-09-17 Thread Christoph Berg
Re: Peter Eisentraut > Fix createdb tests for C locale > > If the createdb tests run under the C locale, the database cluster > will be initialized with encoding SQL_ASCII. With the checks added in > c7db01e325a530ec38ec7ba57cd3ed32e123e33c, this will cause several > ICU-related tests to fail bec