pgsql: Standardize format for printing PIDs

2022-10-13 Thread Peter Eisentraut
Standardize format for printing PIDs Most code prints PIDs as %d, but some code tried to print them as long or unsigned long. While this is in theory allowed, the fact that PIDs fit into int is deeply baked into all PostgreSQL code, so these random deviations don't accomplish anything except conf

pgsql: doc: Correct type of bgw_notify_pid

2022-10-13 Thread Peter Eisentraut
doc: Correct type of bgw_notify_pid This has apparently been wrong since the beginning (090d0f2050647958865cb495dff74af7257d2bb4). Discussion: https://www.postgresql.org/message-id/289c2e45-c7d9-5ce4-7eff-a9e2a33e1...@enterprisedb.com Branch -- master Details --- https://git.postgresql

pgsql: Fix incorrect comment regarding command completion tags

2022-10-13 Thread David Rowley
Fix incorrect comment regarding command completion tags The comment talked about some Asserts which did not exist and also a variable name which seems to have long since disappeared. Rewrite the comment in a way that will hopefully stand the test of time and inform people why we always write "INS

pgsql: Remove redundant memset call following palloc0

2022-10-13 Thread Daniel Gustafsson
Remove redundant memset call following palloc0 This is a follow-up commit to ca7f8e2 which removed the allocation abstraction from pgcrypto and replaced px_alloc + memset calls with palloc0 calls. The particular memset in this commit was missed in that work though. Author: Zhihong Yu Reviewed-by

pgsql: pg_buffercache: Add pg_buffercache_summary()

2022-10-13 Thread Andres Freund
pg_buffercache: Add pg_buffercache_summary() Using pg_buffercache_summary() is significantly cheaper than querying pg_buffercache and summarizing in SQL. Author: Melih Mutlu Reviewed-by: Andres Freund Reviewed-by: Aleksander Alekseev Reviewed-by: Zhang Mingli Discussion: https://postgr.es/m/

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_13_STABLE Details --- https

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_11_STABLE Details --- https

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_15_STABLE Details --- https

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_10_STABLE Details --- https

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_14_STABLE Details --- https

pgsql: Fix typo in CREATE PUBLICATION reference page

2022-10-13 Thread Alvaro Herrera
Fix typo in CREATE PUBLICATION reference page While at it, simplify wording a bit. Author: Takamichi Osumi Reviewed-by: Peter Smith Discussion: https://postgr.es/m/tycpr01mb8373f93f5d094a2be648990ded...@tycpr01mb8373.jpnprd01.prod.outlook.com Branch -- REL_12_STABLE Details --- https

pgsql: Put tests of md5() function into separate test file

2022-10-13 Thread Peter Eisentraut
Put tests of md5() function into separate test file In FIPS mode, these calls will fail. By having them in a separate file, it would make it easier to have an alternative output file or selectively disable these tests. This isn't done here; this is just some preparation. Reviewed-by: Michael Pa

pgsql: Allow batch insertion during COPY into a foreign table.

2022-10-13 Thread Etsuro Fujita
Allow batch insertion during COPY into a foreign table. Commit 3d956d956 allowed the COPY, but it's done by inserting individual rows to the foreign table, so it can be inefficient due to the overhead caused by each round-trip to the foreign server. To improve performance of the COPY in such a ca

pgsql: Add missing isolation test for test_decoding in meson build

2022-10-13 Thread Michael Paquier
Add missing isolation test for test_decoding in meson build Oversight in 7f13ac8, where catalog_change_snapshot was missing from the list in meson.build. Author: Hayato Kuroda Discussion: https://postgr.es/m/tyapr01mb58662c932f45a13c6f9be352f5...@tyapr01mb5866.jpnprd01.prod.outlook.com Branch -