pgsql: Fix typo in hba.c

2022-11-25 Thread Michael Paquier
Fix typo in hba.c Spotted while reading through the git history. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/02ac05b4c0229bd662b3afa07f370df0a5cbdb54 Modified Files -- src/backend/libpq/hba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 18:56:02 -0500, Andrew Dunstan wrote: > On 2022-11-25 Fr 18:48, Andres Freund wrote: > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > >> #define __builtin_expect(expr, val) (expr) > > And it

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
On 2022-11-25 Fr 18:48, Andres Freund wrote: > Hi, > > On 2022-11-25 15:33:31 -0800, Andres Freund wrote: >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with >> #define __builtin_expect(expr, val) (expr) > And it does so with src/tools/msvc as well. I think we might

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 15:33:31 -0800, Andres Freund wrote: > FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with > #define __builtin_expect(expr, val) (expr) And it does so with src/tools/msvc as well. I think we might need a preprocessed plperl.c from drongo to analyze this

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andres Freund
Hi, On 2022-11-25 17:11:51 -0500, Andrew Dunstan wrote: > On 2022-11-25 Fr 15:38, Andrew Dunstan wrote: > > Allow building with MSVC and Strawberry perl > > > > Strawberry uses __builtin_expect which Visual C doesn't have. For this > > case define it as a noop. Solution taken from vim sources.

Re: pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
On 2022-11-25 Fr 15:38, Andrew Dunstan wrote: > Allow building with MSVC and Strawberry perl > > Strawberry uses __builtin_expect which Visual C doesn't have. For this > case define it as a noop. Solution taken from vim sources. Argh! drongo doesn't seem to like this. I thought I'd tested it.

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_11_STABLE Details ---

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_12_STABLE Details ---

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- master Details ---

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_14_STABLE Details ---

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_15_STABLE Details ---

pgsql: Allow building with MSVC and Strawberry perl

2022-11-25 Thread Andrew Dunstan
Allow building with MSVC and Strawberry perl Strawberry uses __builtin_expect which Visual C doesn't have. For this case define it as a noop. Solution taken from vim sources. Backpatch to all live branches Branch -- REL_13_STABLE Details ---

pgsql: Correct some SQL feature names

2022-11-25 Thread Peter Eisentraut
Correct some SQL feature names Maybe these were initially typos or they have been changed upstream since we first added them. This brings it all in line with SQL:2016. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d94f29cb8910a380caa795f56e69ed036fb8c5d0

Re: pgsql: Expand AclMode to 64 bits

2022-11-25 Thread Andrew Dunstan
On 2022-11-25 Fr 01:52, Amit Langote wrote: > Hi Andrew, > > On Thu, Nov 24, 2022 at 10:18 AM Andrew Dunstan wrote: >> On 2022-11-23 We 19:40, Michael Paquier wrote: >>> Hi Andrew, >>> >>> On Wed, Nov 23, 2022 at 07:44:04PM +, Andrew Dunstan wrote: Expand AclMode to 64 bits

pgsql: Fix gen_node_support.pl for changed AclMode size

2022-11-25 Thread Andrew Dunstan
Fix gen_node_support.pl for changed AclMode size omitted from 7b378237aa, mea culpa. Complaint and fix from Amit Langote. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/50617a9aa37344c2dbc89dba0a2193723202e7aa Modified Files --

pgsql: Fix rule-detection code for MERGE.

2022-11-25 Thread Dean Rasheed
Fix rule-detection code for MERGE. Use the relation's rd_rules structure to test whether it has rules, rather than the relhasrules flag, which might be out of date. Reviewed by Tom Lane. Backpatch to 15, where MERGE was added. Discussion:

pgsql: Fix rule-detection code for MERGE.

2022-11-25 Thread Dean Rasheed
Fix rule-detection code for MERGE. Use the relation's rd_rules structure to test whether it has rules, rather than the relhasrules flag, which might be out of date. Reviewed by Tom Lane. Backpatch to 15, where MERGE was added. Discussion:

pgsql: doc: Re-order Table 28.35 "Per-Backend Statistics Functions"

2022-11-25 Thread Peter Eisentraut
doc: Re-order Table 28.35 "Per-Backend Statistics Functions" The overall order is alphabetic, but there were a few additions that didn't observe this. Author: Peter Smith Reviewed-by: David G. Johnston Discussion:

pgsql: doc: Re-order Table 28.12 "Wait Events of type LWLock"

2022-11-25 Thread Peter Eisentraut
doc: Re-order Table 28.12 "Wait Events of type LWLock" The overall order is alphabetic, but there were a few additions that didn't observe this. Author: Peter Smith Reviewed-by: David G. Johnston Discussion:

pgsql: doc: Re-order sections of "28.4. Progress Reporting"

2022-11-25 Thread Peter Eisentraut
doc: Re-order sections of "28.4. Progress Reporting" BEFORE 28.4.1. ANALYZE Progress Reporting 28.4.2. CREATE INDEX Progress Reporting 28.4.3. VACUUM Progress Reporting 28.4.4. CLUSTER Progress Reporting 28.4.5. Base Backup Progress Reporting 28.4.6. COPY Progress Reporting AFTER 28.4.1. ANALYZE

pgsql: Fix handling of pending inserts in nodeModifyTable.c.

2022-11-25 Thread Etsuro Fujita
Fix handling of pending inserts in nodeModifyTable.c. Commit b663a4136, which allowed FDWs to INSERT rows in bulk, added to nodeModifyTable.c code to flush pending inserts to the foreign-table result relation(s) before completing processing of the ModifyTable node, but the code failed to take

pgsql: Fix handling of pending inserts in nodeModifyTable.c.

2022-11-25 Thread Etsuro Fujita
Fix handling of pending inserts in nodeModifyTable.c. Commit b663a4136, which allowed FDWs to INSERT rows in bulk, added to nodeModifyTable.c code to flush pending inserts to the foreign-table result relation(s) before completing processing of the ModifyTable node, but the code failed to take

pgsql: Fix handling of pending inserts in nodeModifyTable.c.

2022-11-25 Thread Etsuro Fujita
Fix handling of pending inserts in nodeModifyTable.c. Commit b663a4136, which allowed FDWs to INSERT rows in bulk, added to nodeModifyTable.c code to flush pending inserts to the foreign-table result relation(s) before completing processing of the ModifyTable node, but the code failed to take