pgsql: Fix incorrect format placeholders

2023-03-09 Thread Peter Eisentraut
Fix incorrect format placeholders Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/470103697a17c4df516f9779fd3ff7f7c32d3cc5 Modified Files -- src/backend/jit/llvm/llvmjit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: pgsql: Use ICU by default at initdb time.

2023-03-09 Thread Jeff Davis
On Thu, 2023-03-09 at 19:11 +, Jeff Davis wrote: > Use ICU by default at initdb time. I'm seeing a failure on hoverfly: https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=hoverfly&dt=2023-03-09%2021%3A51%3A45&stg=initdb-en_US.8859-15 That's because ICU always uses UTF-8 by default

pgsql: pg_walinspect: pg_get_wal_fpi_info() -> pg_get_wal_block_info()

2023-03-09 Thread Michael Paquier
pg_walinspect: pg_get_wal_fpi_info() -> pg_get_wal_block_info() This commit reworks pg_get_wal_fpi_info() to become aware of all the block information that can be attached to a record rather than just its full-page writes: - Addition of the block id as assigned by XLogRegisterBuffer(), XLogRegiste

pgsql: Fix test failure caused in 27b62377b4.

2023-03-09 Thread Jeff Davis
Fix test failure caused in 27b62377b4. Per buildfarm system "prion". Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8da2ec31eee432d6e51c50c3d73f88e81dede193 Modified Files -- src/bin/initdb/t/001_initdb.pl | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: pgsql: pg_upgrade: copy locale and encoding information to new cluster.

2023-03-09 Thread Andrew Dunstan
On 2023-03-09 Th 17:21, Jeff Davis wrote: On Thu, 2023-03-09 at 09:35 -0800, Jeff Davis wrote: On Thu, 2023-03-09 at 12:21 -0500, Andrew Dunstan wrote: This looks like it broke cross version upgrade testing. Old versions don't have datlocprovider. Thank you, fixing. Just waiting for some CI t

Re: pgsql: pg_upgrade: copy locale and encoding information to new cluster.

2023-03-09 Thread Jeff Davis
On Thu, 2023-03-09 at 09:35 -0800, Jeff Davis wrote: > On Thu, 2023-03-09 at 12:21 -0500, Andrew Dunstan wrote: > > This looks like it broke cross version upgrade testing. Old > > versions > > don't have datlocprovider. > > Thank you, fixing. Just waiting for some CI tests. I fixed most of the pr

pgsql: Reject combining "epoch" and "infinity" with other datetime fiel

2023-03-09 Thread Tom Lane
Reject combining "epoch" and "infinity" with other datetime fields. Datetime input formerly accepted combinations such as '1995-08-06 infinity', but this seems like a clear error. Reject any combination of regular y/m/d/h/m/s fields with these special tokens. Joseph Koshakow, reviewed by Keisuke

pgsql: Use ICU by default at initdb time.

2023-03-09 Thread Jeff Davis
Use ICU by default at initdb time. If the ICU locale is not specified, initialize the default collator and retrieve the locale name from that. Discussion: https://postgr.es/m/510d284759f6e943ce15096167760b2edcb2e700.ca...@j-davis.com Reviewed-by: Peter Eisentraut Branch -- master Details -

pgsql: HTML docs: Add padding to table.simplelist for more readable out

2023-03-09 Thread Alvaro Herrera
HTML docs: Add padding to table.simplelist for more readable output This couples with a to-be-pushed pgweb patch to synchronize the other stylesheet under which these docs are rendered on the website. Author: Karl Pinc Discussion: https://postgr.es/m/20230122144246.0ff87...@slate.karlpinc.com B

pgsql: Fix 9637badd9f.

2023-03-09 Thread Jeff Davis
Fix 9637badd9f. Discussion: https://postgr.es/m/0a364430-266e-1e1a-d5d8-1a5273c9d...@dunslane.net Reported-by: Andrew Dunstan Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/206b44bb24b3785bf6360361b757c1dae77ab0bb Modified Files -- src/bin/pg_upgrade/

Re: pgsql: pg_upgrade: copy locale and encoding information to new cluster.

2023-03-09 Thread Jeff Davis
On Thu, 2023-03-09 at 12:21 -0500, Andrew Dunstan wrote: > This looks like it broke cross version upgrade testing. Old versions > don't have datlocprovider. Thank you, fixing. Just waiting for some CI tests. Regards, Jeff Davis

Re: pgsql: pg_upgrade: copy locale and encoding information to new cluster.

2023-03-09 Thread Andrew Dunstan
On 2023-03-09 Th 11:40, Jeff Davis wrote: pg_upgrade: copy locale and encoding information to new cluster. Previously, pg_upgrade checked that the old and new clusters were compatible, including the locale and encoding. But the new cluster was just created, and only template0 from the new clust

pgsql: pg_upgrade: copy locale and encoding information to new cluster.

2023-03-09 Thread Jeff Davis
pg_upgrade: copy locale and encoding information to new cluster. Previously, pg_upgrade checked that the old and new clusters were compatible, including the locale and encoding. But the new cluster was just created, and only template0 from the new cluster will be preserved (template1 and postgres

pgsql: For Kerberos testing, disable reverse DNS lookup

2023-03-09 Thread Stephen Frost
For Kerberos testing, disable reverse DNS lookup In our Kerberos test suite, there isn't much need to worry about the normal canonicalization that Kerberos provides by looking up the reverse DNS for the IP address connected to, and in some cases it can actively cause problems (eg: a captive portal

Re: pgsql: 001_libpq_pipeline.pl: use Test::Differences if available

2023-03-09 Thread Alvaro Herrera
On 2023-Mar-09, Alvaro Herrera wrote: > On 2023-Mar-08, Andrew Dunstan wrote: > > > something like this should do the trick: > > > > > >    eval { require Test::Differences; Test::Differences->import; > > unified_diff; 1; }; > > > >    *eq_or_diff = \&is if $@; > > Hmm, I just grabbed the cod

pgsql: Avoid criticizable perl code

2023-03-09 Thread Alvaro Herrera
Avoid criticizable perl code Using `require` / `->import` instead of `use` avoids the use of a "stringy eval", making for cleaner code that we don't need to silence perlcritic about. Per Andrew Dunstan Discussion: https://postgr.es/m/7cd3bbbd-0216-4436-d571-8f80c9259...@dunslane.net Branch ---

Re: pgsql: Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connec

2023-03-09 Thread Michael Paquier
On Thu, Mar 09, 2023 at 10:34:12AM +0100, Alvaro Herrera wrote: > Please add this commit to .git-blame-ignore-revs. Thanks, done. -- Michael signature.asc Description: PGP signature

pgsql: Add b6dfee28 to .git-blame-ignore-revs

2023-03-09 Thread Michael Paquier
Add b6dfee28 to .git-blame-ignore-revs Thanks to Álvaro Herrera for the poke. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d00a4ad1d56bbdbc032257803c0a97a583aec211 Modified Files -- .git-blame-ignore-revs | 3 +++ 1 file changed, 3 insertions(+)

Re: pgsql: 001_libpq_pipeline.pl: use Test::Differences if available

2023-03-09 Thread Alvaro Herrera
On 2023-Mar-08, Andrew Dunstan wrote: > I don't think you need a stringy eval here, and they are something to be > avoided in general. If you use `require` instead of `use` it should be > unnecessary, and you can avoid all the perltidy ugliness. > > something like this should do the trick: > >

Re: pgsql: Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connec

2023-03-09 Thread Alvaro Herrera
On 2023-Mar-09, Michael Paquier wrote: > Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connect.c Please add this commit to .git-blame-ignore-revs. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "Having your biases confirmed independently is how sci

pgsql: Improve/correct comments

2023-03-09 Thread Peter Eisentraut
Improve/correct comments Change comments for pg_cryptohash_init(), pg_cryptohash_update(), pg_cryptohash_final() in cryptohash.c to match cryptohash_openssl.c. In particular, the claim that these functions were "designed" to never fail was incorrect, since by design callers need to be prepared to