pgsql: cirrus/ccache: Use G rather than GB suffix

2023-03-12 Thread Peter Eisentraut
cirrus/ccache: Use G rather than GB suffix The former being the documented spelling. Author: Justin Pryzby Discussion: https://www.postgresql.org/message-id/20230203142656.GA1653%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bf32ec225635cbdf15b1

pgsql: meson: Make auto the default of the ssl option

2023-03-12 Thread Peter Eisentraut
meson: Make auto the default of the ssl option The 'ssl' option is of type 'combo', but we add a choice 'auto' that simulates the behavior of a feature option. This way, openssl is used automatically by default if present, but we retain the ability to potentially select another ssl library. Auth

pgsql: Refactor and improve tests of pg_walinspect

2023-03-12 Thread Michael Paquier
Refactor and improve tests of pg_walinspect The regression tests of pg_walinspect are reworked on a few aspects: - Reorganization on the validation checks done for the start and end LSNs on the six SQL functions currently available in 1.1. - Addition of a few patterns doing bound checks for invali

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Thomas Munro
On Mon, Mar 13, 2023 at 9:10 AM Tom Lane wrote: > Andrew Dunstan writes: > > On 2023-03-11 Sa 15:47, Tom Lane wrote: > >> In general, I see no good reason for our regression tests to be making > >> assumptions about exactly how ICU's root locale behaves, so I'd suggest > >> just lobotomizing this

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Tom Lane
Andrew Dunstan writes: > On 2023-03-11 Sa 15:47, Tom Lane wrote: >> In general, I see no good reason for our regression tests to be making >> assumptions about exactly how ICU's root locale behaves, so I'd suggest >> just lobotomizing this test case so it doesn't depend on upper/lower >> sort orde

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Andrew Dunstan
On 2023-03-11 Sa 15:47, Tom Lane wrote: Jeff Davis writes: On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: It's fairly old: $ rpm -q -a | grep icu  libicu-50.2-4.0.amzn1.x86_64  libicu-devel-50.2-4.0.amzn1.x86_64 FWIW I tried ICU 50.2 (built from sources) and the root locale still

pgsql: Work around implementation restriction in adjust_appendrel_attrs

2023-03-12 Thread Tom Lane
Work around implementation restriction in adjust_appendrel_attrs. adjust_appendrel_attrs can't transfer nullingrel labeling to a non-Var translation expression (mainly because it's too late to wrap such an expression in a PlaceHolderVar). I'd supposed in commit 2489d76c4 that that restriction was

Re: pgsql: Add standard collation UNICODE

2023-03-12 Thread Andrew Dunstan
On 2023-03-11 Sa 17:05, Andres Freund wrote: Hi, On 2023-03-11 10:20:33 -0800, Jeff Davis wrote: On Sat, 2023-03-11 at 08:31 -0500, Andrew Dunstan wrote: It's fairly old: $ rpm -q -a | grep icu  libicu-50.2-4.0.amzn1.x86_64  libicu-devel-50.2-4.0.amzn1.x86_64 FWIW I tried ICU 50.2 (built

pgsql: Mark unsafe_tests module as not runnable with installcheck

2023-03-12 Thread Andrew Dunstan
Mark unsafe_tests module as not runnable with installcheck This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/

pgsql: Mark unsafe_tests module as not runnable with installcheck

2023-03-12 Thread Andrew Dunstan
Mark unsafe_tests module as not runnable with installcheck This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/

pgsql: Mark unsafe_tests module as not runnable with installcheck

2023-03-12 Thread Andrew Dunstan
Mark unsafe_tests module as not runnable with installcheck This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/

pgsql: Mark unsafe_tests module as not runnable with installcheck

2023-03-12 Thread Andrew Dunstan
Mark unsafe_tests module as not runnable with installcheck This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/

pgsql: Mark unsafe_tests module as not runnable with installcheck

2023-03-12 Thread Andrew Dunstan
Mark unsafe_tests module as not runnable with installcheck This was an omission in the original creation of the module. Also slightly adjust some wording to avoid a double "is". Backpatch the non-meson piece of this to release 12, where the module was introduced. Discussion: https://postgr.es/