pgsql: Doc: fix examples for pg_input_error_info().

2023-03-24 Thread Tom Lane
Doc: fix examples for pg_input_error_info(). These were causing "contents ... exceed the available area" warnings in PDF builds, and also didn't quite follow our markup conventions for function examples. To fix the overwidth problem, reduce the number of fields shown in one example, and also

pgsql: docs: Explain how to silence overly verbose messages by fop

2023-03-24 Thread Andres Freund
docs: Explain how to silence overly verbose messages by fop Reviewed-by: Tom Lane Discussion: https://postgr.es/m/20230324194701.dqkzcdtlcikse...@awork3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/642d8779768ecddc2917747940885d11f844f6e9 Modified

pgsql: Invent GENERIC_PLAN option for EXPLAIN.

2023-03-24 Thread Tom Lane
Invent GENERIC_PLAN option for EXPLAIN. This provides a very simple way to see the generic plan for a parameterized query. Without this, it's necessary to define a prepared statement and temporarily change plan_cache_mode, which is a bit tedious. One thing that's a bit of a hack perhaps is that

Re: pgsql: Handle the "und" locale in ICU versions 54 and older.

2023-03-24 Thread Jeff Davis
On Thu, 2023-03-23 at 13:25 -0400, Tom Lane wrote: > Hmm, should we back-patch this?  Seems like existing branches would > be even more at risk than v16, because more likely to be built with > old ICU.  OTOH, we do also run the risk of breaking installations > that weren't broken before. I

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-24 Thread Andres Freund
Hi, On 2023-03-24 09:21:40 -0400, Andrew Dunstan wrote: > On 2023-03-24 Fr 00:30, Andres Freund wrote: > > meson: add install-{quiet, world} targets > > > > To define our own install target, we need dependencies on the i18n targets, > > which we did not collect so far. > > > >

pgsql: meson: Fix oversight in install-quiet

2023-03-24 Thread Andres Freund
meson: Fix oversight in install-quiet In e522049f239 I accidentally forgot to add meson_bin to the argument list for install-quiet. That kind of works on some platforms because the executable is just 'python', wich the path to meson in an argument. But on windows meson might be installed as an

pgsql: pg_locale.c: change ereport() to elog().

2023-03-24 Thread Jeff Davis
pg_locale.c: change ereport() to elog(). Discussion: https://postgr.es/m/73553013-3926-0f34-0fb8-f37909fe4...@enterprisedb.com Reported-by: Peter Eisentraut Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a242899158c776377696d445df74db270150385 Modified Files

pgsql: Avoid potential UCollator leak for older ICU versions.

2023-03-24 Thread Jeff Davis
Avoid potential UCollator leak for older ICU versions. ICU versions 53 and earlier rely on icu_set_collation_attributes() to process the attributes in the locale string. Avoid leaking the already-opened UCollator object if an error is encountered. Discussion:

pgsql: amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

2023-03-24 Thread Robert Haas
amcheck: Fix verify_heapam for tuples where xmin or xmax is 0. In such cases, get_xid_status() doesn't set its output parameter (the third argument), so we shouldn't fall through to code which will test the value of that parameter. There are five existing calls to get_xid_status(), three of which

pgsql: amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

2023-03-24 Thread Robert Haas
amcheck: Fix verify_heapam for tuples where xmin or xmax is 0. In such cases, get_xid_status() doesn't set its output parameter (the third argument), so we shouldn't fall through to code which will test the value of that parameter. There are five existing calls to get_xid_status(), three of which

pgsql: amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

2023-03-24 Thread Robert Haas
amcheck: Fix verify_heapam for tuples where xmin or xmax is 0. In such cases, get_xid_status() doesn't set its output parameter (the third argument), so we shouldn't fall through to code which will test the value of that parameter. There are five existing calls to get_xid_status(), three of which

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-24 Thread Andrew Dunstan
On 2023-03-24 Fr 00:30, Andres Freund wrote: meson: add install-{quiet, world} targets To define our own install target, we need dependencies on the i18n targets, which we did not collect so far. Discussion:https://postgr.es/m/3fc3bb9b-f7f8-d442-35c1-ec82280c5...@enterprisedb.com For some

pgsql: Fix typo in header comment

2023-03-24 Thread Daniel Gustafsson
Fix typo in header comment Commit 4c04be9b0 accidentally left off the _id portion of the function name in the header comment. Author: Junwang Zhao Discussion: https://postgr.es/m/CAEG8a3LP+ytnAXSzR=yiEaQrde+iCybMHsuPn9n=un3puv_...@mail.gmail.com Branch -- master Details ---

pgsql: Fix incorrect format placeholders

2023-03-24 Thread Peter Eisentraut
Fix incorrect format placeholders The fields of NLSVERSIONINFOEX are of type DWORD, which is unsigned long, so the results of the computations being printed are also of type unsigned long. Branch -- master Details ---

pgsql: meson: docs: add texinfo target

2023-03-24 Thread Andres Freund
meson: docs: add texinfo target Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/069ef254f145889d15c6ce4be526ce9e05284dc6 Modified Files -- doc/src/sgml/meson.build | 33 + 1 file changed, 33 insertions(+)