Re: pgsql: amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

2023-03-25 Thread Peter Geoghegan
On Fri, Mar 24, 2023 at 8:13 AM Robert Haas wrote: > If we're checking xmin and find that it is invalid (i.e. 0) just > report that as corruption, similar to what's already done in the > three cases that seem correct. If we're checking xmax and find > that's invalid, that's fine: it just means tha

pgsql: Add SysCacheGetAttrNotNull for guaranteed not-null attrs

2023-03-25 Thread Daniel Gustafsson
Add SysCacheGetAttrNotNull for guaranteed not-null attrs When extracting an attr from a cached tuple in the syscache with SysCacheGetAttr the isnull parameter must be checked in case the attr cannot be NULL. For cases when this is known beforehand, a wrapper is introduced which perform the errorh

pgsql: Comment on expectations for AutoVacuumWorkItem handlers.

2023-03-25 Thread Noah Misch
Comment on expectations for AutoVacuumWorkItem handlers. This might prevent a repeat of the brin_summarize_range() vulnerability that commit a117cebd638dd02e5c2e791c25e43745f233111b fixed. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e33967b13bbc6e4e1c1b5e9ecd1c4

pgsql: Fix CREATE INDEX progress reporting for multi-level partitioning

2023-03-25 Thread Tom Lane
Fix CREATE INDEX progress reporting for multi-level partitioning. The "partitions_total" and "partitions_done" fields were updated as though the current level of partitioning was the only one. In multi-level cases, not only could partitions_total change over the course of the command, but partitio

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-25 Thread Andres Freund
Hi, On 2023-03-25 13:05:19 -0500, Justin Pryzby wrote: > On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote: > > Hi, > > > > On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote: > > > On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote: > > > > meson: add install-{quiet, world}

pgsql: Fix abbreviated keys bug introduced in d87d548cd03.

2023-03-25 Thread Jeff Davis
Fix abbreviated keys bug introduced in d87d548cd03. Discussion: http://postgr.es/m/CAMkU=1z17xjatf-rmcy3cjqcxer-kyn57x6h3oscpj0lpap...@mail.gmail.com Reported-by: Jeff Janes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/81a6d57e33515958203938cb686bf0c255255cff M

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-25 Thread Justin Pryzby
On Sat, Mar 25, 2023 at 11:03:10AM -0700, Andres Freund wrote: > Hi, > > On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote: > > On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote: > > > meson: add install-{quiet, world} targets > > > > if docs.length() == 0 > >run_target('docs', c

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-25 Thread Andres Freund
Hi, On 2023-03-25 12:51:32 -0500, Justin Pryzby wrote: > On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote: > > meson: add install-{quiet, world} targets > > if docs.length() == 0 >run_target('docs', command: [missing, 'xsltproc']) > else >alias_target('docs', docs) > + ali

Re: pgsql: meson: add install-{quiet, world} targets

2023-03-25 Thread Justin Pryzby
On Fri, Mar 24, 2023 at 04:30:52AM +, Andres Freund wrote: > meson: add install-{quiet, world} targets if docs.length() == 0 run_target('docs', command: [missing, 'xsltproc']) else alias_target('docs', docs) + alias_target('install-docs', installdocs) endif This fails to handle inst

pgsql: Doc: fix another "contents...exceed the available area" PDF warn

2023-03-25 Thread Tom Lane
Doc: fix another "contents...exceed the available area" PDF warning. New since yesterday :-( Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f34a89353156ada8c75963b8089df11a493512cd Modified Files -- doc/src/sgml/docguide.sgml | 2 +- 1 file changed, 1 i