pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: Fix incorrect partition pruning logic for boolean partitioned ta

2023-04-13 Thread David Rowley
Fix incorrect partition pruning logic for boolean partitioned tables The partition pruning logic assumed that "b IS NOT true" was exactly the same as "b IS FALSE". This is not the case when considering NULL values. Fix this so we correctly include any partition which could hold NULL values for th

pgsql: doc: Fix some grammar for logical decoding description and funct

2023-04-13 Thread Michael Paquier
doc: Fix some grammar for logical decoding description and functions This documentation is has been added for the support of logical decoding on standbys. Some markups were missing, hence add some where required. Author: Thom Brown Reviewed-by: Justin Pryzby, Daniel Gustafsson Discussion: https

pgsql: Fix PHJ match bit initialization.

2023-04-13 Thread Thomas Munro
Fix PHJ match bit initialization. Hash join tuples reuse the HOT status bit to indicate match status during hash join execution. Correct reuse requires clearing the bit in all tuples. Serial hash join and parallel multi-batch hash join do so upon inserting the tuple into the hashtable. Single batc

pgsql: Remove code in charge of freeing regexps generation by Lab.c

2023-04-13 Thread Michael Paquier
Remove code in charge of freeing regexps generation by Lab.c bea3d7e has redesigned the regexp engine so as all the allocations go through palloc() with a dedicated memory context. hba.c had to cope with the past memory management logic by going through all the HBA and ident lines generated, then

pgsql: Remove old GUC name mapping for "force_parallel_mode"

2023-04-13 Thread David Rowley
Remove old GUC name mapping for "force_parallel_mode" This GUC was renamed to debug_parallel_query in 5352ca22e. That commit added an entry into map_old_guc_names[] to allow the old name still to work. That was done to allow a transition time where the buildfarm configs could be swapped over to

pgsql: Update Unicode data to CLDR 43

2023-04-13 Thread Peter Eisentraut
Update Unicode data to CLDR 43 No actual changes result. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/83c470665822befb3bda92320defe766936b60df Modified Files -- src/Makefile.global.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Harmonize some more function parameter names.

2023-04-13 Thread Peter Geoghegan
Harmonize some more function parameter names. Make sure that function declarations use names that exactly match the corresponding names from function definitions in a few places. These inconsistencies were all introduced relatively recently, after the code base had parameter name mismatches fixed

Re: pgsql: Allow logical decoding on standbys

2023-04-13 Thread Robert Haas
On Wed, Apr 12, 2023 at 1:43 PM Andres Freund wrote: > > And, a nearby commit addds the following message. > > > > + appendStringInfo(&err_detail, _("Logical decoding on > > standby requires wal_level to be at least logical on the primary server")); > > > > This is omitting th

pgsql: Add MacPorts support to src/test/ldap tests.

2023-04-13 Thread Tom Lane
Add MacPorts support to src/test/ldap tests. Previously the test knew how to find an OpenLDAP installation at the paths used by Homebrew. Add the MacPorts paths too. This back-patches the v12-era commit aa1419e63 into v11, in preparation for spinning up a buildfarm animal that requires it. Auth

pgsql: De-Revert "Add support for Kerberos credential delegation"

2023-04-13 Thread Stephen Frost
De-Revert "Add support for Kerberos credential delegation" This reverts commit 3d03b24c3 (Revert Add support for Kerberos credential delegation) which was committed on the grounds of concern about portability, but on further review and discussion, it's clear that we are better off explicitly requi

pgsql: Explicitly require MIT Kerberos for GSSAPI

2023-04-13 Thread Stephen Frost
Explicitly require MIT Kerberos for GSSAPI WHen building with GSSAPI support, explicitly require MIT Kerberos and check for gssapi_ext.h in configure.ac and meson.build. Also add documentation explicitly stating that we now require MIT Kerberos when building with GSSAPI support. Reveiwed by: Joh

pgsql: doc: Make HTML ids discoverable

2023-04-13 Thread Peter Eisentraut
doc: Make HTML ids discoverable In the HTML output, this decorates section headers and variable list terms with a marker ("#") that is a link to the same section/term. That way, links inside a page can be discovered for easier sharing. The marker only appears when hovering. This now requires that

Re: pgsql: Allow logical decoding on standbys

2023-04-13 Thread Kyotaro Horiguchi
At Wed, 12 Apr 2023 11:10:00 -0700, Andres Freund wrote in > Hi, > > On 2023-04-12 10:42:44 -0700, Andres Freund wrote: > > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote: > > > > Allow logical decoding on standbys > > > > > > This adds the following error message. > > > > > > + errmsg(

pgsql: Add missing XML ID attribute

2023-04-13 Thread Peter Eisentraut
Add missing XML ID attribute Discussion: https://www.postgresql.org/message-id/dc813a6f-60d9-991f-eecd-675a0921d...@gmx.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a34901dd03edb473ddbd81ee5c7332575f6d8881 Modified Files -- doc/src/sgml/pgbufferc