pgsql: Adjust Valgrind macro usage to protect chunk headers

2023-04-14 Thread David Rowley
Adjust Valgrind macro usage to protect chunk headers Prior to this commit we only ever protected MemoryChunk's requested_size field with Valgrind NOACCESS. This means that if the hdrmask field is ever accessed accidentally then we're not going to get any warnings from Valgrind about it. Valgrind

pgsql: Support RBM_ZERO_AND_CLEANUP_LOCK in ExtendBufferedRelTo(), add

2023-04-14 Thread Andres Freund
Support RBM_ZERO_AND_CLEANUP_LOCK in ExtendBufferedRelTo(), add tests For some reason I had not implemented RBM_ZERO_AND_CLEANUP_LOCK support in ExtendBufferedRelTo(), likely thinking it not being reachable. But it is reachable, e.g. when replaying a WAL record for a page in a relation that subseq

pgsql: NULL is not an ideal way to spell bool "false".

2023-04-14 Thread Tom Lane
NULL is not an ideal way to spell bool "false". Thinko in commit 6633cfb21, detected by buildfarm member hamerkop. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e4d905f772f7803d399b6e173ca9aa7ba8a35e5a Modified Files -- src/backend/libpq/be-secure-gss

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+

2023-04-14 Thread Daniel Gustafsson
doc: PQinitOpenSSL and PQinitSSL are obsolete in OpenSSL 1.1.0+ Starting with OpenSSL 1.1.0 there is no need to call PQinitOpenSSL or PQinitSSL to avoid duplicate initialization of OpenSSL. Add a note to the documentation to explain this. Backpatch to all supported versions as older OpenSSL vers

pgsql: Fix whitespace

2023-04-14 Thread Peter Eisentraut
Fix whitespace Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/12829058c424cba540ac8de33d129d02f8bd3449 Modified Files -- src/test/modules/ldap_password_func/Makefile | 3 --- 1 file changed, 3 deletions(-)

pgsql: Add missing source files to nls.mk

2023-04-14 Thread Peter Eisentraut
Add missing source files to nls.mk Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/99322d6eee6445665c1fb131ec6130924b7673b6 Modified Files -- src/bin/pg_dump/nls.mk | 4 src/bin/pg_rewind/nls.mk | 1 + 2 files changed, 5 insertions(+)

Re: pgsql: Allow logical decoding on standbys

2023-04-14 Thread Kyotaro Horiguchi
At Thu, 13 Apr 2023 12:07:19 -0400, Robert Haas wrote in > On Wed, Apr 12, 2023 at 1:43=E2=80=AFPM Andres Freund = > wrote: > > > And, a nearby commit addds the following message. > > > > > > + appendStringInfo(&err_detail, _("Logical decoding= > on standby requires wal_lev