pgsql: Fix copy-and-pasto in error message

2023-05-04 Thread Peter Eisentraut
Fix copy-and-pasto in error message from 2fe3bdbd69 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b1c4ed2f02b0c4cf1942e6eb2995bdbf8db5cccf Modified Files -- src/bin/pg_upgrade/option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Fix prove_installcheck when used with PGXS

2023-05-04 Thread Peter Eisentraut
Fix prove_installcheck when used with PGXS Commit 153e215677 added the portlock directory. This is created in $ENV{top_builddir} if it is set. Under PGXS, top_builddir points into the installation directory, which is not necessarily writable and in any case inappropriate to use by a test suite.

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Move return statements out of PG_TRY blocks.

2023-05-04 Thread Nathan Bossart
Move return statements out of PG_TRY blocks. If we exit a PG_TRY block early via "continue", "break", "goto", or "return", we'll skip unwinding its exception stack. This change moves a couple of such "return" statements in PL/Python out of PG_TRY blocks. This was introduced in d0aa965c0a and aff

pgsql: Fix ExecCheckPermissions call in RI_Initial_Check

2023-05-04 Thread Alvaro Herrera
Fix ExecCheckPermissions call in RI_Initial_Check RI_Initial_Check was setting up a list of RTEPermissionInfo for ExecCheckPermissions() wrong, and the problem is subtle enough that it doesn't have any immediate effect in core code. However, if an extension is using the ExecutorCheckPerms_hook, t

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: In array_position()/array_positions(), beware of empty input arr

2023-05-04 Thread Tom Lane
In array_position()/array_positions(), beware of empty input array. These functions incautiously fetched the array's first lower bound even when the array is zero-dimensional, thus fetching the word after the allocated array space. While almost always harmless, with very bad luck this could resul

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Tighten array dimensionality checks in Python -> SQL array conve

2023-05-04 Thread Tom Lane
Tighten array dimensionality checks in Python -> SQL array conversion. Like plperl before f47004add, plpython wasn't being sufficiently careful about checking that list-of-list structures represent rectangular arrays, so that it would accept some cases in which different parts of the "array" are n

pgsql: Revert "Move PartitionPruneInfo out of plan nodes into PlannedSt

2023-05-04 Thread Alvaro Herrera
Revert "Move PartitionPruneInfo out of plan nodes into PlannedStmt" This reverts commit ec386948948c and its fixup 589bb816499e. This change was intended to support query planning avoiding acquisition of locks on partitions that were going to be pruned; however, the overall project took a differe