On Sat, Jul 22, 2023 at 4:22 AM Jeff Davis wrote:
>
> On Fri, 2023-07-21 at 16:00 +, Tom Lane wrote:
> > Fix calculation of relid sets for partitionwise child joins.
>
> In CI, I'm seeing a compiler warning here:
>
> https://cirrus-ci.com/task/6112262960709632
>
> [22:28:11.772] joinrels.c: In
On Fri, 2023-07-21 at 16:00 +, Tom Lane wrote:
> Fix calculation of relid sets for partitionwise child joins.
In CI, I'm seeing a compiler warning here:
https://cirrus-ci.com/task/6112262960709632
[22:28:11.772] joinrels.c: In function ‘try_partitionwise_join’:
[22:28:11.772] joinrels.c:1546
ICU: remove negative test that fails to fail.
On OpenBSD, setlocale() does not fail on an ICU-specific
locale. Remove the test.
Reported-by: Andres Freund
Discussion:
https://postgr.es/m/20230702165615.k6waysygrefde...@awork3.anarazel.de
Branch
--
master
Details
---
https://git.postgre
Fix calculation of relid sets for partitionwise child joins.
Applying add_outer_joins_to_relids() to a child join doesn't actually
work, even if we've built a SpecialJoinInfo specialized to the child,
because that function will also compare the join's relids to elements
of the main join_info_list,
Fix calculation of relid sets for partitionwise child joins.
Applying add_outer_joins_to_relids() to a child join doesn't actually
work, even if we've built a SpecialJoinInfo specialized to the child,
because that function will also compare the join's relids to elements
of the main join_info_list,
Code review for commit b6e1157e7d
b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr. This commi
Don't include CaseTestExpr in JsonValueExpr.formatted_expr
A CaseTestExpr is currently being put into
JsonValueExpr.formatted_expr as placeholder for the result of
evaluating JsonValueExpr.raw_expr, which in turn is evaluated
separately. Though, there's no need for this indirection if
raw_expr it
