pgsql: Make more use of makeColumnDef()

2023-08-28 Thread Peter Eisentraut
Make more use of makeColumnDef() Since we already have it, we might as well make full use of it, instead of assembling ColumnDef by hand in several places. Reviewed-by: Alvaro Herrera Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e...@eisentraut.org Bra

pgsql: Add some const decorations

2023-08-28 Thread Peter Eisentraut
Add some const decorations Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e...@eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2b088c8e4a2c9879d2f37fa4b38ae925184cea64 Modified Files -- src/backend

pgsql: Initialize ListenSocket array earlier.

2023-08-28 Thread Heikki Linnakangas
Initialize ListenSocket array earlier. After commit b0bea38705, syslogger prints 63 warnings about failing to close a listen socket at postmaster startup. That's because the syslogger process forks before the ListenSockets array is initialized, so ClosePostmasterPorts() calls "close(0)" 64 times.

pgsql: Initialize ListenSocket array earlier.

2023-08-28 Thread Heikki Linnakangas
Initialize ListenSocket array earlier. After commit b0bea38705, syslogger prints 63 warnings about failing to close a listen socket at postmaster startup. That's because the syslogger process forks before the ListenSockets array is initialized, so ClosePostmasterPorts() calls "close(0)" 64 times.

pgsql: Initialize ListenSocket array earlier.

2023-08-28 Thread Heikki Linnakangas
Initialize ListenSocket array earlier. After commit b0bea38705, syslogger prints 63 warnings about failing to close a listen socket at postmaster startup. That's because the syslogger process forks before the ListenSockets array is initialized, so ClosePostmasterPorts() calls "close(0)" 64 times.

pgsql: Initialize ListenSocket array earlier.

2023-08-28 Thread Heikki Linnakangas
Initialize ListenSocket array earlier. After commit b0bea38705, syslogger prints 63 warnings about failing to close a listen socket at postmaster startup. That's because the syslogger process forks before the ListenSockets array is initialized, so ClosePostmasterPorts() calls "close(0)" 64 times.

pgsql: Initialize ListenSocket array earlier.

2023-08-28 Thread Heikki Linnakangas
Initialize ListenSocket array earlier. After commit b0bea38705, syslogger prints 63 warnings about failing to close a listen socket at postmaster startup. That's because the syslogger process forks before the ListenSockets array is initialized, so ClosePostmasterPorts() calls "close(0)" 64 times.

pgsql: Tweak pg_promote() to report failures on kill() or postmaster fa

2023-08-28 Thread Michael Paquier
Tweak pg_promote() to report failures on kill() or postmaster failures Since its introduction in 10074651e335, pg_promote() has been returning a false status in three cases: - SIGUSR1 not sent to the postmaster process. - Postmaster death during standby promotion. - Standby not promoted within the

pgsql: Stamp 16rc1.

2023-08-28 Thread Tom Lane
Stamp 16rc1. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d94dadcc5020f6746203896dba5a9627872ba2ee Modified Files -- configure| 18 +- configure.ac | 2 +- meson.build | 2 +- 3 files changed, 11 insertions(+), 11 deletions(

pgsql: Make error messages about WAL segment size more consistent

2023-08-28 Thread Peter Eisentraut
Make error messages about WAL segment size more consistent Make the primary messages more compact and make the detail messages uniform. In initdb.c and pg_resetwal.c, use the newish option_parse_int() to simplify some of the option parsing. For the backend GUC wal_segment_size, add a GUC check h

pgsql: Fix some typos in wait_event_names.txt

2023-08-28 Thread Michael Paquier
Fix some typos in wait_event_names.txt Noticed in passing, while hacking on a different patch touching this area. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bb9002257b2211c213ad5989446d83a61c6446d3 Modified Files -- src/backend/utils/activity/wait_

pgsql: Translation updates

2023-08-28 Thread Peter Eisentraut
Translation updates Source-Git-URL: https://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: a58360c10bd5a0f0153fcf75d0b5291ac1acecb0 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/66ed5a2e92d206ae95fa460d9e5648b636b8270a Modified Files --