pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Update comment about set_join_pathlist_hook().

2023-09-21 Thread Etsuro Fujita
Update comment about set_join_pathlist_hook(). The comment introduced by commit e7cb7ee14 was a bit too terse, which could lead to extensions doing different things within the hook function than we intend to allow. Extend the comment to explain what they can do within the hook function. Back-pat

pgsql: Allow dbname in pg_basebackup/pg_receivewal connstring

2023-09-21 Thread Daniel Gustafsson
Allow dbname in pg_basebackup/pg_receivewal connstring As physical replication work at the cluster level and not database level, any dbname in the connection string is ignored. Proxies and middleware used in connecting to the cluster might however need to know the dbname in order to make the corre

pgsql: doc: PG 16 relnotes: improve wording of promote_trigger item

2023-09-21 Thread Bruce Momjian
doc: PG 16 relnotes: improve wording of promote_trigger item Reported-by: Dave Page Author: Dave Page Backpatch-through: 16 only Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dce4544414bda6738fbec501b504d831d918defa Modified Files -- doc/sr

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions

2023-09-21 Thread Tom Lane
Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions. In older branches, COMMIT/ROLLBACK AND CHAIN failed to propagate the current transaction's properties to the new transaction if there was any open subtransaction (unreleased savepoint). Instead, some previous transaction's propertie

pgsql: Simplify information schema check constraint deparsing

2023-09-21 Thread Peter Eisentraut
Simplify information schema check constraint deparsing The computation of the column information_schema.check_constraints.check_clause used pg_get_constraintdef() plus some string manipulation to get the check clause back out. This ended up with an extra pair of parentheses, which is only an aest