Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Peter Geoghegan
On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: > Noah Misch writes: > > That's right. We don't have a standard that installcheck of v13.N will have > > zero diffs on an initdb from v13.0. > > Um ... don't we? I do not recall very many cases where we changed > initial catalog contents at all in

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Tom Lane
Peter Geoghegan writes: > On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: >> Noah Misch writes: >>> That's right. We don't have a standard that installcheck of v13.N will have >>> zero diffs on an initdb from v13.0. >> Um ... don't we? I do not recall very many cases where we changed >> initi

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

pgsql: Acquire ControlFileLock in relevant SQL functions.

2023-10-15 Thread Thomas Munro
Acquire ControlFileLock in relevant SQL functions. Commit dc7d70ea added functions that read the control file, but didn't acquire ControlFileLock. With unlucky timing, file systems that have weak interlocking like ext4 and ntfs could expose partially overwritten contents, and the checksum would f

Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic

2023-10-15 Thread Noah Misch
On Sun, Oct 15, 2023 at 05:12:58PM -0400, Tom Lane wrote: > Peter Geoghegan writes: > > On Sat, Oct 14, 2023 at 7:02 PM Tom Lane wrote: > >> Noah Misch writes: > >>> That's right. We don't have a standard that installcheck of v13.N will > >>> have > >>> zero diffs on an initdb from v13.0. > >

pgsql: Add support event triggers on authenticated login

2023-10-15 Thread Alexander Korotkov
Add support event triggers on authenticated login This commit introduces trigger on login event, allowing to fire some actions right on the user connection. This can be useful for logging or connection check purposes as well as for some personalization of environment. Usage details are described

pgsql: Fix comment from commit 22655aa231.

2023-10-15 Thread Thomas Munro
Fix comment from commit 22655aa231. Per automated complaint from BF animal koel this needed to be re-indented, but there was also a typo. Back-patch to 16. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/01529c7040088db2718628d0814058598152bd39 Modified Files

pgsql: Fix comment from commit 22655aa231.

2023-10-15 Thread Thomas Munro
Fix comment from commit 22655aa231. Per automated complaint from BF animal koel this needed to be re-indented, but there was also a typo. Back-patch to 16. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3090213690bd69dd46dae865a2021982e7309208 Modified Fil

pgsql: Fix code indentation violations in e83d1b0c40cc

2023-10-15 Thread Michael Paquier
Fix code indentation violations in e83d1b0c40cc koel has not reported this one yet, I have just bumped on it while looking at a different patch. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e9718b4bd3e4234ffd5a4907a903367fc483c843 Modified Files -- s

pgsql: Add a few recent commits to .git-blame-ignore-revs

2023-10-15 Thread Michael Paquier
Add a few recent commits to .git-blame-ignore-revs Three commits need to be added compared to the last time this file was updated: - e9718b4bd3e4 - 01529c704008 - b6a77c6a6ccf Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20b7708662c49af3cfceb23316f7448fa2cf797c

pgsql: Fix role names in src/test/authentication/t/005_login_trigger.pl

2023-10-15 Thread Alexander Korotkov
Fix role names in src/test/authentication/t/005_login_trigger.pl Per buildfarm member longfin. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/47ab5d2e2ec762c9a07b4e07f0207b8230a489c1 Modified Files -- src/test/authentication/t/005_login_trigger.pl | 26

pgsql: Rename 005_login_trigger.pl to 006_login_trigger.pl

2023-10-15 Thread Alexander Korotkov
Rename 005_login_trigger.pl to 006_login_trigger.pl In order to avoid numbering collision with 005_sspi.pl. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1f89b73c4e053c463d75608c27ca564770fd3158 Modified Files -- src/test/authentication/t/{005_login_t

Re: pgsql: Rename 005_login_trigger.pl to 006_login_trigger.pl

2023-10-15 Thread Thomas Munro
On Mon, Oct 16, 2023 at 2:04 PM Alexander Korotkov wrote: > Rename 005_login_trigger.pl to 006_login_trigger.pl > > In order to avoid numbering collision with 005_sspi.pl. Hi Alexander, Usually I notice if someone steals my TAP script number because there is git conflict in eg src/test/authentic

pgsql: worker_spi: Bump up max_worker_processes in TAP tests

2023-10-15 Thread Michael Paquier
worker_spi: Bump up max_worker_processes in TAP tests mamba has detected a failure in the last test that should start a bgworker while bypassing the role login check. The buildfarm did not provide any information about its failure in the logs, but I suspect that this is caused by an exhaustion of

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: Try to handle torn reads of pg_control in frontend.

2023-10-15 Thread Thomas Munro
Try to handle torn reads of pg_control in frontend. Some of our src/bin tools read the control file without any kind of interlocking against concurrent writes from the server. At least ext4 and ntfs can expose partially modified contents when you do that. For now, we'll try to tolerate this by r

pgsql: worker_spi: Fix test failure with BGWORKER_BYPASS_ROLELOGINCHECK

2023-10-15 Thread Michael Paquier
worker_spi: Fix test failure with BGWORKER_BYPASS_ROLELOGINCHECK This is a consequence of 4817da51f69a that has bumped up max_worker_processes, where now the last worker started by the test would be able to start by itself a parallel worker because there are more slots available. This did not sho