pgsql: meson: Improve/fix Python version selection

2023-11-29 Thread Peter Eisentraut
meson: Improve/fix Python version selection When we look for the Python installation using the meson python module, we should make it use the python program previously determined by the 'PYTHON' option. Otherwise, it will just use its own search and the 'PYTHON' option won't affect it. We need

pgsql: meson: Improve/fix Python version selection

2023-11-29 Thread Peter Eisentraut
meson: Improve/fix Python version selection When we look for the Python installation using the meson python module, we should make it use the python program previously determined by the 'PYTHON' option. Otherwise, it will just use its own search and the 'PYTHON' option won't affect it. We need

Re: pgsql: Read include/exclude commands for dump/restore from file

2023-11-29 Thread Michael Paquier
Hi Daniel, On Wed, Nov 29, 2023 at 02:21:28PM +, Daniel Gustafsson wrote: > Read include/exclude commands for dump/restore from file > > When there is a need to filter multiple tables with include and/or exclude > options it's quite possible to run into the limitations of the commandline. >

pgsql: Add tests for XID wraparound.

2023-11-29 Thread Masahiko Sawada
Add tests for XID wraparound. The test module includes helper functions to quickly burn through lots of XIDs. They are used in the tests, and are also handy for manually testing XID wraparound. Since these tests are very expensive the entire suite is disabled by default. It requires to set

pgsql: doc: Mention how to use quotes with GUC names in error messages

2023-11-29 Thread Michael Paquier
doc: Mention how to use quotes with GUC names in error messages Quotes should not be used except if a GUC name is a natural English word. Author: Álvaro Herrera Discussion: https://postgr.es/m/cahut+pv-ksn8skxsdohano_wpubqcg5789ejhcdzaclfceb...@mail.gmail.com Branch -- master Details

pgsql: Apply quotes more consistently to GUC names in logs

2023-11-29 Thread Michael Paquier
Apply quotes more consistently to GUC names in logs Quotes are applied to GUCs in a very inconsistent way across the code base, with a mix of double quotes or no quotes used. This commit removes double quotes around all the GUC names that are obviously referred to as parameters with non-English

pgsql: Add option to specify timeout seconds to BackgroundPsql.pm.

2023-11-29 Thread Masahiko Sawada
Add option to specify timeout seconds to BackgroundPsql.pm. Previously, a background psql session uses the default timeout and it cannot be overridden. This change adds a new option to set the timeout during start. There are no users of this new option. It is needed for an upcoming patch adding

pgsql: Remove unused macro

2023-11-29 Thread Peter Eisentraut
Remove unused macro Usage was removed in a33e17f210 but the definition was not removed. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a1827568d22fba9e33044b8cfc5eb19e55ad5488 Modified Files -- src/bin/pg_rewind/pg_rewind.c | 1 - 1 file changed, 1

pgsql: Improve "user mapping not found" error message

2023-11-29 Thread Peter Eisentraut
Improve "user mapping not found" error message Display the name of the foreign server for which the user mapping was not found. Author: Ian Lawrence Barwick Reviewed-by: Laurenz Albe Reviewed-by: Peter Eisentraut Discussion:

pgsql: Fix a test in 003_logical_slots.

2023-11-29 Thread Amit Kapila
Fix a test in 003_logical_slots. We allow to upgrade the slot iff there is no pending WAL to be processed. The test first disables the subscription to avoid unnecessary LOGs on the subscriber and then stops the publisher node. It is quite possible that just before the shutdown of the publisher,

pgsql: Fix wrong description of BackgroundPsql's timeout.

2023-11-29 Thread Masahiko Sawada
Fix wrong description of BackgroundPsql's timeout. Backpatch through 16 where this was introduced by 664d757531e1. Reviewed-by: Daniel Gustafsson Backpatch-through: 16 Discussion: http://postgr.es/m/cad21aobxmeqdbloduawvwotlyb4ansxx4oynmyjjbhfq_vg...@mail.gmail.com Branch -- REL_16_STABLE

pgsql: Fix wrong description of BackgroundPsql's timeout.

2023-11-29 Thread Masahiko Sawada
Fix wrong description of BackgroundPsql's timeout. Backpatch through 16 where this was introduced by 664d757531e1. Reviewed-by: Daniel Gustafsson Backpatch-through: 16 Discussion: http://postgr.es/m/cad21aobxmeqdbloduawvwotlyb4ansxx4oynmyjjbhfq_vg...@mail.gmail.com Branch -- master

pgsql: Fix BackgroundPsql's set_query_timer_restart() issue without arg

2023-11-29 Thread Masahiko Sawada
Fix BackgroundPsql's set_query_timer_restart() issue without argument. The set_query_timer_restart() required an argument to define a value to query_timer_restart, but none of the existing callers passes an argument to this function. This changes the function to set a value without an argument.

pgsql: Fix BackgroundPsql's set_query_timer_restart() issue without arg

2023-11-29 Thread Masahiko Sawada
Fix BackgroundPsql's set_query_timer_restart() issue without argument. The set_query_timer_restart() required an argument to define a value to query_timer_restart, but none of the existing callers passes an argument to this function. This changes the function to set a value without an argument.

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andres Freund
Hi, On 2023-11-29 10:05:26 -0500, Andrew Dunstan wrote: > On 2023-11-29 We 08:49, Tom Lane wrote: > > Andrew Dunstan writes: > > > On 2023-11-28 Tu 21:28, Andres Freund wrote: > > > > I don't really understand why meson compile complains in this case. I > > > > assume > > > > you don't want to

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andrew Dunstan
On 2023-11-29 We 08:49, Tom Lane wrote: Andrew Dunstan writes: On 2023-11-28 Tu 21:28, Andres Freund wrote: I don't really understand why meson compile complains in this case. I assume you don't want to disambiguate as suggested, by building html:alias instead? I've done that as a

pgsql: Fix typo in comment

2023-11-29 Thread Daniel Gustafsson
Fix typo in comment Spotted while looking over changes for another patch. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/03749325d16c4215ecd6d6a6fe117d93931d84aa Modified Files -- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Read include/exclude commands for dump/restore from file

2023-11-29 Thread Daniel Gustafsson
Read include/exclude commands for dump/restore from file When there is a need to filter multiple tables with include and/or exclude options it's quite possible to run into the limitations of the commandline. This adds a --filter=FILENAME feature to pg_dump, pg_dumpall and pg_restore which is used

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Tom Lane
Andrew Dunstan writes: > On 2023-11-28 Tu 21:28, Andres Freund wrote: >> I don't really understand why meson compile complains in this case. I assume >> you don't want to disambiguate as suggested, by building html:alias instead? > I've done that as a temporary fix to get crake out of the hole,

Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

2023-11-29 Thread Andrew Dunstan
On 2023-11-28 Tu 21:28, Andres Freund wrote: Hi, On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote: On 2023-11-20 Mo 20:53, Andres Freund wrote: meson: docs: Add {html,man} targets, rename install-doc-* We have toplevel html, man targets in the autoconf build as well. It'd be odd to have