pgsql: Initialize ShmemVariableCache like other shmem areas

2023-12-07 Thread Heikki Linnakangas
Initialize ShmemVariableCache like other shmem areas For sake of consistency. Reviewed-by: Tristan Partin, Richard Guo Discussion: https://www.postgresql.org/message-id/6537d63d-4bb5-46f8-9b5d-73a8ba472...@iki.fi Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/159

pgsql: Rename ShmemVariableCache to TransamVariables

2023-12-07 Thread Heikki Linnakangas
Rename ShmemVariableCache to TransamVariables The old name was misleading: It's not a cache, the values kept in the struct are the authoritative source. Reviewed-by: Tristan Partin, Richard Guo Discussion: https://www.postgresql.org/message-id/6537d63d-4bb5-46f8-9b5d-73a8ba472...@iki.fi Branch

pgsql: Don't try to open visibilitymap when analyzing a foreign table

2023-12-07 Thread Heikki Linnakangas
Don't try to open visibilitymap when analyzing a foreign table It's harmless, visibilitymap_count() returns 0 if the file doesn't exist. But it's also very pointless. I noticed this when I added an assertion in smgropen() that the relnumber is valid. Discussion: https://www.postgresql.org/messag

pgsql: Fix potential pointer overflow in xlogreader.c.

2023-12-07 Thread Thomas Munro
Fix potential pointer overflow in xlogreader.c. While checking if a record could fit in the circular WAL decoding buffer, the coding from commit 3f1ce973 used arithmetic that could overflow. 64 bit systems were unaffected for various technical reasons, which probably explains the lack of problem

pgsql: Fix potential pointer overflow in xlogreader.c.

2023-12-07 Thread Thomas Munro
Fix potential pointer overflow in xlogreader.c. While checking if a record could fit in the circular WAL decoding buffer, the coding from commit 3f1ce973 used arithmetic that could overflow. 64 bit systems were unaffected for various technical reasons, which probably explains the lack of problem

pgsql: Fix potential pointer overflow in xlogreader.c.

2023-12-07 Thread Thomas Munro
Fix potential pointer overflow in xlogreader.c. While checking if a record could fit in the circular WAL decoding buffer, the coding from commit 3f1ce973 used arithmetic that could overflow. 64 bit systems were unaffected for various technical reasons, which probably explains the lack of problem

pgsql: doc: clarify handling of ON CONFLICT with triggers

2023-12-07 Thread Bruce Momjian
doc: clarify handling of ON CONFLICT with triggers The previous wording was confusing. Also move partitioning mention to a more logical location. Reported-by: n...@fairwindsoft.com Discussion: https://postgr.es/m/20170703200710.27956.64...@wrigleys.postgresql.org Backpatch-through: master B

pgsql: Fix path of regress shared library in pg_upgrade test

2023-12-07 Thread Michael Paquier
Fix path of regress shared library in pg_upgrade test During a pg_upgrade test using an old dump, all references to the old regress shared library path (so, dylib or dll) are updated to point to the library path used by the new build, to ensure a consistent comparison between the old and new dumps

pgsql: Fix path of regress shared library in pg_upgrade test

2023-12-07 Thread Michael Paquier
Fix path of regress shared library in pg_upgrade test During a pg_upgrade test using an old dump, all references to the old regress shared library path (so, dylib or dll) are updated to point to the library path used by the new build, to ensure a consistent comparison between the old and new dumps

pgsql: Fix path of regress shared library in pg_upgrade test

2023-12-07 Thread Michael Paquier
Fix path of regress shared library in pg_upgrade test During a pg_upgrade test using an old dump, all references to the old regress shared library path (so, dylib or dll) are updated to point to the library path used by the new build, to ensure a consistent comparison between the old and new dumps

pgsql: doc, pg_upgrade: add vacuumdb w/ tips for generating quick stats

2023-12-07 Thread Bruce Momjian
doc, pg_upgrade: add vacuumdb w/ tips for generating quick stats Reported-by: Magnus Hagander Discussion: https://postgr.es/m/cabuevewgby-w7ektbjmy1rc+mmrl3fmrnx6yaukcr+7o9ps...@mail.gmail.com Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitd

pgsql: doc: FOR UPDATE / KEY / SHARE / KEY SHARE takes an table alias

2023-12-07 Thread Bruce Momjian
doc: FOR UPDATE / KEY / SHARE / KEY SHARE takes an table alias Previously only a table name was documented for this SELECT clause. Reported-by: robert Discussion: https://postgr.es/m/152483686904.19805.3369061025704720...@wrigleys.postgresql.org Backpatch-through: master Branch -- maste

pgsql: doc, intagg: fix one-to-many mention to many-to-many

2023-12-07 Thread Bruce Momjian
doc, intagg: fix one-to-many mention to many-to-many Reported-by: Christophe Courtois Discussion: https://postgr.es/m/aa7cfd73-0d8d-596a-b684-39faa479a...@dalibo.com Author: Christophe Courtois Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Shrink Unicode category table.

2023-12-07 Thread Jeff Davis
Shrink Unicode category table. Missing entries can implicitly be considered "unassigned". Discussion: https://postgr.es/m/ff4c2f2f9c8fc7ca27c1c24ae37ecaeaeaff6b53.ca...@j-davis.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/719b342d36ce9a049137817e93e6a18a711

pgsql: Verify that attribute counts match in ExecCopySlot

2023-12-07 Thread David Rowley
Verify that attribute counts match in ExecCopySlot tts_virtual_copyslot() contained an Assert that checked that the srcslot contained <= attributes than the dstslot. This seems to be backwards as if the srcslot contained fewer attributes then the dstslot could be left with stale Datum values from