pgsql: Fix typo and case in messages

2023-12-26 Thread John Naylor
Fix typo and case in messages Follow up to dc2123400 Kyotaro Horiguchi Discussion: https://postgr.es/m/20231222.154939.1509525390095583358.horikyota@gmail.com Discussion: https://postgr.es/m/20231225.145124.1745560266993421173.horikyota@gmail.com Branch -- master Details ---

pgsql: Add asserts to bimapset manipulation functions

2023-12-26 Thread Alexander Korotkov
Add asserts to bimapset manipulation functions New asserts validate that arguments are really bitmapsets. This should help to early detect accesses to dangling pointers. Discussion: https://postgr.es/m/CAMbWs4_wJthNtYBL%2BSsebpgF-5L2r5zFFk6xYbS0A78GKOTFHw%40mail.gmail.com Reviewed-by: Richard G

pgsql: Make replace_relid() leave argument unmodified

2023-12-26 Thread Alexander Korotkov
Make replace_relid() leave argument unmodified There are a lot of situations when we share the same pointer to a Bitmapset structure across different places. In order to evade undesirable side effects replace_relid() function should always return a copy. Reported-by: Richard Guo Discussion: htt

pgsql: REALLOCATE_BITMAPSETS manual compile-time option

2023-12-26 Thread Alexander Korotkov
REALLOCATE_BITMAPSETS manual compile-time option This option forces each bitmapset modification to reallocate bitmapset. This is useful for debugging hangling pointers to bitmapset's. Discussion: https://postgr.es/m/CAMbWs4_wJthNtYBL%2BSsebpgF-5L2r5zFFk6xYbS0A78GKOTFHw%40mail.gmail.com Reviewed

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings

2023-12-26 Thread Tom Lane
Fix failure to verify PGC_[SU_]BACKEND GUCs in pg_file_settings view. set_config_option() bails out early if it detects that the option to be set is PGC_BACKEND or PGC_SU_BACKEND class and we're reading the config file in a postmaster child; we don't want to apply any new value in such a case. Th

pgsql: Fix mistaken file name in plpython's meson recipe.

2023-12-26 Thread Tom Lane
Fix mistaken file name in plpython's meson recipe. Brown-paper-bag bug in commit 58c3151bb. Per buildfarm. Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c72049dbc341ad995579658c572a1ec8f6209f36 Modified Files -- src/pl/plpython/meson.build | 2

pgsql: Fix mistaken file name in plpython's meson recipe.

2023-12-26 Thread Tom Lane
Fix mistaken file name in plpython's meson recipe. Brown-paper-bag bug in commit 58c3151bb. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a46972e30ca7e15b667a47b57b42c9dd78bfaab8 Modified Files -- src/pl/plpython/meson.build | 2 +- 1 f

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Hide warnings from Python headers when using gcc-compatible comp

2023-12-26 Thread Tom Lane
Hide warnings from Python headers when using gcc-compatible compiler. Like commit 388e80132, use "#pragma GCC system_header" to silence warnings appearing within the Python headers, since newer Python versions no longer worry about some restrictions we still use like -Wdeclaration-after-statement.

pgsql: Add meson NLS support for pg_combinebackup

2023-12-26 Thread Peter Eisentraut
Add meson NLS support for pg_combinebackup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c4fe2e8220462a9688dba4380bda0ccb2ecaabb7 Modified Files -- src/bin/pg_combinebackup/meson.build| 2 ++ src/bin/pg_combinebackup/po/meson.build | 3 +++ 2 files c

pgsql: doc: add ISO 8601 extended format example using to_char()

2023-12-26 Thread Bruce Momjian
doc: add ISO 8601 extended format example using to_char() Reported-by: juha.musto...@iki.fi Discussion: https://postgr.es/m/20170217160154.6101.52...@wrigleys.postgresql.org Co-authored-by: Erik Wienhold Backpatch-through: master Branch -- master Details --- https://git.postgresql.o

pgsql: Add empty placeholder LINGUAS file for pg_combinebackup.

2023-12-26 Thread Tom Lane
Add empty placeholder LINGUAS file for pg_combinebackup. This will eventually be replaced once some translations exist for pg_combinebackup's messages. In the meantime, we need something here to prevent "make" from complaining in builds with --enable-nls. Per advice added in 88dad06b4. Branch -

pgsql: Remove unused macro

2023-12-26 Thread Peter Eisentraut
Remove unused macro Usage was removed in 6c5576075b but the definition was not removed. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d327f418d1e6aea1fee3105853ca5c9ef937ce1f Modified Files -- src/backend/utils/mb/conversion_procs/euc_tw_and_big5/euc_

pgsql: Fix some translatable strings in pg_basebackup and pg_combinebac

2023-12-26 Thread Michael Paquier
Fix some translatable strings in pg_basebackup and pg_combinebackup Two translatable strings introduced in dc212340058b were split into two parts, making their translation harder than necessary. Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20231225.134747.2287499067164862136.horikyo