Re: pgsql: Re-validate connection string in libpqrcv_connect().

2024-01-12 Thread Jeff Davis
On Fri, 2024-01-12 at 21:43 +, Jeff Davis wrote: > Re-validate connection string in libpqrcv_connect(). Looks like the test is causing problems on drogo: ERROR: could not connect to the publisher: connection to server at "127.0.0.1", port 54707 failed: FATAL: SSPI authentication failed for

pgsql: Fix memory leak in connection string validation.

2024-01-12 Thread Jeff Davis
Fix memory leak in connection string validation. Introduced in commit c3afe8cf5a. Discussion: https://postgr.es/m/066a65233d3cb4ea27a9e0778d2f1d0dc764b222.ca...@j-davis.com Reviewed-by: Nathan Bossart, Tom Lane Backpatch-through: 16 Branch -- REL_16_STABLE Details --- https://git.postg

pgsql: Fix memory leak in connection string validation.

2024-01-12 Thread Jeff Davis
Fix memory leak in connection string validation. Introduced in commit c3afe8cf5a. Discussion: https://postgr.es/m/066a65233d3cb4ea27a9e0778d2f1d0dc764b222.ca...@j-davis.com Reviewed-by: Nathan Bossart, Tom Lane Backpatch-through: 16 Branch -- master Details --- https://git.postgresql.o

pgsql: Add empty placeholder LINGUAS file for pg_walsummary

2024-01-12 Thread Alvaro Herrera
Add empty placeholder LINGUAS file for pg_walsummary Like bbf1f1340800. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2f696d5a290229a95fd80e351e4e6ecf8d4a Modified Files -- src/bin/pg_walsummary/po/LINGUAS | 0 1 file changed, 0 insertions(+), 0 de

pgsql: Re-validate connection string in libpqrcv_connect().

2024-01-12 Thread Jeff Davis
Re-validate connection string in libpqrcv_connect(). A superuser may create a subscription with password_required=true, but which uses a connection string without a password. Previously, if the owner of such a subscription was changed to a non-superuser, the non-superuser was able to utilize a pa

pgsql: Re-validate connection string in libpqrcv_connect().

2024-01-12 Thread Jeff Davis
Re-validate connection string in libpqrcv_connect(). A superuser may create a subscription with password_required=true, but which uses a connection string without a password. Previously, if the owner of such a subscription was changed to a non-superuser, the non-superuser was able to utilize a pa

Re: pgsql: Add new pg_walsummary tool.

2024-01-12 Thread Robert Haas
On Thu, Jan 11, 2024 at 1:49 PM Robert Haas wrote: > On Thu, Jan 11, 2024 at 12:56 PM Robert Haas wrote: > > Add new pg_walsummary tool. > > culicidae is unhappy with this, but I don't yet understand why. The output is: > > # Failed test 'stdout shows block 0 modified' > # at t/002_blocks.pl

Re: pgsql: Add new pg_walsummary tool.

2024-01-12 Thread Robert Haas
On Thu, Jan 11, 2024 at 12:56 PM Robert Haas wrote: > Add new pg_walsummary tool. culicidae is unhappy with this, but I don't yet understand why. The output is: # Failed test 'stdout shows block 0 modified' # at t/002_blocks.pl line 85. # 'TS 1663, DB 5, REL 16384, FORK mai

pgsql: Refactor ATExecAddColumn() to use BuildDescForRelation()

2024-01-12 Thread Peter Eisentraut
Refactor ATExecAddColumn() to use BuildDescForRelation() BuildDescForRelation() has all the knowledge for converting a ColumnDef into pg_attribute/tuple descriptor. ATExecAddColumn() can make use of that, instead of duplicating all that logic. We just pass a one-element list of ColumnDef and we

pgsql: Fix typo.

2024-01-12 Thread Robert Haas
Fix typo. Noriyoshi Shinoda Discussion: http://postgr.es/m/dm4pr84mb17347d9466419413698105d8ee...@dm4pr84mb1734.namprd84.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/882887e9b458f533b301c36951c93dfdd37dccfc Modified Files -- doc/sr

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- REL_12_STABLE Details --- https://git.pos

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- REL_16_STABLE Details --- https://git.pos

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- REL_14_STABLE Details --- https://git.pos

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- REL_13_STABLE Details --- https://git.pos

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- REL_15_STABLE Details --- https://git.pos

pgsql: Added literal tag for RETURNING

2024-01-12 Thread Alvaro Herrera
Added literal tag for RETURNING This is an old mistake (92e38182d7c8); backpatch all the way back. Author: Atsushi Torikoshi Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/c0aa00b60a16c0ea2a4c5123b013a...@oss.nttdata.com Branch -- master Details --- https://git.postgresql