pgsql: Revert "Add notBefore and notAfter to SSL cert info display"

2024-03-22 Thread Daniel Gustafsson
Revert "Add notBefore and notAfter to SSL cert info display" This reverts commit 6acb0a628eccab8764e0306582c2b7e2a1441b9b since LibreSSL didn't support ASN1_TIME_diff until OpenBSD 7.1, leaving the older OpenBSD animals in the buildfarm complaining. Per plover in the buildfarm. Discussion: https

Re: pgsql: Add notBefore and notAfter to SSL cert info display

2024-03-22 Thread Daniel Gustafsson
> On 22 Mar 2024, at 22:46, Jacob Champion > wrote: > > On Fri, Mar 22, 2024 at 2:17 PM Daniel Gustafsson wrote: >> (We have only defined a minimum supported >> version of OpenSSL, we should do the same for LibreSSL since it's right now >> unclear what we support and for how long.) > > +1 > >

Re: pgsql: Add notBefore and notAfter to SSL cert info display

2024-03-22 Thread Jacob Champion
On Fri, Mar 22, 2024 at 2:17 PM Daniel Gustafsson wrote: > (We have only defined a minimum supported > version of OpenSSL, we should do the same for LibreSSL since it's right now > unclear what we support and for how long.) +1 > Adding checks for symbol existence > in autoconf/meson seems like t

Re: pgsql: Add notBefore and notAfter to SSL cert info display

2024-03-22 Thread Daniel Gustafsson
> On 22 Mar 2024, at 21:30, Daniel Gustafsson > wrote: > > Add notBefore and notAfter to SSL cert info display plover running OpenBSD 6.9 is unhappy since apparently LibreSSL only added ASN time diffing in the OpenBSD 7.1 release. Version 6.9 is out of support from OpenBSD with 7.4 being the l

pgsql: Use a hash table for catcache.c's CatCList objects.

2024-03-22 Thread Tom Lane
Use a hash table for catcache.c's CatCList objects. Up to now, all of the "catcache list" objects within a catalog cache were just chained together on a single dlist, requiring O(N) time to search. Remarkably, we've not had serious performance problems with that so far; but we got a complaint of

pgsql: Use a hash table for catcache.c's CatCList objects.

2024-03-22 Thread Tom Lane
Use a hash table for catcache.c's CatCList objects. Up to now, all of the "catcache list" objects within a catalog cache were just chained together on a single dlist, requiring O(N) time to search. Remarkably, we've not had serious performance problems with that so far; but we got a complaint of

pgsql: Add notBefore and notAfter to SSL cert info display

2024-03-22 Thread Daniel Gustafsson
Add notBefore and notAfter to SSL cert info display This adds the X509 attributes notBefore and notAfter to sslinfo as well as pg_stat_ssl to allow verifying and identifying the validity period of the current client certificate. OpenSSL has APIs for extracting notAfter and notBefore, but they are

pgsql: Fix an oversight in refactoring in 06b10f80ba4.

2024-03-22 Thread Alexander Korotkov
Fix an oversight in refactoring in 06b10f80ba4. It was against intended skipping prechecking keys optimization in the first page of range queries to not influence point queries performance. Reported-by: Anton Melnikov Discussion: https://postgr.es/m/30cd7524-b9f1-4cf8-9c4a-223eb2e34441%40postgre

pgsql: Do not output actual value of location fields in node serializat

2024-03-22 Thread Peter Eisentraut
Do not output actual value of location fields in node serialization by default This changes nodeToString() to not output the actual value of location fields in nodes, but instead it writes -1. This mirrors the fact that stringToNode() also does not read location field values but always stores -1.

pgsql: Track invalidation_reason in pg_replication_slots.

2024-03-22 Thread Amit Kapila
Track invalidation_reason in pg_replication_slots. Till now, the reason for replication slot invalidation is not tracked directly in pg_replication_slots. A recent commit 007693f2a3 added 'conflict_reason' to show the reasons for slot conflict/invalidation, but only for logical slots. This commit