pgsql: Add unicode_strtitle() for Unicode Default Case Conversion.

2024-03-29 Thread Jeff Davis
Add unicode_strtitle() for Unicode Default Case Conversion. This brings the titlecasing implementation for the builtin provider out of formatting.c and into unicode_case.c, along with unicode_strlower() and unicode_strupper(). Accepts an arbitrary word boundary callback. Simple for now, but can b

pgsql: Remove superfluous trailing semicolons

2024-03-29 Thread Daniel Gustafsson
Remove superfluous trailing semicolons Two semicolons were accidentally added to rows which were already terminated semicolons. While harmless, fix by removing these. Author: Richard Guo Discussion: https://postgr.es/m/cambws4_fnj0+yogfioswzle7t6r8p6cqbuacfvezqbesfaj...@mail.gmail.com Branch

pgsql: Use version for builtin collations.

2024-03-29 Thread Jeff Davis
Use version for builtin collations. Given that the version field already exists, there's little reason not to use it. Suggestion from Peter Eisentraut. Discussion: https://postgr.es/m/613c120a-5413-4fa7-a501-6590eae55...@eisentraut.org Reviewed-by: Peter Eisentraut Branch -- master Details

Re: pgsql: Add allow_alter_system GUC.

2024-03-29 Thread Bruce Momjian
On Fri, Mar 29, 2024 at 08:47:18AM -0400, Robert Haas wrote: > Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this > commit message. :-( > > Please accept my apologies. I have made a record of this so I will make sure it is accurate in the release notes. -- Bruce Momjian

pgsql: Try to stabilize flappy test result.

2024-03-29 Thread Tom Lane
Try to stabilize flappy test result. This recently-added test case checks the plan of an inner join between two identical tables. It's just chance which join order the planner will pick, and in the presence of any variation in the underlying statistics, the displayed plan might change. Add a WHER

Re: pgsql: Add allow_alter_system GUC.

2024-03-29 Thread Robert Haas
On Fri, Mar 29, 2024 at 9:03 AM Jelte Fennema-Nio wrote: > no worries, these things happen. I'm just glad it's committed and I > can now focus on different things than back and forth discussion over > documentation that all looks pretty much identical to me. Yeah, imagine that! -- Robert Haas E

Re: pgsql: Add allow_alter_system GUC.

2024-03-29 Thread Jelte Fennema-Nio
no worries, these things happen. I'm just glad it's committed and I can now focus on different things than back and forth discussion over documentation that all looks pretty much identical to me. On Fri, 29 Mar 2024 at 13:47, Robert Haas wrote: > > Oh no! Jelte, I'm so sorry ... I spelled your na

Re: pgsql: Add allow_alter_system GUC.

2024-03-29 Thread Robert Haas
Oh no! Jelte, I'm so sorry ... I spelled your name wrong in this commit message. :-( Please accept my apologies. ...Robert On Fri, Mar 29, 2024 at 8:45 AM Robert Haas wrote: > > Add allow_alter_system GUC. > > This is marked PGC_SIGHUP, so it can only be set in a configuration > file, not anywh

pgsql: Add allow_alter_system GUC.

2024-03-29 Thread Robert Haas
Add allow_alter_system GUC. This is marked PGC_SIGHUP, so it can only be set in a configuration file, not anywhere else; and it is also marked GUC_DISALLOW_IN_AUTO_FILE, so it can't be set using ALTER SYSTEM. When set to false, the ALTER SYSTEM command is disallowed. There was considerable concer