Re: pgsql: SQL/JSON: Fix issues with DEFAULT .. ON ERROR / EMPTY

On Thu, Apr 18, 2024 at 3:51 PM Amit Langote wrote: > SQL/JSON: Fix issues with DEFAULT .. ON ERROR / EMPTY > > SQL/JSON query functions allow specifying an expression to return > when either of ON ERROR or ON EMPTY condition occurs when evaluating > the JSON path expression. The parser (transfor

pgsql: Fix object name clash in recently introduced test

Fix object name clash in recently introduced test c0fc0751862 wasn't careful about naming the DOMAIN used in some new tests in sqljson_queryfunc.sql so as not to clash with the name of a DOMAIN used in the nearby sqljson_jsontable.sql. Fix by using a different name for the newly added DOMAIN in s

pgsql: Update src/tools/pginclude/README to match recent changes to cpl

Update src/tools/pginclude/README to match recent changes to cpluspluscheck Commit 7b8e2ae2f has turned cpluspluscheck from separate script into a --cplusplus option for headerscheck. Update README correspondingly. Author: Anton Voloshin Discussion: https://www.postgresql.org/message-id/02e69f

pgsql: Fix restore of not-null constraints with inheritance

Fix restore of not-null constraints with inheritance In tables with primary keys, pg_dump creates tables with primary keys by initially dumping them with throw-away not-null constraints (marked "no inherit" so that they don't create problems elsewhere), to later drop them once the primary key is r

pgsql: docs: Mention that pg_combinebackup does not verify backups.

docs: Mention that pg_combinebackup does not verify backups. We don't want users to think that pg_combinebackup is trying to check the validity of individual backups, because it isn't. Adjust the wording about sanity checks to make it clear that verification of individual backups is the job of pg_

Re: pgsql: Fix restore of not-null constraints with inheritance

On 2024-Apr-18, Alvaro Herrera wrote: > Lastly, make two changes to pg_dump: 1) do not try to drop a not-null > constraint that's marked as inherited; this allows a dump to restore > with no errors if a table with a PK inherits from another which also has > a PK; 2) avoid giving inherited constrai

pgsql: Don't try to assign smart names to constraints

Don't try to assign smart names to constraints This part of my previous commit seems to have broken pg_upgrade on crake, at least from 9.2. I'll see if there's a better fix, but in the meantime this should suffice to keep the buildfarm green. Branch -- master Details --- https://git.pos

pgsql: Restrict where INCREMENTAL.${NAME} files are recognized.

Restrict where INCREMENTAL.${NAME} files are recognized. Previously, they were recognized anywhere in an incremental backup directory; now, we restrict this to places where they are expected to appear. That means this code will need updating if we ever do incremental backups of files in other plac

pgsql: Don't try to fix eliminated nbtree array scan keys.

Don't try to fix eliminated nbtree array scan keys. Preprocessing for nbtree index scans allowed array "input" scan keys already marked eliminated during array-specific preprocessing to be "fixed up" during preprocessing proper. This allowed eliminated scan keys on DESC index columns to spurious

pgsql: Remove spurious "the".

Remove spurious "the". Spotted by Martin Marqués. Discussion: http://postgr.es/m/cabeg9lvqmtskrokhca_mkju1duarw4v+smejkurygjpvbzf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fbed6ebe41beb72d9b7978a414ed4e8515ed1b19 Modified Files ---

pgsql: Fix typos and duplicate words

Fix typos and duplicate words This fixes various typos, duplicated words, and tiny bits of whitespace mainly in code comments but also in docs. Author: Daniel Gustafsson Author: Heikki Linnakangas Author: Alexander Lakhin Author: David Rowley Author: Nazir Bilal Yavuz Discussion: https://pos

pgsql: Doc: Update link to the mentioned subsection

Doc: Update link to the mentioned subsection This updates the link from pg_createsubscriber to initial data sync to actually link to the subsection in question as opposed to the main logical replication section. Author: Pavel Luzanov Discussion: https://postgr.es/m/a4af555a-ac60-4416-877d-0440d

Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.

On 2024-04-16 Tu 12:31, Tom Lane wrote: Fix assorted bugs in ecpg's macro mechanism. Buildfarm animals running the old MSVC build system don't like this. It looks to me like we'll need an adjustment in src/tools/msvc/ecpg_regression.proj to replicate the special rules surrounding define.c

Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.

Andrew Dunstan writes: > On 2024-04-16 Tu 12:31, Tom Lane wrote: >> Fix assorted bugs in ecpg's macro mechanism. > Buildfarm animals running the old MSVC build system don't like this. Oh, duh, I'd already forgotten about that... > It looks to me like we'll need an adjustment in > src/tools/msv

pgsql: Fix MSVC recipe for ecpg regression tests.

Fix MSVC recipe for ecpg regression tests. While back-patching commit 6f0cef935, I forgot that the MSVC build scripts would also need adjustment in the back branches. This is a blind attempt at a fix, but it's basically copying nearby code so I think it will work. Per buildfarm (via Andrew Dunsta

pgsql: Fix MSVC recipe for ecpg regression tests.

Fix MSVC recipe for ecpg regression tests. While back-patching commit 6f0cef935, I forgot that the MSVC build scripts would also need adjustment in the back branches. This is a blind attempt at a fix, but it's basically copying nearby code so I think it will work. Per buildfarm (via Andrew Dunsta

pgsql: Fix MSVC recipe for ecpg regression tests.

Fix MSVC recipe for ecpg regression tests. While back-patching commit 6f0cef935, I forgot that the MSVC build scripts would also need adjustment in the back branches. This is a blind attempt at a fix, but it's basically copying nearby code so I think it will work. Per buildfarm (via Andrew Dunsta

pgsql: Fix MSVC recipe for ecpg regression tests.

Fix MSVC recipe for ecpg regression tests. While back-patching commit 6f0cef935, I forgot that the MSVC build scripts would also need adjustment in the back branches. This is a blind attempt at a fix, but it's basically copying nearby code so I think it will work. Per buildfarm (via Andrew Dunsta

pgsql: Fix MSVC recipe for ecpg regression tests.

Fix MSVC recipe for ecpg regression tests. While back-patching commit 6f0cef935, I forgot that the MSVC build scripts would also need adjustment in the back branches. This is a blind attempt at a fix, but it's basically copying nearby code so I think it will work. Per buildfarm (via Andrew Dunsta

pgsql: Fix MSVC recipe for ecpg regression tests, redux.

Fix MSVC recipe for ecpg regression tests, redux. Forgot to inject -DCMDLINESYM=123 ... Per buildfarm. Discussion: https://postgr.es/m/4cc4dc47-ca2b-4129-8784-db69b5f82...@dunslane.net Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dd3fddc8519a7d18cc02045

pgsql: Fix MSVC recipe for ecpg regression tests, redux.

Fix MSVC recipe for ecpg regression tests, redux. Forgot to inject -DCMDLINESYM=123 ... Per buildfarm. Discussion: https://postgr.es/m/4cc4dc47-ca2b-4129-8784-db69b5f82...@dunslane.net Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c6bfeab42ba203d0565a226

pgsql: Fix MSVC recipe for ecpg regression tests, redux.

Fix MSVC recipe for ecpg regression tests, redux. Forgot to inject -DCMDLINESYM=123 ... Per buildfarm. Discussion: https://postgr.es/m/4cc4dc47-ca2b-4129-8784-db69b5f82...@dunslane.net Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cd26f08e4770fb9d029e51d

pgsql: Fix MSVC recipe for ecpg regression tests, redux.

Fix MSVC recipe for ecpg regression tests, redux. Forgot to inject -DCMDLINESYM=123 ... Per buildfarm. Discussion: https://postgr.es/m/4cc4dc47-ca2b-4129-8784-db69b5f82...@dunslane.net Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f7e8917481b5d84714a1399

pgsql: Fix MSVC recipe for ecpg regression tests, redux.

Fix MSVC recipe for ecpg regression tests, redux. Forgot to inject -DCMDLINESYM=123 ... Per buildfarm. Discussion: https://postgr.es/m/4cc4dc47-ca2b-4129-8784-db69b5f82...@dunslane.net Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/de84608e263920a77f2c1b2