pgsql: Revert temporal primary keys and foreign keys

2024-05-15 Thread Peter Eisentraut
Revert temporal primary keys and foreign keys This feature set did not handle empty ranges correctly, and it's now too late for PostgreSQL 17 to fix it. The following commits are reverted: 6db4598fcb8 Add stratnum GiST support function 46a0cd4cefb Add temporal PRIMARY KEY and UNIQUE cons

pgsql: doc PG 17 relnotes: wording adjustments

2024-05-15 Thread Bruce Momjian
doc PG 17 relnotes: wording adjustments Reported-by: jian he Discussion: https://postgr.es/m/cacjufxhtjbqdmbc4ipgte_xd4amgonrm680ji5m5gca8+ye...@mail.gmail.com Co-authored-by: jian he Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f6e

pgsql: doc PG 17 relnotes: add item about vacuum storage/limits/WAL

2024-05-15 Thread Bruce Momjian
doc PG 17 relnotes: add item about vacuum storage/limits/WAL Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/202405150838.sg5ddcexyyf4@alvherre.pgsql Backpatch-through: master Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a8010d03e1f30c657b6c868fa85

pgsql: jit: Remove {llvm-config,clang}-N configure probes.

2024-05-15 Thread Thomas Munro
jit: Remove {llvm-config,clang}-N configure probes. Previously we searched for llvm-config-N and clang-N as well as the unversioned names, and maintained a list of expected values of N. There doesn't seem to be any reason to think that the default llvm-config and clang won't be good enough, and i

pgsql: Fix some inconsistencies in EXPLAIN output

2024-05-15 Thread David Rowley
Fix some inconsistencies in EXPLAIN output 06286709e added a SERIALIZE option to EXPLAIN which included showing the amount of kilobytes serialized. The calculation to convert bytes into kilobytes wasn't consistent with how that's done in the rest of EXPLAIN. Traditionally we round up to the neare

pgsql: doc: Mention more variant --name=value of -c name=value for post

2024-05-15 Thread Michael Paquier
doc: Mention more variant --name=value of -c name=value for postgres postgres --name=value and -c name=value are equivalents. This commit expands the documentation of libpq's "option" connection parameter and the server startup sequence for shell interactions to mention both rather than only -c.

pgsql: Doc: update src/tools/pgindent/README for current practice.

2024-05-15 Thread Tom Lane
Doc: update src/tools/pgindent/README for current practice. This README explains how to run pgindent, but it was written for our former practice of running pgindent only infrequently. Nowadays the plan is to keep the tree indent-clean all the time, so the typical thing is to do an incremental pgin

pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade 9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the outer level, but left the PQclear and query buffer destruction in the is_index conditional. 353708e1fb2d fixed the leak of the query buffer but left the PGresult leak. This moves cl

pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade 9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the outer level, but left the PQclear and query buffer destruction in the is_index conditional. 353708e1fb2d fixed the leak of the query buffer but left the PGresult leak. This moves cl

pgsql: Fix query result leak during binary upgrade

2024-05-15 Thread Daniel Gustafsson
Fix query result leak during binary upgrade 9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the outer level, but left the PQclear and query buffer destruction in the is_index conditional. 353708e1fb2d fixed the leak of the query buffer but left the PGresult leak. This moves cl

pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are proces

pgsql: Re-forbid underscore in positional parameters

2024-05-15 Thread Peter Eisentraut
Re-forbid underscore in positional parameters Underscores were added to numeric literals in faff8f8e47. This change also affected the positional parameters (e.g., $1) rule, which uses the same production for its digits. But this did not actually work, because the digits for parameters are proces

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_15_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_14_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_12_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_16_STABLE Details

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details --- htt

pgsql: doc: Add standard Environment section to pg_amcheck ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_amcheck ref page Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cff942453f21ad1

pgsql: doc: Add standard Environment section to pg_upgrade ref page

2024-05-15 Thread Peter Eisentraut
doc: Add standard Environment section to pg_upgrade ref page Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/96bc29edfde9b8a

pgsql: doc: Remove claims that initdb and pg_ctl use libpq environment

2024-05-15 Thread Peter Eisentraut
doc: Remove claims that initdb and pg_ctl use libpq environment variables Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org Branch -- REL_13_STABLE Details

pgsql: Remove stray blank line among gram.y keywords

2024-05-15 Thread Peter Eisentraut
Remove stray blank line among gram.y keywords introduced by de3600452b Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/54cf0c51184fde6e4c01059be0080b5a60ce6802 Modified Files -- src/backend/parser/gram.y | 1 - 1 file changed, 1 deletion(-)

pgsql: Make all Perl warnings fatal, catch-up

2024-05-15 Thread Peter Eisentraut
Make all Perl warnings fatal, catch-up Apply c5385929593 to new Perl files that had missed the note. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cc70e170c0213977c106a61c8cedeaac83136c3d Modified Files -- src/bin/pg_walsummary/t/001_basic.pl