Re: pgsql: Wait for WAL summarization to catch up before creating .partial

2024-07-27 Thread Tom Lane
Alexander Korotkov writes: > It appears that I was late with my review [1]. But the new tap test > could still use pgperltidy. I believe our current policy is that we're asking committers to maintain pgindent cleanliness, but not pgperltidy (which is why BF member koel isn't checking pgperltidy)

Re: pgsql: Wait for WAL summarization to catch up before creating .partial

2024-07-27 Thread Alexander Korotkov
On Fri, Jul 26, 2024 at 10:01 PM Robert Haas wrote: > Wait for WAL summarization to catch up before creating .partial file. > > When a standby is promoted, CleanupAfterArchiveRecovery() may decide > to rename the final WAL file from the old timeline by adding ".partial" > to the name. If WAL summa

pgsql: Doc: fix text's description of regexp_replace's arguments.

2024-07-27 Thread Tom Lane
Doc: fix text's description of regexp_replace's arguments. Section 9.7.3 had a syntax synopsis for regexp_replace() that was different from Table 9.10's, but still wrong. Update that one too. Oversight in 580f8727c. Jian He Discussion: https://postgr.es/m/CACJufxG3NFKKsh6x4fRLv8h3V-HvN4W5dA=zn

pgsql: Optimize escaping of JSON strings

2024-07-27 Thread David Rowley
Optimize escaping of JSON strings There were quite a few places where we either had a non-NUL-terminated string or a text Datum which we needed to call escape_json() on. Many of these places required that a temporary string was created due to the fact that escape_json() needs a NUL-terminated cst

pgsql: Fallback to uuid for ossp-uuid with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to uuid for ossp-uuid with meson The upstream name for the ossp-uuid package / pkg-config file is "uuid". Many distributions change this to be "ossp-uuid" to not conflict with e2fsprogs. This lookup fails on distributions which don't change this name, for example NixOS / nixpkgs. Both "o

pgsql: Support absolute bindir/libdir in regression tests with meson

2024-07-27 Thread Heikki Linnakangas
Support absolute bindir/libdir in regression tests with meson Passing an absolute bindir/libdir will install the binaries and libraries to /tmp_install/ and /tmp_install/ respectively. This path is correctly passed to the regression test suite via configure/make, but not via meson, yet. This is b

pgsql: Fallback to clang in PATH with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to clang in PATH with meson Some distributions put clang into a different path than the llvm binary path. For example, this is the case on NixOS / nixpkgs, which failed to find clang with meson before this patch. Author: Wolfgang Walther Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, P

pgsql: Fallback to uuid for ossp-uuid with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to uuid for ossp-uuid with meson The upstream name for the ossp-uuid package / pkg-config file is "uuid". Many distributions change this to be "ossp-uuid" to not conflict with e2fsprogs. This lookup fails on distributions which don't change this name, for example NixOS / nixpkgs. Both "o

pgsql: Fallback to clang in PATH with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to clang in PATH with meson Some distributions put clang into a different path than the llvm binary path. For example, this is the case on NixOS / nixpkgs, which failed to find clang with meson before this patch. Author: Wolfgang Walther Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, P

pgsql: Support falling back to non-preferred readline implementation wi

2024-07-27 Thread Heikki Linnakangas
Support falling back to non-preferred readline implementation with meson To build with -Dreadline=enabled one can use either readline or libedit. The -Dlibedit_preferred flag is supposed to control the order of names to lookup. This works fine when either both libraries are present or -Dreadline

pgsql: Support falling back to non-preferred readline implementation wi

2024-07-27 Thread Heikki Linnakangas
Support falling back to non-preferred readline implementation with meson To build with -Dreadline=enabled one can use either readline or libedit. The -Dlibedit_preferred flag is supposed to control the order of names to lookup. This works fine when either both libraries are present or -Dreadline

pgsql: Support absolute bindir/libdir in regression tests with meson

2024-07-27 Thread Heikki Linnakangas
Support absolute bindir/libdir in regression tests with meson Passing an absolute bindir/libdir will install the binaries and libraries to /tmp_install/ and /tmp_install/ respectively. This path is correctly passed to the regression test suite via configure/make, but not via meson, yet. This is b

pgsql: Support absolute bindir/libdir in regression tests with meson

2024-07-27 Thread Heikki Linnakangas
Support absolute bindir/libdir in regression tests with meson Passing an absolute bindir/libdir will install the binaries and libraries to /tmp_install/ and /tmp_install/ respectively. This path is correctly passed to the regression test suite via configure/make, but not via meson, yet. This is b

pgsql: Fallback to uuid for ossp-uuid with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to uuid for ossp-uuid with meson The upstream name for the ossp-uuid package / pkg-config file is "uuid". Many distributions change this to be "ossp-uuid" to not conflict with e2fsprogs. This lookup fails on distributions which don't change this name, for example NixOS / nixpkgs. Both "o

pgsql: Support falling back to non-preferred readline implementation wi

2024-07-27 Thread Heikki Linnakangas
Support falling back to non-preferred readline implementation with meson To build with -Dreadline=enabled one can use either readline or libedit. The -Dlibedit_preferred flag is supposed to control the order of names to lookup. This works fine when either both libraries are present or -Dreadline

pgsql: Fallback to clang in PATH with meson

2024-07-27 Thread Heikki Linnakangas
Fallback to clang in PATH with meson Some distributions put clang into a different path than the llvm binary path. For example, this is the case on NixOS / nixpkgs, which failed to find clang with meson before this patch. Author: Wolfgang Walther Reviewed-by: Nazir Bilal Yavuz, Alvaro Herrera, P